[Breeze] [Bug 340617] New: Breeze dark theme has bright breeze dialog background

2014-11-03 Thread a.pronobis
https://bugs.kde.org/show_bug.cgi?id=340617 Bug ID: 340617 Summary: Breeze dark theme has bright breeze dialog background Product: Breeze Version: 5.1.0 Platform: Ubuntu Packages URL: https://dl.dropboxusercontent.com/u/3454148/

Review Request 120965: Base panelcontroller and more settings menu on button sizes

2014-11-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120965/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 120961: Use Loader for "More Settings" menu in panelcontroller

2014-11-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120961/ --- (Updated Nov. 3, 2014, 9:22 p.m.) Status -- This change has been mar

Re: Review Request 120961: Use Loader for "More Settings" menu in panelcontroller

2014-11-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120961/#review69757 --- Ship it! Inviala! - Marco Martin On Nov. 3, 2014, 8:47 p.m

Review Request 120961: Use Loader for "More Settings" menu in panelcontroller

2014-11-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120961/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem

2014-11-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120943/#review69755 --- applets/notifications/package/contents/ui/NotificationPopup.q

Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem

2014-11-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120943/ --- (Updated Nov. 3, 2014, 8:26 nachm.) Review request for Plasma and Martin

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

2014-11-03 Thread Hrvoje Senjan
> On Oct. 30, 2014, 11:39 a.m., Ian Wadham wrote: > > The following ideas are concerns about design, rather than coding. > > > > I do not know what the underlying objectives of Frameworks are, including > > who is intended to use it and for what, so I will be guided by you and > > Thomas and t

[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.

2014-11-03 Thread donniezazen
https://bugs.kde.org/show_bug.cgi?id=340580 --- Comment #2 from donniezazen --- Already tried that and it doesn't do anything. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org

[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.

2014-11-03 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=340580 Martin Klapetek changed: What|Removed |Added Resolution|WORKSFORME |WAITINGFORINFO -- You are receiving this mai

[Breeze] [Bug 340580] KDE Apps' toolbars and dialog options don't have icons just empty spaces.

2014-11-03 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=340580 Martin Klapetek changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution|---

Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem

2014-11-03 Thread Martin Klapetek
> On Nov. 3, 2014, 10:18 a.m., Kai Uwe Broulik wrote: > > applets/notifications/package/contents/ui/NotificationDelegate.qml, lines > > 273-278 > > > > > > Do we really need that? I'm really not sure, I can loo

Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem

2014-11-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120943/#review69738 --- I think it's a good approach and quite possibly worth pursuing

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-03 Thread Jeremy Whiting
> On Nov. 3, 2014, 1:47 a.m., Sebastian Kügler wrote: > > What's the purpose of this approach? It was the only way I could think of to split the image, I'm open to better ideas though. - Jeremy --- This is an automatically generated e-

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review69710 --- image provider is the best way I can think to solve it too.

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-03 Thread Marco Martin
> On Nov. 3, 2014, 2:44 p.m., Marco Martin wrote: > > I think is the right way for Oxygen, since doesn't require any modification > > to the kde4 version. > > Breeze will need the same thing.. > > even tough perhaps would be better to just make the kde4 version of breeze > > read/write into ~/.

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-03 Thread Martin Gräßlin
> On Nov. 3, 2014, 3:44 p.m., Marco Martin wrote: > > I think is the right way for Oxygen, since doesn't require any modification > > to the kde4 version. > > Breeze will need the same thing.. > > even tough perhaps would be better to just make the kde4 version of breeze > > read/write into ~/.

Re: Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/#review69731 --- I think is the right way for Oxygen, since doesn't require any

Review Request 120957: Oxygen: Sync advanced settings to KDE4

2014-11-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen

Jenkins build is back to normal : plasma-desktop_master_qt5 #782

2014-11-03 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-03 Thread Ashish Bansal
> On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: > > browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 > > > > > > where do you get these from? > > Ashish Bansal wrote: > I made these keys

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-03 Thread Bhushan Shah
> On Nov. 3, 2014, 9:18 a.m., Shantanu Tushar wrote: > > browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 > > > > > > where do you get these from? > > Ashish Bansal wrote: > I made these keys

Jenkins build became unstable: plasma-workspace_master_qt5 #1021

2014-11-03 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-03 Thread Ashish Bansal
> On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: > > Thanks for your time on this, good stuff :) Tried it and the only caveat is > > that after login is done I have to press the back button (the one on the > > pmc controller) to get my album list. That should be fixed. Yeah I also figured

Build failed in Jenkins: plasma-desktop_master_qt5 #781

2014-11-03 Thread KDE CI System
See Changes: [hein] Launch new instances on Shift+Click. -- [...truncated 1187 lines...] :275:14:

Re: Review Request 120538: Update default applications in kickoff

2014-11-03 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/ --- (Updated Nov. 3, 2014, 1:36 p.m.) Status -- This change has been mar

Plasma port to Wayland

2014-11-03 Thread Pier Luigi Fiorini
Hi, As some of you might know I've been working on the Plasma port to Wayland. I would like to give you some pointers where the on going effort is. Last month I've been super busy with other stuff, but I plan to resume my work on Wayland during November. You can see it in action on my composito

Minutes Monday Plasma Hangout

2014-11-03 Thread Sebastian Kügler
Minutes Plasma Hangout, 3-11-2014 Present: David, Harald, Jonathan, Kai Uwe, Marco, Martin G., Martin K., Sebastian David: - plugged memleak in SDDM - worked with Aleix on trying to fix multiscreen, ran into more problems - We really need to fix QScreen Harald: - We have weekly ISOs again! - v

Re: Review Request 120538: Update default applications in kickoff

2014-11-03 Thread Eike Hein
> On Nov. 3, 2014, 9:56 a.m., Sebastian Kügler wrote: > > Can this RR be closed or abandoned? I kind of forgot what the result was, but I remember writing most of the Kicker patch and then abandoning it for $reasons ... I guess the idea was to implement it in kamd instead because of the kamd f

Re: Review Request 120538: Update default applications in kickoff

2014-11-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120538/#review69719 --- Can this RR be closed or abandoned? - Sebastian Kügler On O

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review69718 --- looks a bit overkill? - Marco Martin On Nov. 2, 2014, 10:09

Re: QScreen vs. KScreen in plasmashell

2014-11-03 Thread Sebastian Kügler
On Friday, October 24, 2014 10:20:04 Daniel Vratil wrote: > On Friday 24 of October 2014 10:15:17 Pier Luigi Fiorini wrote: > > 2014-10-24 9:58 GMT+02:00 Daniel Vratil : > > > the current state of multi-monitor support in Plasma 5 is rather bad as > > > both Plasma 5 and KWin keep crashing every t

standalone build of konqueror is broken

2014-11-03 Thread Treeve Jelbert
in order to test standalone builds, I created a staging directory whit symlinks to all the components of kde-baseapps. The probelm seems to be that libkonq installs /opt/qt5/share/dbus-1/interfaces/org.kde.FavIcon.xml but cmake does not know how to include it The same problem occurs with ke

Re: Review Request 120943: Move duplicated code from NotificationDelegate and NotificationPopup into a new NotificationItem

2014-11-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120943/#review69715 --- Heh, looking at the code again on my way in the office I saw a

Re: Review Request 120946: Add thumbnailAvailable property to WindowThumbnail

2014-11-03 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120946/ --- (Updated Nov. 3, 2014, 9:13 a.m.) Status -- This change has been mar

Jenkins build is back to normal : plasma-desktop_master_qt5 #779

2014-11-03 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120954: drop libkonq_export for internal libkonq copy

2014-11-03 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/ --- (Updated Nov. 3, 2014, 9:09 a.m.) Status -- This change has been mar

Re: Review Request 120954: drop libkonq_export for internal libkonq copy

2014-11-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/#review69712 --- Ship it! Ship It! - Martin Gräßlin On Nov. 3, 2014, 9:58 a

Re: Review Request 120577: Remove shutdown option from lockscreen's look and feel

2014-11-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120577/ --- (Updated Nov. 3, 2014, 8:59 a.m.) Status -- This change has been mar

Re: Review Request 120954: drop libkonq_export for internal libkonq copy

2014-11-03 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/ --- (Updated Nov. 3, 2014, 8:58 a.m.) Review request for Plasma. Repository

Review Request 120954: drop libkonq_export for internal libkonq copy

2014-11-03 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120954/ --- Review request for Plasma. Repository: plasma-desktop Description -

Build failed in Jenkins: plasma-desktop_master_qt5 #778

2014-11-03 Thread KDE CI System
See Changes: [mgraesslin] [kcms/lnf] Make a list variable const -- [...truncated 1126 lines...] [ 31%] Built target trashplugin [ 31%] Building CXX object solid-actions-kcm/CMakeFiles/kcm_so

Re: Review Request 120949: Add imageprovider to fifteenpuzzle.

2014-11-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120949/#review69707 --- What's the purpose of this approach? - Sebastian Kügler On

Re: Review Request 120913: [kcms/lnf] Make a list variable const

2014-11-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/ --- (Updated Nov. 3, 2014, 8:45 a.m.) Status -- This change has been mar

Re: Review Request 120946: Add thumbnailAvailable property to WindowThumbnail

2014-11-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120946/#review69705 --- Ship it! Ship It! - Martin Gräßlin On Nov. 2, 2014, 8:04 p

Re: Review Request 120913: [kcms/lnf] Make a list variable const

2014-11-03 Thread Martin Gräßlin
> On Nov. 1, 2014, 5:58 p.m., Mark Gaiser wrote: > > Just out of curiosity. Do you have any benchmark numbers? I bet it's > > faster, but by how much in terms of percentage? no I don't have a benchmark. But the worst performance bug we ever had in KWin was accessing a Qt container class using

Re: Review Request 120936: [KInfoCenter] Set the correct version

2014-11-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120936/#review69703 --- Modules/infosummary/CMakeLists.txt

missing libkonq_export build broken

2014-11-03 Thread Harald Sitter
as of b29f85d plasma-desktop builds in minimal build environments appear to be broken... In file included from ../../../containments/folder/plugin/foldermodel.cpp:43:0: ../../../containments/folder/plugin/internallibkonq/konq_popupmenu.h:35:28: fatal error: libkonq_export.h: No such file or direct