Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/ --- (Updated Nov. 24, 2014, 9:09 a.m.) Review request for KDE Frameworks, kwi

Re: Review Request 120914: [kcmkwin/tabbox] Find all layouts in lnf package

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120914/ --- (Updated Nov. 24, 2014, 9:40 a.m.) Status -- This change has been ma

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-24 Thread Marco Martin
> On Nov. 17, 2014, 10:02 p.m., Kai Uwe Broulik wrote: > > wallpapers/image/imagepackage/contents/ui/main.qml, line 157 > > > > > > Don't unexpectedly colorize your Dashboard. After playing around with > > the c

Minutes Monday Plasma Hangout

2014-11-24 Thread Sebastian Kügler
Minutes Plasma Hangout, 24-11-2014 Present: Kai Uwe, David, Marco, Martin G, Martin K, Sebas, Vishesh (Much of the team has been to a business meeting, hence reduced bandwidth last week.) Kai Uwe: - Wallpaper improvements https://git.reviewboard.kde.org/r/121162/ - IconItem patch https://git.re

Build failed in Jenkins: plasma-workspace_master_qt5 #1094

2014-11-24 Thread KDE CI System
See Changes: [me] ServicesRunner: Give a higher relevance when the exec matches the term [me] Recent Documents Runner: Run the actual URL when running -- Started by remote host 2a01:4f8:1

Review Request 121228: Fix minimum height in notifications

2014-11-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121228/ --- Review request for Plasma, Martin Klapetek and Vishesh Handa. Bugs: 34121

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2014-11-24 Thread Aleix Pol
https://bugs.kde.org/show_bug.cgi?id=340063 Aleix Pol changed: What|Removed |Added Flags||VisualDesign+ -- You are receiving this mail becau

Review Request 121229: Highlight first entry when searching

2014-11-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121229/ --- Review request for Plasma and Sebastian Kügler. Bugs: 340067 https://

Re: Review Request 121229: Highlight first entry when searching

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121229/#review70859 --- Definitely, does pressing up & down work as expected too? In

Re: Review Request 121229: Highlight first entry when searching

2014-11-24 Thread Kai Uwe Broulik
> On Nov. 24, 2014, 5:36 nachm., Aleix Pol Gonzalez wrote: > > Definitely, does pressing up & down work as expected too? > > > > In fact, here it looks like I already get a highlight delegate... Yes, pressing up and down works as expected, only if you type again (which resets the list anyway)

Re: Review Request 121229: Highlight first entry when searching

2014-11-24 Thread Aleix Pol Gonzalez
> On Nov. 24, 2014, 5:36 p.m., Aleix Pol Gonzalez wrote: > > Definitely, does pressing up & down work as expected too? > > > > In fact, here it looks like I already get a highlight delegate... > > Kai Uwe Broulik wrote: > Yes, pressing up and down works as expected, only if you type again

Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId

2014-11-24 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/#review70866 --- Questions: a) I can't find createNewStartupIdForTimestamp in

Re: OSD and Notification Window Type

2014-11-24 Thread Martin Gräßlin
On Monday 24 November 2014 19:55:21 Kai Uwe Broulik wrote: > Hi everyone, > > owing to Eike's request I have investigated how to improve fullscreen > handling in notifications, queuing them while in fullscreen. While doing so > I found a few usability quirks: > > First of all, the OSD uses the No

OSD and Notification Window Type

2014-11-24 Thread Kai Uwe Broulik
Hi everyone, owing to Eike's request I have investigated how to improve fullscreen handling in notifications, queuing them while in fullscreen. While doing so I found a few usability quirks: First of all, the OSD uses the Notification WindowType, which - I think there has been a bit of a misco

PageStack and StackView

2014-11-24 Thread Kai Uwe Broulik
Hi again, I was looking into porting PlasmaComponents.PageStack to QtQuick.Controls.StackView. PageStack provides quite some legacy features Marco told me weren't that important but it also has a lot of similar-but- different API with JavaScript functions taking a couple of parameters whereas Q

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/#review70868 --- +1, I like the approach. +do you think it still requires work?

Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121234/ --- Review request for Plasma, Eike Hein and Vishesh Handa. Repository: plasm

Re: QtQuick Controls Calendar

2014-11-24 Thread Aleix Pol
On Sat, Nov 8, 2014 at 6:20 PM, Kai Uwe Broulik wrote: > Hi all, > > I was looking into migrating the Plasma Calendar to QtQuick Controls > Calendar. > > However, we went through so much work making this thing efficient and fast > using Canvas but the QtQuick Controls Calendar again uses one item

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-24 Thread Marco Martin
> On Nov. 17, 2014, 9:37 p.m., Kai Uwe Broulik wrote: > > wallpapers/image/imagepackage/contents/ui/main.qml, line 167 > > > > > > What is the clipping for? I thought clipping was evil :) Or does that > > actual

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/#review70869 --- +1, I like the approach. +do you think it still requires work?

Re: OSD and Notification Window Type

2014-11-24 Thread Marco Martin
On Monday 24 November 2014, Martin Gräßlin wrote: > > First of all, the OSD uses the Notification WindowType, which - I think > > there has been a bit of a miscommunication - is meant for notifications. > > The OSD stays on top of everything, which is fine, but not the active > > fullscreen window.

Re: QtQuick Controls Calendar

2014-11-24 Thread Marco Martin
On Saturday 08 November 2014, Kai Uwe Broulik wrote: > Hi all, > > I was looking into migrating the Plasma Calendar to QtQuick Controls > Calendar. > > However, we went through so much work making this thing efficient and fast > using Canvas but the QtQuick Controls Calendar again uses one item p

Re: PageStack and StackView

2014-11-24 Thread Marco Martin
On Monday 24 November 2014, Kai Uwe Broulik wrote: > Hi again, > > I was looking into porting PlasmaComponents.PageStack to > QtQuick.Controls.StackView. PageStack provides quite some legacy features > Marco told me weren't that important but it also has a lot of similar-but- > different API with

Re: PageStack and StackView

2014-11-24 Thread Marco Martin
On Monday 24 November 2014, Marco Martin wrote: > > push(page, properties, immediate) → push(item) as a shortcut, or > > push({item: someItem, immediate: true, properties: {foo: "bar", baz: > > "bla"} }) which cannot be (easily, if at all?) overloaded to provide > > legacy support > > Uuh, from wh

Re: PageStack and StackView

2014-11-24 Thread Kai Uwe Broulik
Am Montag, 24. November 2014, 20:47:26 schrieb Marco Martin: > pageStack.push(someItem, {fgcolor: "red", bgcolor: "blue"}, true) would just > wrap internally > stackView.push({item: someItem, immediate: true, properties: {fgcolor: > "red", bgcolor: "blue"}}) So it seems when I define a function

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/ --- (Updated Nov. 24, 2014, 9:01 nachm.) Review request for Plasma. Changes

Review Request 121236: Minimize overdraw in Desktop view

2014-11-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121236/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/ --- (Updated Nov. 24, 2014, 9:19 nachm.) Review request for Plasma. Changes

Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/#review70879 --- Shouldn't this go in a document view rather than a tool view?

Re: Review Request 121207: Port the notes editor to KDevPlatform

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121207/#review70880 --- Again, why not in the document view? Note that you can change

Re: Review Request 121206: Port savesystem to KDevPlatform and qml

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/#review70881 --- plasmate/plugins/savesystemview/git.h

Different calendars in Plasma 5

2014-11-24 Thread Aleix Pol
Hi, I went through some bug reports earlier today and found this one, that looks quite important in principle: https://bugs.kde.org/show_bug.cgi?id=340558 Apparently it's not possible to change Plasma's calendar type anymore. Can somebody who has worked on the plasmoid shed some light? Martin, Seb

Re: Review Request 121162: Some ideas for the image wallpaper

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121162/#review70884 --- Ship it! wallpapers/image/imagepackage/contents/ui/main.qml

Re: Review Request 121236: Minimize overdraw in Desktop view

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121236/#review70885 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Nov. 2

Review Request 121239: Port ktouchpadenabler

2014-11-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121239/ --- Review request for Plasma, Aleix Pol Gonzalez and David Edmundson. Reposi

Re: Review Request 121239: Port ktouchpadenabler

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121239/#review70888 --- Ship it! CMakeLists.txt

Re: Review Request 121239: Port ktouchpadenabler

2014-11-24 Thread Albert Astals Cid
> On nov. 25, 2014, 12:18 a.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 135 > > > > > > Maybe if(KF5WindowSystem_VERSION VERSION_GREATER 5.5)? As said, there's no need, it will still compile, and once

Re: Review Request 121239: Port ktouchpadenabler

2014-11-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121239/ --- (Updated Nov. 25, 2014, 12:30 a.m.) Status -- This change has been m

Re: Review Request 121234: [Kickoff] Use latest X11 user time for creating StartupInfoId

2014-11-24 Thread Martin Gräßlin
> On Nov. 24, 2014, 8:13 p.m., Eike Hein wrote: > > Questions: > > > > a) I can't find createNewStartupIdForTimestamp in the apidox, I assume this > > is new and means this is master-only since it needs fresh KWS? > > > > b) If it's new API assume you know it doesn't break on non-x11? > > > >

Re: Re: OSD and Notification Window Type

2014-11-24 Thread Martin Gräßlin
On Monday 24 November 2014 20:25:09 Marco Martin wrote: > On Monday 24 November 2014, Martin Gräßlin wrote: > > > First of all, the OSD uses the Notification WindowType, which - I think > > > there has been a bit of a miscommunication - is meant for notifications. > > > The OSD stays on top of ever