Re: Review Request 121761: Fix build on FreeBSD

2015-01-02 Thread Martin Gräßlin
On Dec. 31, 2014, 3:19 p.m., Pino Toscano wrote: ksmserver/screenlocker/greeter/autotests/killtest.cpp, lines 79-82 https://git.reviewboard.kde.org/r/121761/diff/1/?file=337442#file337442line79 This (and all the other cases of this) should rather be: ``` #ifdef SIGUNUSED

Re: Review Request 121763: Fix build on FreeBSD

2015-01-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/#review72900 --- Ship it! Modules/info/CMakeLists.txt

Black Screen on Login

2015-01-02 Thread David Edmundson
Apparently there's a bug, supposedly with kscreen (unconfirmed), that means as login as a new user you will be greeted with a black screen with plasmashell not drawing any windows. I've heard multiple people comment on various channels, but it seems no-one has had the sense to file a proper bug

Review Request 121301: Expose OSD window type

2015-01-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121301/ --- Review request for Plasma. Repository: plasma-framework Description

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2015-01-02 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=340063 --- Comment #6 from Martin Gräßlin mgraess...@kde.org --- (In reply to Kai Uwe Broulik from comment #2) Martin, could (should) we abuse the KScreen effect for this? certainly -- You are receiving this mail because: You are the assignee for the bug.

Jenkins build is back to normal : plasma-workspace_stable_qt5 #20

2015-01-02 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_stable_qt5/20/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: testing a plasma applet with plasmoid viewer despite PackageUrlInterceptor

2015-01-02 Thread Philipp A.
*bump* nobody got an idea? 2014-12-29 13:45 GMT+01:00 Philipp A. flying-sh...@web.de: 2014-12-29 10:23 GMT+01:00 Marco Martin notm...@gmail.com: does it load when installed? yes. i think it’s the way that plasmoidviewer loads it that breaks, see my other mail, where i changed the

Re: Review Request 121790: Port plasmasehll away from kscreen

2015-01-02 Thread Marco Martin
On Jan. 2, 2015, 2:25 p.m., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Lukáš Tinkl wrote: Ugh, that's nasty, I wasn't aware of this bug... Aleix Pol Gonzalez wrote: Yes,

Re: Black Screen on Login

2015-01-02 Thread Lukáš Tinkl
Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new

Re: Black Screen on Login

2015-01-02 Thread Aleix Pol
On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With

[Breeze] [Bug 342420] New: Provide default wallpaper in png format

2015-01-02 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=342420 Bug ID: 342420 Summary: Provide default wallpaper in png format Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity:

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread Bhushan Shah
On Fri, Jan 2, 2015 at 10:13 PM, David Edmundson da...@davidedmundson.co.uk wrote: Won't these messages will get eaten by our noMessageOutput message handler on login anyway? To workaround edit plasmashell.desktop to remove --shut-up Exec=plasmashell --shut-up to Exec=plasmashell -- Bhushan

[Breeze] [Bug 342420] Provide default wallpaper in png format

2015-01-02 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=342420 David Edmundson k...@davidedmundson.co.uk changed: What|Removed |Added CC|

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread David Edmundson
Won't these messages will get eaten by our noMessageOutput message handler on login anyway? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread David Edmundson
If that still works fine, why was this argument added? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119814: [ksld] ScreenLocker inhibits sleep on logind

2015-01-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119814/#review72925 --- @Kai Uwe: you added a signal somewhere for non-logind

Re: Review Request 121772: Fade panels when dashboard is shown

2015-01-02 Thread David Edmundson
On Dec. 31, 2014, 11:29 a.m., Thomas Pfeiffer wrote: The more we (the VDG) think and learn about this, the more we realize that we haven't really thought it through yet. It looks like it's back to the drawing board here, as we don't want to make a change that makes as many users

Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions

2015-01-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121710/ --- (Updated Jan. 2, 2015, 11:20 a.m.) Status -- This change has been

Re: Review Request 121763: Fix build on FreeBSD

2015-01-02 Thread Raphael Kubo da Costa
On Jan. 2, 2015, 10:24 a.m., Martin Gräßlin wrote: Modules/info/CMakeLists.txt, lines 28-30 https://git.reviewboard.kde.org/r/121763/diff/1/?file=337463#file337463line28 just out of interest: is devinfo a FreeBSD only library or is it of interest for more non-Linux variants?

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2015-01-02 Thread Andrei Amuraritei
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Jan. 2, 2015, 11:30 a.m.) Status -- This change has been

Re: Widget Explorer / Activity Manager Dock type

2015-01-02 Thread Martin Gräßlin
On Friday 02 January 2015 01:56:47 Kai Uwe Broulik wrote: Hi everyone, while investigating why Widget Explorer and Activity Manager wouldn't accept any input often (the filterbox visually being focussed with blinking cursor but no way to enter anything) I found that it's using the NET::Dock

Re: Review Request 121476: Port showdesktop applet to Plasma Next

2015-01-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121476/#review72912 --- The adjustments look good to me. If we want it for the next

Re: Review Request 121530: Remove lock screen on suspend

2015-01-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121530/#review72924 --- ping? - Martin Gräßlin On Dec. 15, 2014, 11:45 a.m.,

Re: Review Request 121301: Expose OSD window type

2015-01-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121301/#review72926 --- Ship it! Ship It! - Martin Gräßlin On Jan. 2, 2015, 12:10

Re: Review Request 121301: Expose OSD window type

2015-01-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121301/ --- (Updated Jan. 2, 2015, 11:18 a.m.) Status -- This change has been

Re: Review Request 121790: Port plasmasehll away from kscreen

2015-01-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72938 --- Definitely where we want to go long term, and if it fixes our

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2015-01-02 Thread David Edmundson
On Dec. 11, 2014, 10:24 a.m., Marco Martin wrote: what's the status of this? Andrei Amuraritei wrote: Hi there, this compiles and works, as best I could test it. Still needs work to port away from kde4support libs. Sadly my time with it has been null, too busy with work and

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

2015-01-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121429/ --- (Updated Jan. 2, 2015, 12:01 p.m.) Status -- This change has been

Re: Review Request 121790: Port plasmasehll away from kscreen

2015-01-02 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72937 --- shell/shellcorona.cpp

Review Request 121790: Port plasmasehll away from kscreen

2015-01-02 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/ --- Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Daniel

Re: Review Request 121774: Let month menu navigate in current year

2015-01-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121774/#review72936 --- Ship it! Ship It! - Martin Klapetek On Dec. 31, 2014,

Re: Review Request 121774: Let month menu navigate in current year

2015-01-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121774/ --- (Updated Jan. 2, 2015, 1:11 p.m.) Status -- This change has been

Jenkins build became unstable: plasma-workspace_master_qt5 #1172

2015-01-02 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1172/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to stable : plasma-workspace_master_qt5 #1174

2015-01-02 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1174/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: plasma-workspace_master_qt5 #1173

2015-01-02 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Black Screen on Login

2015-01-02 Thread David Edmundson
On Fri, Jan 2, 2015 at 6:14 PM, Lukáš Tinkl lu...@kde.org wrote: Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23

Re: Black Screen on Login

2015-01-02 Thread Aleix Pol
On Fri, Jan 2, 2015 at 6:14 PM, Lukáš Tinkl lu...@kde.org wrote: Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM,

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread Aleix Pol
On Fri, Jan 2, 2015 at 5:43 PM, David Edmundson da...@davidedmundson.co.uk wrote: Won't these messages will get eaten by our noMessageOutput message handler on login anyway? ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Black Screen on Login

2015-01-02 Thread Martin Klapetek
On Fri, Jan 2, 2015 at 6:14 PM, Lukáš Tinkl lu...@kde.org wrote: Can you update to the most recent powerdevil and try to reproduce the black screen problem again? My theory is that there lies the problem; plasmashell is starting up and requesting the config while kded is (also) waiting for

[Breeze] [Bug 342420] Provide default wallpaper in png format

2015-01-02 Thread Andrew Lake
https://bugs.kde.org/show_bug.cgi?id=342420 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED

[Breeze] [Bug 342420] Provide default wallpaper in png format

2015-01-02 Thread Andrew Lake
https://bugs.kde.org/show_bug.cgi?id=342420 Andrew Lake jamboar...@gmail.com changed: What|Removed |Added CC||jamboar...@gmail.com ---

[Breeze] [Bug 342420] Provide default wallpaper in png format

2015-01-02 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=342420 --- Comment #2 from David Edmundson k...@davidedmundson.co.uk --- I don't have the original assets. I could convert the JPEGs but that'd be a bit silly. Marco made the commit: updated version of the default wallpaper from the KDE VDG I don't know if

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread David Edmundson
​The handler is: void noMessageOutput(QtMsgType type, const char *msg) { Q_UNUSED(type); Q_UNUSED(msg); } that's going to block warnings too. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: [plasma-workspace] shell: Check for errors when the GetConfigOperation returns

2015-01-02 Thread David Edmundson
​Oh, it was added because there was that weird Qt bug that used to flood the logs (pre 5.2) Any objections to me removing it? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121772: Fade panels when dashboard is shown

2015-01-02 Thread Kai Uwe Broulik
On Dez. 31, 2014, 11:29 vorm., Thomas Pfeiffer wrote: The more we (the VDG) think and learn about this, the more we realize that we haven't really thought it through yet. It looks like it's back to the drawing board here, as we don't want to make a change that makes as many users

Re: Review Request 121790: Port plasmasehll away from kscreen

2015-01-02 Thread Aleix Pol Gonzalez
On Jan. 2, 2015, 2:25 p.m., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Lukáš Tinkl wrote: Ugh, that's nasty, I wasn't aware of this bug... Yes, well, I don't know. People keep

Change in plasma-framework[master]: Add HiddenAction in Plasma::Types::ActionType

2015-01-02 Thread Bhushan Shah (Code Review)
Bhushan Shah has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/301 Change subject: Add HiddenAction in Plasma::Types::ActionType .. Add HiddenAction in Plasma::Types::ActionType This is to hide

Re: Review Request 121790: Port plasmasehll away from kscreen

2015-01-02 Thread Lukáš Tinkl
On Led. 2, 2015, 3:25 odp., Aleix Pol Gonzalez wrote: How do you figure out what's the primary screen with QScreen? https://bugreports.qt-project.org/browse/QTBUG-38404 -2 Ugh, that's nasty, I wasn't aware of this bug... - Lukáš

Re: Review Request 121790: Port plasmasehll away from kscreen

2015-01-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121790/#review72949 --- How do you figure out what's the primary screen with QScreen?

Re: Black Screen on Login

2015-01-02 Thread David Edmundson
On Fri, Jan 2, 2015 at 4:30 PM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen

Re: Black Screen on Login

2015-01-02 Thread Aleix Pol
On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for

Re: Black Screen on Login

2015-01-02 Thread Aleix Pol
On Fri, Jan 2, 2015 at 4:23 PM, David Edmundson da...@davidedmundson.co.uk wrote: I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for

Re: Black Screen on Login

2015-01-02 Thread David Edmundson
​I have a new theory as to what might be wrong. With KScreen's backend being out of process it could be signalling that there's a new screen before plasmashell has processed the X events and be trying to look for the relevant QScreen object before plasmashell has made it. Could someone put in

Re: Review Request 120276: Initial port to frameworks for the comic dataengine.

2015-01-02 Thread Andrei Amuraritei
On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote: what's the status of this? Andrei Amuraritei wrote: Hi there, this compiles and works, as best I could test it. Still needs work to port away from kde4support libs. Sadly my time with it has been null, too busy with work and

Re: Black Screen on Login

2015-01-02 Thread Bhushan Shah
Okay people, I reported this bug on bugzilla https://bugs.kde.org/show_bug.cgi?id=342431 On Sat, Jan 3, 2015 at 3:47 AM, Aleix Pol aleix...@kde.org wrote: On Fri, Jan 2, 2015 at 6:14 PM, Lukáš Tinkl lu...@kde.org wrote: Dne 2.1.2015 v 16:47 Aleix Pol napsal(a): On Fri, Jan 2, 2015 at 4:41

Re: Review Request 121360: Rework Plasma's notification positioning code

2015-01-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121360/ --- (Updated Jan. 3, 2015, 1:26 a.m.) Review request for Plasma and Kai Uwe