Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121856/#review76265 --- src/qmlcontrols/kwindowsystemplugin/kwindowsystemproxy.h

Re: Review Request 122629: Simplify ToolBox and implement keyboard navigation

2015-02-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122629/ --- (Updated Feb. 18, 2015, 8:21 p.m.) Status -- This change has been ma

Re: Review Request 121856: KWindowSystem import for KDeclarative

2015-02-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121856/#review76258 --- Ping - Kai Uwe Broulik On Jan. 5, 2015, 10:49 vorm., Kai Uw

Re: Review Request 122629: Simplify ToolBox and implement keyboard navigation

2015-02-18 Thread Kai Uwe Broulik
> On Feb. 18, 2015, 4 nachm., David Edmundson wrote: > > toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml, line 42 > > > > > > I don't understand this comment? > > > > if you don't want it to close ev

Re: Review Request 122629: Simplify ToolBox and implement keyboard navigation

2015-02-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122629/#review76243 --- toolboxes/desktoptoolbox/contents/ui/ToolBoxItem.qml

Review Request 122629: Simplify ToolBox and implement keyboard navigation

2015-02-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122629/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

2015-02-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- (Updated Feb. 18, 2015, 2:56 p.m.) Status -- This change has been ma

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

2015-02-18 Thread Martin Klapetek
> On Feb. 18, 2015, 12:33 p.m., Eike Hein wrote: > > Ship It! > > Martin Klapetek wrote: > Can i18n strings be removed in stable? > > Lukáš Tinkl wrote: > Sure, removing is fine, it's like B(I)C rules ;) Ah nice, I thought so but just wanted to make double sure, thanks :) - Martin

Re: Review Request 122617: Require Qt 5.4

2015-02-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122617/#review76237 --- Ship it! Ship It! - David Edmundson On Feb. 18, 2015, 9:06

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

2015-02-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/ --- (Updated Feb. 18, 2015, 3:37 p.m.) Review request for Plasma. Changes -

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

2015-02-18 Thread Lukáš Tinkl
> On Úno. 18, 2015, 12:33 odp., Eike Hein wrote: > > Ship It! > > Martin Klapetek wrote: > Can i18n strings be removed in stable? Sure, removing is fine, it's like B(I)C rules ;) - Lukáš --- This is an automatically generated e-mai

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

2015-02-18 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/#review76235 --- definitely +1 from me - Lukáš Tinkl On Úno. 18, 2015, 1:52

Re: Review Request 122624: Make non-interactive tooltips outputOnly

2015-02-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122624/ --- (Updated Feb. 18, 2015, 1:37 p.m.) Status -- This change has been ma

Re: Review Request 122623: Ignore single actions on popups

2015-02-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122623/ --- (Updated Feb. 18, 2015, 1:37 p.m.) Status -- This change has been ma

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

2015-02-18 Thread Martin Gräßlin
> On Feb. 18, 2015, 2:20 p.m., Vishesh Handa wrote: > > dataengines/geolocation/location_ip.cpp, line 45 > > > > > > Any idea why we have this magic number? I can only guess: the accuracy returned by mozilla's se

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

2015-02-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/#review76231 --- dataengines/geolocation/location_ip.cpp

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

2015-02-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/#review76229 --- +1 for the approach - Martin Klapetek On Feb. 18, 2015, 1:5

Re: Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

2015-02-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/#review76228 --- dataengines/geolocation/location_ip.cpp

Review Request 122628: [dataengine/geolocation] Switch to datalocation service provided by Mozilla

2015-02-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122628/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 122627: Fix line breaks in Digital Clock tooltip

2015-02-18 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122627/ --- (Updated Feb. 18, 2015, 1:51 p.m.) Status -- This change has been di

Re: Review Request 122627: Fix line breaks in Digital Clock tooltip

2015-02-18 Thread Daniel Vrátil
> On Feb. 18, 2015, 1:42 p.m., Martin Klapetek wrote: > > Are you sure you're running the latest 5.2 branch? This was fixed globally > > in the tooltip I think (by ltinkl) Slightly outdated master. Works after updating. Lukas was faster than me then and has a better fix ;-) - Daniel --

Re: Review Request 122627: Fix line breaks in Digital Clock tooltip

2015-02-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122627/#review76226 --- Are you sure you're running the latest 5.2 branch? This was fi

Review Request 122627: Fix line breaks in Digital Clock tooltip

2015-02-18 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122627/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 122623: Ignore single actions on popups

2015-02-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122623/#review76225 --- Ship it! src/scriptengines/qml/plasmoid/appletinterface.cpp

Re: Review Request 122624: Make non-interactive tooltips outputOnly

2015-02-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122624/#review76224 --- Ship it! Ship It! - Marco Martin On Feb. 18, 2015, 12:24 p

Review Request 122624: Make non-interactive tooltips outputOnly

2015-02-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122624/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

2015-02-18 Thread Martin Klapetek
> On Feb. 18, 2015, 12:33 p.m., Eike Hein wrote: > > Ship It! Can i18n strings be removed in stable? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/#review76221

Review Request 122623: Ignore single actions on popups

2015-02-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122623/ --- Review request for Plasma. Bugs: 344309 http://bugs.kde.org/show_bug.

Re: Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

2015-02-18 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/#review76221 --- Ship it! Ship It! - Eike Hein On Feb. 18, 2015, 11:25 a.m.

Review Request 122622: Don't show "Unknown" as author in wallpaper tooltip

2015-02-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122622/ --- Review request for Plasma. Repository: plasma-workspace Description ---

[Powerdevil] [Bug 334411] Screen Energy Saving timeout on dual-monitor system starting one after another with timeout delay

2015-02-18 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=334411 Martin Gräßlin changed: What|Removed |Added Product|systemsettings |Powerdevil Component|kcm_screensaver

Review Request 122619: [KPluginMetaData] Add support for Hidden key

2015-02-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122619/ --- Review request for KDE Frameworks, Plasma, Alex Richardson, David Faure, an

Review Request 122617: Require Qt 5.4

2015-02-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122617/ --- Review request for kwin and Plasma. Repository: kwin Description --

Jenkins build is back to stable : plasma-workspace_master_qt5 #1339

2015-02-18 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122589: [dataengine/mpris2] Drop workaround for VLC

2015-02-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122589/ --- (Updated Feb. 18, 2015, 8:14 a.m.) Status -- This change has been ma

Re: Review Request 122588: [dataengines/mpris2] Use a dedicated component for the media control shortcuts

2015-02-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122588/ --- (Updated Feb. 18, 2015, 8:14 a.m.) Status -- This change has been ma