Re: Review Request 122861: Micro-optimize LayoutManager

2015-03-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122861/ --- (Updated March 10, 2015, 6:05 p.m.) Status -- This change has been

Re: Review Request 122894: Add config option for Kickoff icon

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122894/#review77271 --- Ship it!

Re: Review Request 122888: Port the look and feel KCM to the qml only version

2015-03-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122888/#review77300 --- Ship it! (when other stuff is merged obviously) - David

Re: plasma wallpapers

2015-03-12 Thread Marco Martin
On Monday 09 March 2015, kainz.a wrote: Hi plasma developers, I'm part of the VDG and do some artwork for the Breeze icon set. ... My question was: - Can I start a Wallpaper contest for the plasma team to have additional standard wallpapers in plasma 5.3. Hi, it would be cool, yes :) --

Re: Plasma Bugs

2015-03-12 Thread Jonathan Riddell
Thanks for that David. Here's the list of products in bugzilla I manually add new versions to when there is a new release. Please look and check all the products you expect to be there are there. systemsettings Powerdevil plasma-nm Oxygen frameworks-modemmanager-qt ksysguard KScreen kwin

Re: Review Request 122842: Allow selecting notifications position on screen

2015-03-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/ --- (Updated March 11, 2015, 7:09 p.m.) Review request for Plasma. Changes

Review Request 122909: Fix segfault with missing screens

2015-03-12 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 122916: Fix displaying label1 in job notifications

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122916/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 122909: Fix segfault with missing screens

2015-03-12 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/#review77349 --- Ship it! Ship It! - Lukáš Tinkl On Bře. 11, 2015, 8:03

Review Request 122917: Fix thumbnail previews for directories

2015-03-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122917/ --- Review request for Plasma. Repository: kio-extras Description ---

Re: plasma wallpapers

2015-03-12 Thread Martin Klapetek
On Thu, Mar 12, 2015 at 1:31 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Mar 12, 2015 at 01:20:35PM +0100, Martin Klapetek wrote: However do you know how it is with property licenses when used as backgrounds? It varies by country, sensible countries make sure that photos of

Re: Review Request 122917: Fix thumbnail previews for directories

2015-03-12 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122917/#review77357 --- Ship it! Ship It! - Bhushan Shah On March 12, 2015, 6:13

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77358 --- Good catch? src/plasma/theme.cpp

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread David Edmundson
On March 12, 2015, 12:50 p.m., David Edmundson wrote: Good catch? I have no idea why I put a question mark there. That wasn't intended. - David --- This is an automatically generated e-mail. To reply, visit:

Re: plasma wallpapers

2015-03-12 Thread Martin Klapetek
On Thu, Mar 12, 2015 at 2:05 PM, Jonathan Riddell j...@jriddell.org wrote: You're mixing several unrelated laws here. Personality rights in the US applies to people who make a living from their celebrity. Privacy rights in the EU applies to helping protect the little children. There's some

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77371 --- Ship it! My apologies, please leave it in AutoConnection.

Re: Review Request 122886: QML-only KCM base

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 2:55 p.m.) Review request for KDE Frameworks

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 2:18 p.m.) Status -- This change has been

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Marco Martin
On March 12, 2015, 12:50 p.m., David Edmundson wrote: src/plasma/theme.cpp, line 424 https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line424 Would it work to: QMetaObject::invoke(d-rectSaveTimer, SLOT(start())); that will mean we

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread David Edmundson
On March 12, 2015, 1:28 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/2/?file=354540#file354540line421 You'll need to pass the ConnectionType if you want this to fix the issue. Qt::BlockingQueuedConnection would be

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Marco Martin
On March 12, 2015, 1:12 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line421 If that's the case, then we will need locking, no? We don't want 2 different threads modifying the class

Re: plasma wallpapers

2015-03-12 Thread Marco Martin
On Thursday 12 March 2015 14:29:11 Martin Klapetek wrote: All I'm saying is that if we choose to distribute a picture of a person without any written consent from that person and if that person changes his/her mind at any time after we've released it, it could go bad as suddenly that person's

Re: Review Request 122917: Fix thumbnail previews for directories

2015-03-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122917/ --- (Updated March 12, 2015, 1:45 p.m.) Status -- This change has been

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Aleix Pol Gonzalez
On March 12, 2015, 2:28 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/2/?file=354540#file354540line421 You'll need to pass the ConnectionType if you want this to fix the issue. Qt::BlockingQueuedConnection would be

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Marco Martin
On March 12, 2015, 1:12 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line421 If that's the case, then we will need locking, no? We don't want 2 different threads modifying the class

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 1:25 p.m.) Review request for Plasma.

Re: Review Request 122909: Fix segfault with missing screens

2015-03-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/#review77366 --- shell/panelshadows.cpp

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Aleix Pol Gonzalez
On March 12, 2015, 2:12 p.m., Aleix Pol Gonzalez wrote: src/plasma/theme.cpp, line 421 https://git.reviewboard.kde.org/r/122915/diff/1/?file=354535#file354535line421 If that's the case, then we will need locking, no? We don't want 2 different threads modifying the class

Re: Review Request 122909: Fix segfault with missing screens

2015-03-12 Thread Jan Kundrát
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/ --- (Updated March 12, 2015, 1:24 p.m.) Status -- This change has been

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77365 --- src/plasma/theme.cpp

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/ --- (Updated March 12, 2015, 1:38 p.m.) Review request for Plasma.

Re: Review Request 122909: Fix segfault with missing screens

2015-03-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122909/#review77369 --- For the record I reverted with

Re: Review Request 122909: Fix segfault with missing screens

2015-03-12 Thread Richard Moore
On March 12, 2015, 1:40 p.m., Martin Gräßlin wrote: For the record I reverted with http://commits.kde.org/plasma-workspace/c4c7e6d53f66fbdd6d58b40e5f3b443c6cf2e197: The reason for revertion is that it leaks pixmaps. QX11Info::display should not return a nullptr if there is

Re: Review Request 122915: check we are started from the correct thread before starting timer

2015-03-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122915/#review77360 --- src/plasma/theme.cpp

Re: Project: libmuon package install for 3rd party applications

2015-03-12 Thread Aleix Pol
On Thu, Mar 12, 2015 at 8:34 PM, Jonathan Riddell j...@jriddell.org wrote: Aleix et al: what do you think of this? https://community.kde.org/GSoC/2015/Ideas#Project:_libmuon_package_install_for_3rd_party_applications adapting muon so its library can be used by external apps to install

Review Request 122919: Remove unused dependencies.

2015-03-12 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122919/ --- Review request for Plasma. Repository: sddm-kcm Description --- I

Review Request 122920: Show pause/stop buttons in jobs notification only for suspendable/killable jobs

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122920/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: plasma wallpapers

2015-03-12 Thread kainz.a
thanks for the information. thats the reason that the plasma team should find the winner and not the community via rating. cheers Andreas Am 12.03.2015 13:46 schrieb Martin Klapetek martin.klape...@gmail.com: On Thu, Mar 12, 2015 at 1:31 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu,

Review Request 122921: Handle job error when showing job finished notification

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 122921: Handle job error when showing job finished notification

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/ --- (Updated March 12, 2015, 5:46 p.m.) Status -- This change has been

Re: Review Request 122921: Handle job error when showing job finished notification

2015-03-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122921/#review77390 --- Ship it! Thanks for doing this - David Edmundson On March

Re: Review Request 122886: QML-only KCM base

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/ --- (Updated March 12, 2015, 7 p.m.) Review request for KDE Frameworks and

Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 7:01 p.m.) Review request for KDE Frameworks

Re: Review Request 122916: Fix displaying label1 in job notifications

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122916/ --- (Updated March 12, 2015, 8:40 p.m.) Status -- This change has been

Re: Review Request 122920: Show pause/stop buttons in jobs notification only for suspendable/killable jobs

2015-03-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122920/ --- (Updated March 12, 2015, 8:40 p.m.) Status -- This change has been

Re: Review Request 122887: Load and wrap the QML-only version of kcms if possible

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122887/ --- (Updated March 12, 2015, 2:58 p.m.) Review request for KDE Frameworks

Re: Review Request 122886: QML-only KCM base

2015-03-12 Thread Marco Martin
On March 10, 2015, 11:30 a.m., Marco Martin wrote: src/quickaddons/configmodule.h, line 43 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line43 I don't particularly like the KDeclarative namespace here since the library is called QuickAddons, but

BluezQt in kdereview

2015-03-12 Thread David Rosca
Hi all, I'd like to announce that BluezQt is now in kdereview. https://projects.kde.org/projects/kdereview/bluez-qt It is a Bluez 5 DBus API wrapper library and is going to replace libbluedevil in Bluedevil. If there are no issues, it will be moved to kde/workspace and used in Bluedevil for

Re: Project: libmuon package install for 3rd party applications

2015-03-12 Thread Matthias Klumpp
2015-03-12 21:00 GMT+01:00 Jonathan Riddell j...@jriddell.org: On Thu, Mar 12, 2015 at 08:40:46PM +0100, Matthias Klumpp wrote: 2015-03-12 20:34 GMT+01:00 Jonathan Riddell j...@jriddell.org: [...] What's the difference between this and the already existing PackageKit(-Qt) and PackageKit

Re: Project: libmuon package install for 3rd party applications

2015-03-12 Thread Matthias Klumpp
Hi! 2015-03-12 20:34 GMT+01:00 Jonathan Riddell j...@jriddell.org: Aleix et al: what do you think of this? https://community.kde.org/GSoC/2015/Ideas#Project:_libmuon_package_install_for_3rd_party_applications adapting muon so its library can be used by external apps to install packages?

Re: Project: libmuon package install for 3rd party applications

2015-03-12 Thread Jonathan Riddell
On Thu, Mar 12, 2015 at 08:40:46PM +0100, Matthias Klumpp wrote: 2015-03-12 20:34 GMT+01:00 Jonathan Riddell j...@jriddell.org: Aleix et al: what do you think of this? https://community.kde.org/GSoC/2015/Ideas#Project:_libmuon_package_install_for_3rd_party_applications adapting muon so

Re: Review Request 122916: Fix displaying label1 in job notifications

2015-03-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122916/#review77397 --- Ship it! Please commit to Plasma/5.2 branch and then merge

Re: Review Request 122920: Show pause/stop buttons in jobs notification only for suspendable/killable jobs

2015-03-12 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122920/#review77398 --- Ship it!

Project: libmuon package install for 3rd party applications

2015-03-12 Thread Jonathan Riddell
Aleix et al: what do you think of this? https://community.kde.org/GSoC/2015/Ideas#Project:_libmuon_package_install_for_3rd_party_applications adapting muon so its library can be used by external apps to install packages? Jonathan ___ Plasma-devel

Re: Plasma Bugs

2015-03-12 Thread David Edmundson
On Thu, Mar 12, 2015 at 6:56 PM, Vishesh Handa m...@vhanda.in wrote: On Wed, Mar 11, 2015 at 2:24 PM, David Edmundson da...@davidedmundson.co.uk wrote: All plasmashell bugs are now set up to CC plasma-bugs as discussed at the sprint as some maintainers weren't doing a very good job of

Re: Plasma Bugs

2015-03-12 Thread Vishesh Handa
On Wed, Mar 11, 2015 at 2:24 PM, David Edmundson da...@davidedmundson.co.uk wrote: All plasmashell bugs are now set up to CC plasma-bugs as discussed at the sprint as some maintainers weren't doing a very good job of keeping on top of things. You can subscribe here.

Re: plasma wallpapers

2015-03-12 Thread Jens Reuterberg
Well just as a suggestion can't we post something like please remember to check your local laws concerning official buildings and people and then IF someone hands over an image of an official building then we can ask them. I mean there's no point burning the house down to protect it from

Re: plasma wallpapers

2015-03-12 Thread Martin Klapetek
On Thu, Mar 12, 2015 at 1:53 PM, Jens Reuterberg j...@ohyran.se wrote: Well just as a suggestion can't we post something like please remember to check your local laws concerning official buildings and people and then IF someone hands over an image of an official building then we can ask them.

Re: plasma wallpapers

2015-03-12 Thread Jonathan Riddell
On Thu, Mar 12, 2015 at 01:45:34PM +0100, Martin Klapetek wrote: On Thu, Mar 12, 2015 at 1:31 PM, Jonathan Riddell j...@jriddell.org wrote: On Thu, Mar 12, 2015 at 01:20:35PM +0100, Martin Klapetek wrote: A A However do you know how it is with property licenses when used as

Re: plasma wallpapers

2015-03-12 Thread Jens Reuterberg
Well I'm no legal expert so neither can I. I just think that beyond some care to tell people not to break any local laws there isn't much we can do without making it a contest for who can grasp international trademark law the best. Lets just roll with it for now. Perhaps tell people to check

Re: Review Request 122914: Take Shown and Hidden status in account when showing sidebar

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122914/#review77351 --- Ship it! Ship It! - Marco Martin On March 12, 2015, 4:24

Re: Review Request 122914: Take Shown and Hidden status in account when showing sidebar

2015-03-12 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122914/ --- (Updated March 12, 2015, 5:40 p.m.) Status -- This change has been

Re: plasma wallpapers

2015-03-12 Thread Martin Klapetek
Hey, On Mon, Mar 9, 2015 at 3:46 PM, kainz.a kain...@gmail.com wrote: Hi plasma developers, I'm part of the VDG and do some artwork for the Breeze icon set. Plasma 5.1 and 5.2 has a new wallpaper but only one. I would like to see some nice wallpapers for 5.3 in other areas. There was a

Re: Review Request 122886: QML-only KCM base

2015-03-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122886/#review77304 --- src/quickaddons/configmodule.h

Re: Review Request 122886: QML-only KCM base

2015-03-12 Thread Marco Martin
On March 11, 2015, 2:07 p.m., David Edmundson wrote: src/quickaddons/configmodule.h, line 373 https://git.reviewboard.kde.org/r/122886/diff/1/?file=354024#file354024line373 I guess you copy and pasted all these. KConfigXT isn't relevant at all here. yes, is pretty much

Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122673/ --- (Updated March 10, 2015, 5:10 p.m.) Status -- This change has been