Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123337/ --- (Updated April 11, 2015, 7:16 nachm.) Review request for Plasma.

Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123337/ --- (Updated April 11, 2015, 7:26 p.m.) Status -- This change has been

Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123337/#review78832 --- Ship it! here's a citation for your smooth change:

Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread David Edmundson
On April 11, 2015, 7:01 p.m., David Edmundson wrote: It is now hardcoded to 2000s which is a little bit slower than the original one (250 times 6) Why hardcode instead of longAnimation * 8? Kai Uwe Broulik wrote: Originally it used to be 6 * 250, now it's 6 * 120 which is just

Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123337/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread Kai Uwe Broulik
On April 11, 2015, 7:01 nachm., David Edmundson wrote: It is now hardcoded to 2000s which is a little bit slower than the original one (250 times 6) Why hardcode instead of longAnimation * 8? Originally it used to be 6 * 250, now it's 6 * 120 which is just hyperactive. - Kai Uwe

Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123337/#review78829 --- It is now hardcoded to 2000s which is a little bit slower

Re: Review Request 123332: Timer: Added config ui for notification and title text

2015-04-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78812 --- applets/timer/package/contents/config/main.xml (line 33)

Re: Review Request 123273: Image Wallpaper: Don't show duplicates after removing some of the wallpapers

2015-04-11 Thread Antonis Tsiapaliokas
On April 6, 2015, 12:56 p.m., Antonis Tsiapaliokas wrote: wallpapers/image/backgroundlistmodel.cpp, line 246 https://git.reviewboard.kde.org/r/123273/diff/1/?file=360275#file360275line246 I am putting this comment here as an example. I could either remove this comment before

Re: Plasma 5.3 beta tars

2015-04-11 Thread Jonathan Riddell
kwin updated, sha256 22afdfb955d8bd733d12e3ee1cd0cc70fc9367e8cbd4070a973f18008b65395e https://git.reviewboard.kde.org/r/123320/ Summary: Fix DecorationPalette loading when kdeglobals lacks WM group Jonathan On 9 April 2015 at 15:52, Jonathan Riddell j...@jriddell.org wrote: beta tars for

Re: System Settings app design freshening

2015-04-11 Thread David Edmundson
On Sun, Mar 29, 2015 at 12:20 AM, Andrew Lake jamboar...@gmail.com wrote: Recently it was mentioned that it would be nice to get system settings a little more breezy. The VDG has been working on a system settings design for a while and, after a little time trying to get the proposed designs

Re: Review Request 123332: Timer: Added config ui for notification and title text

2015-04-11 Thread Bernhard Friedreich
On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? using QtLayouts.Layout.fillWidth: true doesn't work for me

Review Request 123332: Timer: Added config ui for notification and title text

2015-04-11 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- Review request for Plasma. Repository: kdeplasma-addons Description

Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123337/#review78838 --- Do I understand it correctly that now when animations are

Re: Review Request 123337: Use Animator for NeedsAttention pulse animation and make it less noisy

2015-04-11 Thread Kai Uwe Broulik
On April 11, 2015, 10:15 nachm., Martin Klapetek wrote: Do I understand it correctly that now when animations are off, the NeedsAttention state of KSNI will do just nothing? That is seriously bad if that's the case; it should at least fallback to the NeedsAttention icon that the spec