Re: Review Request 123556: KPackage::findPackages with a filter callback

2015-04-30 Thread Marco Martin
> On April 29, 2015, 8:53 p.m., Alex Richardson wrote: > > src/kpackage/packageloader.cpp, line 273 > > > > > > This will crash if there is no filter. > > > > `if (!filter || filter(plugin))` should work

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-30 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 30, 2015, 9:05 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-30 Thread Ashish Bansal
> On April 28, 2015, 2:35 p.m., David Faure wrote: > > src/core/global.cpp, line 407 > > > > > > startsWith('.') (using the QChar overload) > > > > Do we even need this special case, with the way the co

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-30 Thread Ashish Bansal
> On April 28, 2015, 2:35 p.m., David Faure wrote: > > src/core/global.cpp, line 407 > > > > > > startsWith('.') (using the QChar overload) > > > > Do we even need this special case, with the way the co

ISO for 2015-04-30

2015-04-30 Thread Harald Sitter
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist Earlier ISO this week because tomorrow is a holiday in Austria. This ISO is back to using unstable builds (i.e. git master; what will be Plasma 5.4). If you installed one of the previous two ISOs please reinstall or manually chan

Review Request 123570: Add a method to insert new known structures

2015-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 123570: Add a method to insert new known structures

2015-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ --- (Updated April 30, 2015, 9:31 a.m.) Review request for KDE Frameworks and

5.4 Kickoff Meeting Minutes

2015-04-30 Thread Jonathan Riddell
Plasma 5.4 Kickstart Meeting = schedule agreement https://techbase.kde.org/Schedules/Plasma_5 - https://www.google.com/calendar/embed?src=031gkgqg1hjf8lcmj0em1d2sj8%40group.calendar.google.com&ctz=Europe/Madrid - agreed = what will happen with baloo/kfilemetadata/baloo-widgets - move baloo/kf

Review Request 123575: Improve debug information for some plasmoids

2015-04-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: p

[Breeze] [Bug 346972] New: Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Evert Vorster
https://bugs.kde.org/show_bug.cgi?id=346972 Bug ID: 346972 Summary: Star rating icons in amarok always black with breeze theme Product: Breeze Version: unspecified Platform: Archlinux Packages OS: Linux

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Evert Vorster
https://bugs.kde.org/show_bug.cgi?id=346972 --- Comment #1 from Evert Vorster --- This bug was reported against Amarok with number 346711, but it was claimed that this is not an Amarok bug, as it works fine in Oxygen theme -- You are receiving this mail because: You are the assignee for the bug

Re: Review Request 123575: Improve debug information for some plasmoids

2015-04-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/#review79740 --- Ship it! Ship It! - Marco Martin On April 30, 2015, 5:35 p

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Andrew Lake
https://bugs.kde.org/show_bug.cgi?id=346972 Andrew Lake changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=346972 --- Comment #3 from Christoph Feck --- Amarok is a KDE4 application, so it's not fixed. *** This bug has been marked as a duplicate of bug 346625 *** -- You are receiving this mail because: You are the assignee for the bug. __

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=346972 David Edmundson changed: What|Removed |Added CC||k...@davidedmundson.co.uk --- Comment #4 from

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=346972 --- Comment #5 from Christoph Feck --- The change apparently does not work :/ -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org http

[Breeze] [Bug 346972] Star rating icons in amarok always black with breeze theme

2015-04-30 Thread Andrew Lake
https://bugs.kde.org/show_bug.cgi?id=346972 Andrew Lake changed: What|Removed |Added Resolution|DUPLICATE |FIXED --- Comment #6 from Andrew Lake --- Sorry,