Re: Review Request 123575: Improve debug information for some plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123575/ --- (Updated May 14, 2015, 12:57 a.m.) Status -- This change has been ma

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 13, 2015, 11:09 p.m., Aleix Pol Gonzalez wrote: > > I'm not against the patch, but in general urls without scheme > > Aleix Pol Gonzalez wrote: > Eh sorry, I published before finishing the sentence. > > I'm not against the patch, but in general urls without scheme usually

Re: Review Request 123784: Make sure we're not magically converting from QString to QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123784/ --- (Updated May 14, 2015, 12:21 a.m.) Status -- This change has been ma

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 1:09 a.m., Aleix Pol Gonzalez wrote: > > I'm not against the patch, but in general urls without scheme > > Aleix Pol Gonzalez wrote: > Eh sorry, I published before finishing the sentence. > > I'm not against the patch, but in general urls without scheme usually >

Re: Review Request 123784: Make sure we're not magically converting from QString to QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123784/#review80324 --- Ship it! Ship It! - Eike Hein On May 14, 2015, 12:02 a.m.,

Review Request 123784: Make sure we're not magically converting from QString to QUrl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123784/ --- Review request for KDE Frameworks and Plasma. Repository: kio-extras De

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 13, 2015, 11:09 p.m., Aleix Pol Gonzalez wrote: > > I'm not against the patch, but in general urls without scheme > > Aleix Pol Gonzalez wrote: > Eh sorry, I published before finishing the sentence. > > I'm not against the patch, but in general urls without scheme usually

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

> On May 14, 2015, 1:09 a.m., Aleix Pol Gonzalez wrote: > > I'm not against the patch, but in general urls without scheme Eh sorry, I published before finishing the sentence. I'm not against the patch, but in general urls without scheme usually sound like QUrl API misuse. - Aleix -

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/#review80321 --- I'm not against the patch, but in general urls without scheme

Review Request 123783: Adjust showing desktop behavior

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123783/ --- Review request for kwin, Plasma, Kai Uwe Broulik, David Edmundson, Martin

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/ --- (Updated May 13, 2015, 7:38 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/ --- (Updated May 13, 2015, 7:22 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 123735: version of QmlObject with a static engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 13, 2015, 5:37 p.m.) Review request for KDE Frameworks and P

Re: Review Request 123735: version of QmlObject with a static engine

> On May 12, 2015, 5:45 p.m., Mark Gaiser wrote: > > src/kdeclarative/qmlobjectsharedengine.h, line 57 > > > > > > std::unique_ptr<...> ... > > then you can also forget about the delete in the destructor. buh

Re: Review Request 123770: Play the login sound in its own thread

> On May 13, 2015, 4:37 p.m., David Edmundson wrote: > > Ship It! Stable? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80304 ---

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123779/ --- (Updated May 13, 2015, 5:05 p.m.) Status -- This change has been mar

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123779/#review80311 --- Ship it! - Eike Hein On May 13, 2015, 4:53 p.m., Martin Kla

Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123779/ --- Review request for Plasma. Bugs: 340326 http://bugs.kde.org/show_bug.

Re: Review Request 123738: Use column major in the taskbar when "Force row settings" is set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80309 --- The implementation is fine (modulo the nitpick) and I'm on boa

Re: Review Request 123738: Use column major in the taskbar when "Force row settings" is set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- (Updated maj 13, 2015, 3:45 e.m.) Review request for Plasma and Eike Hein

Re: Review Request 123770: Play the login sound in its own thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80304 --- Ship it! Ship It! - David Edmundson On May 13, 2015, 10:09

Re: Review Request 123770: Play the login sound in its own thread

> On May 13, 2015, 1:05 p.m., David Edmundson wrote: > > do you still have any backtraces of the original freeze? > > Martin Klapetek wrote: > I never had any, but Hrvoje and Mark had those problems as reported in > https://git.reviewboard.kde.org/r/118636/ [14:01:22] mck182: seems your p

Re: Review Request 123770: Play the login sound in its own thread

> On May 13, 2015, 1:05 p.m., David Edmundson wrote: > > do you still have any backtraces of the original freeze? I never had any, but Hrvoje and Mark had those problems as reported in https://git.reviewboard.kde.org/r/118636/ - Martin ---

Re: Review Request 123770: Play the login sound in its own thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/#review80290 --- do you still have any backtraces of the original freeze? - Da

Re: Review Request 123746: Workaround DBusMenuQt's design

> On May 13, 2015, 2:49 a.m., Aleix Pol Gonzalez wrote: > > Has DBusMenuQt been fixed? Or is it beyond our reach for a weird reason? > > Aleix Pol Gonzalez wrote: > PS: I don't mind the workaround as long as we fix upstream too. Two hold ups 1) I already have some a clearly perfect pending

Review Request 123770: Play the login sound in its own thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Proposal for better collaboration on xdg-shell

Yeah. I think some people were assuming xdg-shell was final, and I was its gatekeeper, and it's what GNOME wants and you have to fight to get other things in. That wasn't my intention at all! My goal was to build a solid base for the rest of the DEs to eventually work more like how Bryce wants, bu

Re: Proposal for better collaboration on xdg-shell

On Mon, 20 Apr 2015 17:10:08 -0700 Bryce Harrington wrote: > A while back Pekka asked if I'd help look at xdg-shell and how we can > ensure it really does become a cross-desktop standard. I promised to > engage with the EFL folks and get their feedback, which I posted > recently. http://lists.