Re: Review Request 123783: Adjust showing desktop behavior

2015-05-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123783/#review80328 --- +1 - Marco Martin On May 13, 2015, 10:21 p.m., Thomas Lübki

Re: Review Request 123621: Fix reverse scroll setting in Mouse KCM

2015-05-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123621/#review80336 --- Ship it! Ship It! - David Edmundson On May 4, 2015, 9:10 a

Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123789/ --- Review request for Plasma. Bugs: 345872 https://bugs.kde.org/show_bug

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123789/ --- (Updated May 14, 2015, 11:03 a.m.) Review request for Plasma. Bugs: 345

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123789/#review80338 --- applets/systemtray/package/contents/ui/main.qml (line 104)

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123789/ --- (Updated May 14, 2015, 11:20 a.m.) Review request for Plasma. Bugs: 345

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
> On May 14, 2015, 11:11 a.m., Kai Uwe Broulik wrote: > > applets/systemtray/package/contents/ui/main.qml, line 110 > > > > > > Check whether defaults = host.defaultPlasmoids.slice() works and is > > faster see

[Powerdevil] [Bug 347712] Backlight settings based on local time

2015-05-14 Thread Lukáš Tinkl
https://bugs.kde.org/show_bug.cgi?id=347712 Lukáš Tinkl changed: What|Removed |Added Version|5.9.0 |unspecified Component|general

[Powerdevil] [Bug 347712] Backlight settings based on local time

2015-05-14 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=347712 --- Comment #8 from Martin Klapetek --- Ah so it wasn't a patch, but a project proposal for the webcam --> http://marc.info/?l=kde-core-devel&m=133352645130676&w=2 -- You are receiving this mail because: You are the assignee for the bug. _

[Powerdevil] [Bug 347712] Backlight settings based on local time

2015-05-14 Thread Roman Šmakal
https://bugs.kde.org/show_bug.cgi?id=347712 --- Comment #9 from Roman Šmakal --- This is example app working with webcam data, but laptops have way too big backlight steps, so its not quite good for regular usage. http://www.webupd8.org/2012/06/calise-sets-screen-backlight-based-on.html -- You

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123789/#review80346 --- Ship it! applets/systemtray/package/contents/ui/main.qml (li

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
> On May 14, 2015, 2:19 p.m., David Edmundson wrote: > > applets/systemtray/package/contents/ui/main.qml, line 126 > > > > > > is it this thing? > > http://tsdgeos.blogspot.co.uk/2015/02/qt-54-qml-c-qvariant-

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
> On May 14, 2015, 2:19 p.m., David Edmundson wrote: > > applets/systemtray/package/contents/ui/main.qml, line 126 > > > > > > is it this thing? > > http://tsdgeos.blogspot.co.uk/2015/02/qt-54-qml-c-qvariant-

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
> On May 14, 2015, 2:19 p.m., David Edmundson wrote: > > applets/systemtray/package/contents/ui/main.qml, line 126 > > > > > > is it this thing? > > http://tsdgeos.blogspot.co.uk/2015/02/qt-54-qml-c-qvariant-

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
> On May 14, 2015, 2:19 p.m., David Edmundson wrote: > > applets/systemtray/package/contents/ui/main.qml, line 126 > > > > > > is it this thing? > > http://tsdgeos.blogspot.co.uk/2015/02/qt-54-qml-c-qvariant-

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123789/ --- (Updated May 14, 2015, 3:09 p.m.) Review request for Plasma. Bugs: 3458

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123789/#review80354 --- Ship it! Ship It! - David Edmundson On May 14, 2015, 3:09

Re: Review Request 123789: automatically add newly installed plasmoids in the systray

2015-05-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123789/ --- (Updated May 14, 2015, 3:17 p.m.) Status -- This change has been mar

Something has gone horribly wrong.. Linux builds carnage.

2015-05-14 Thread Scarlett Clark
I woke up this morning to a sea of red. Almost all of the linux builds are failing. It looks like QT5 was triggered by an scm change, but hard to tell as it was also started and aborted by kaning. The error: 15:16:38 /srv/jenkins/install/ubuntu/x86_64/g++/kf5- qt5/qt5/inst/include/QtCore/qglobal.

Re: Review Request 123770: Play the login sound in its own thread

2015-05-14 Thread Martin Klapetek
> On May 13, 2015, 4:37 p.m., David Edmundson wrote: > > Ship It! > > Martin Klapetek wrote: > Stable? I'll push to master for now, we can cherry pick afterwards. - Martin --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 123770: Play the login sound in its own thread

2015-05-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123770/ --- (Updated May 14, 2015, 6:03 p.m.) Status -- This change has been mar

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

2015-05-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/#review80362 --- Right, this code should have been ported to entry.insert(KIO:

Re: Review Request 123783: Adjust showing desktop behavior

2015-05-14 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123783/#review80368 --- > 1) The minimizability of windows is ignored. It's a cornerca

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

2015-05-14 Thread Eike Hein
> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem safer to me, because closer to the kde4 behav

Re: Review Request 123621: Fix reverse scroll setting in Mouse KCM

2015-05-14 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123621/ --- (Updated May 15, 2015, 4:45 a.m.) Status -- This change has been mar