Re: Review Request 123738: Use column major in the taskbar when "Force row settings" is set

2015-05-17 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/#review80550 --- Aside from the string issue I think this is fine now. Technica

[Plasma Workspace Wallpapers] [Bug 347532] preferencias de escritorio no permite establecer fondo de pantalla ni individual ni en presentacion solo las del sistenma

2015-05-17 Thread suscavalencia
https://bugs.kde.org/show_bug.cgi?id=347532 --- Comment #3 from suscavalen...@gmail.com --- im running plasma 5 and os kubuntu 15.04 and at set the wallpaper dektop show a message "url cannot be listed " and not allow set the wallpaper on desktop only the system' wallpaper help me please -- You

Re: Review Request 123738: Use column major in the taskbar when "Force row settings" is set

2015-05-17 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- (Updated maj 17, 2015, 8:01 e.m.) Review request for Plasma and Eike Hein

Re: Review Request 123688: Improve sddm login experience

2015-05-17 Thread David Kahles
> On May 17, 2015, 1:39 p.m., David Edmundson wrote: > > Would be nice to make sure the lock screen behaviour matches Yes, that's on my todo list, but it will need some time because I have to lern the ksmserver stuff. The only difference besides multiscreen behavior is the moment when the wrong

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/ --- (Updated May 17, 2015, 6:18 p.m.) Status -- This change has been mar

Re: Review Request 123821: Highlight leading and trailing whitespace

2015-05-17 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123821/#review80530 --- Ship it! Would be nice to get the same for the good old popup

Re: Review Request 123808: Add FindEvdev cmake module BUG:347749

2015-05-17 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123808/ --- (Updated May 17, 2015, 4:10 p.m.) Status -- This change has been mar

Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.

2015-05-17 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123815/ --- (Updated May 17, 2015, 1:23 p.m.) Status -- This change has been mar

Re: Review Request 123688: Improve sddm login experience

2015-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123688/#review80518 --- Ship it! Would be nice to make sure the lock screen behaviour

Re: Review Request 123814: Use KMessageWidget for polkit error

2015-05-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123814/ --- (Updated May 17, 2015, 11:37 a.m.) Status -- This change has been ma

Re: Review Request 123807: Fix popup menu items getting stray highlighted

2015-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123807/#review80517 --- +1 - David Edmundson On May 15, 2015, 10:39 p.m., Albert As

Re: Review Request 123814: Use KMessageWidget for polkit error

2015-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123814/#review80516 --- Ship it! Ship It! - David Edmundson On May 16, 2015, 4:38

Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.

2015-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123815/#review80514 --- Ship it! Nice work, thanks. - David Edmundson On May 16, 2

Re: Review Request 123808: Add FindEvdev cmake module BUG:347749

2015-05-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123808/#review80513 --- Ship it! Ship It! - David Edmundson On May 16, 2015, 7:07

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-17 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- (Updated May 17, 2015, 11:01 a.m.) Status -- This change has been ma

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80511 --- Ship it! Ship It! - Kai Uwe Broulik On Mai 17, 2015, 9:42

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-17 Thread Yoann Laissus
> On mai 16, 2015, 10:33 après-midi, Kai Uwe Broulik wrote: > > I think it should be refreshed whenever you hover a device, not every 5 > > seconds needlessly consuming resources when you don't look at it. You're right. The refresh is now triggered only when the device notifier is visible. -

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-17 Thread Yoann Laissus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/ --- (Updated mai 17, 2015, 9:42 matin) Review request for Plasma. Changes -