Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

2015-07-08 Thread Burkhard Lück
> On Juli 8, 2015, 9:52 nachm., Luigi Toscano wrote: > > Not sure about the fate of appmenu as we still depend on dbusmenu, but > > maybe it's just not implemented there. If sebas says it's fine, then I'm > > fine. > > I'm fine with committing as it is, but do we have an entity for &plasma; ?

Re: Shutdown/Logout/Restart problems with KDE/Plasma5

2015-07-08 Thread Christian Butcher
> Did I correctly identify from your message that kauth is the likely problem, or should I have rebuilt something else? Rebuilding polkit-kde-agent-1 and reinstalling seems to have solved the problem. After restarting the desktop will still logout/restart, and the InputActions service, along with

Re: Shutdown/Logout/Restart problems with KDE/Plasma5

2015-07-08 Thread Christian Butcher
> To workaround as an immediate fix: killall -9 polkit-kde-authentication- agent-1 This did indeed allow Plasma to logout/restart (didn't test shutdown yet but see no reason for it to differ) > Wow. Exactly this happened in my system too. I'm guessing it was > because I used ninja to build plasm

Re: Shutdown/Logout/Restart problems with KDE/Plasma5

2015-07-08 Thread Siddhartha
On 8 July 2015 at 23:37, Aleix Pol wrote: > I cannot reproduce this, can you tell me what warning you get? > Is it when configuring polkit-kde-agent-1? It happens for all modules which generate a .policy file https://bugs.kde.org/show_bug.cgi?id=350034 Plasma session hanging due to polkit-kde-au

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

2015-07-08 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/#review82245 --- Ship it! Not sure about the fate of appmenu as we still depen

Re: Review Request 124283: Update kcmstyle docbook to Plasma 5

2015-07-08 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124283/#review82242 --- any comment from docbook team? - Burkhard Lück On Juli 7, 2

Re: on review process again.. phabricator?

2015-07-08 Thread Ben Cooksley
On Thu, Jul 9, 2015 at 2:18 AM, Boudewijn Rempt wrote: > On Wed, 8 Jul 2015, Marco Martin wrote: > >> Some projects are trying out phabricator (looking at kactivities) how do >> they find it? > > > Krita developers, testers and designers all feel Phabricator is pretty fab. > Newbies take to it eas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 68 - Failure!

2015-07-08 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Jul 2015 20:51:32 + Build duration: 10 min CHANGE SET Revision dc41d66cb4422ce97c97c9ac71a0c1cd894e0b

Re: Review Request 124290: Add missing licenses

2015-07-08 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124290/ --- (Updated July 8, 2015, 8:51 p.m.) Status -- This change has been mar

Re: Review Request 124290: Add missing licenses

2015-07-08 Thread Scott Kitterman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124290/#review82238 --- Ship it! Ship It! - Scott Kitterman On July 8, 2015, 7:58

Re: Shutdown/Logout/Restart problems with KDE/Plasma5

2015-07-08 Thread Aleix Pol
On Wed, Jul 8, 2015 at 12:07 PM, Siddhartha wrote: > On 8 July 2015 at 15:01, Ben Cooksley wrote: >> And here is your problem. I'm going to guess that your session doesn't >> restore and the system seems to take a long time to login as well. >> To workaround as an immediate fix: killall -9 >> po

Re: Review Request 124298: Remove logitech-mouse-related code

2015-07-08 Thread Hrvoje Senjan
> On July 8, 2015, 7:09 p.m., Kai Uwe Broulik wrote: > > kcms/input/CMakeLists.txt, line 43 > > > > > > You probably also want to delete the logitechmouse_base.ui file Yeah, deleted that one and header locally, b

Re: Review Request 124298: Remove logitech-mouse-related code

2015-07-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124298/#review82235 --- +1 kcms/input/CMakeLists.txt (line 33)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 67 - Fixed!

2015-07-08 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 08 Jul 2015 16:52:16 + Build duration: 17 min CHANGE SET Revision b30ea5a153bd0cc1c8381eda19ecb09abb5d1b

Review Request 124298: Remove logitech-mouse-related code

2015-07-08 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124298/ --- Review request for Plasma, Aleix Pol Gonzalez and Martin Gräßlin. Reposit

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-08 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/ --- (Updated July 8, 2015, 4:51 p.m.) Status -- This change has been mar

Re: on review process again.. phabricator?

2015-07-08 Thread Martin Klapetek
On Wed, Jul 8, 2015 at 3:48 PM, Marco Martin wrote: > Hi all, > writing about this now since it's nearing Akademy, it may be a good time > and > place to discuss. > > last year at akademy we tried to put plasma-framework on gerrit, in order > to > have a more formal, always review first policy in

Re: on review process again.. phabricator?

2015-07-08 Thread Aleix Pol
On Wed, Jul 8, 2015 at 4:18 PM, Boudewijn Rempt wrote: > On Wed, 8 Jul 2015, Marco Martin wrote: > >> Some projects are trying out phabricator (looking at kactivities) how do >> they find it? > > > Krita developers, testers and designers all feel Phabricator is pretty fab. > Newbies take to it eas

Review Request 124296: Update autostart kcm docbook to kf5

2015-07-08 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124296/ --- Review request for Documentation, Plasma and Jeremy Whiting. Repository:

Re: Review Request 124294: [kcms/touchpad] Only create X11 backend if we are on X11 platform

2015-07-08 Thread Rajeesh K Nambiar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124294/#review82233 --- Ship it! Ship It! - Rajeesh K Nambiar On July 8, 2015, 12:

Re: on review process again.. phabricator?

2015-07-08 Thread Boudewijn Rempt
On Wed, 8 Jul 2015, Ivan Čukić wrote: Hi all, I find phabricator quite interesting. It is easy to use, the only big issue I have with it is the insane naming of the tools. Yeah, that's a point. It's all a bit too cute and punny. Boud___ Plasma-deve

Re: on review process again.. phabricator?

2015-07-08 Thread Ivan Čukić
Hi all, I find phabricator quite interesting. It is easy to use, the only big issue I have with it is the insane naming of the tools. (I guess Eike can weigh in more than this, I'm at a conference now, so need to be quick with my mail processing :) ) Cheerio, Ivan On 8 July 2015 at 15:48, Marco

Re: on review process again.. phabricator?

2015-07-08 Thread Boudewijn Rempt
On Wed, 8 Jul 2015, Marco Martin wrote: Some projects are trying out phabricator (looking at kactivities) how do they find it? Krita developers, testers and designers all feel Phabricator is pretty fab. Newbies take to it easiliy. It takes getting used to because it's more than a reviewboard

Re: Review Request 124280: Only resize plot texture if size actually changes

2015-07-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124280/ --- (Updated July 8, 2015, 1:55 p.m.) Status -- This change has been mar

on review process again.. phabricator?

2015-07-08 Thread Marco Martin
Hi all, writing about this now since it's nearing Akademy, it may be a good time and place to discuss. last year at akademy we tried to put plasma-framework on gerrit, in order to have a more formal, always review first policy in plasma-framework. i think was partly a success, I see moresmall ch

Review Request 124294: [kcms/touchpad] Only create X11 backend if we are on X11 platform

2015-07-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124294/ --- Review request for Plasma and Rajeesh K Nambiar. Repository: plasma-deskt

Re: Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-08 Thread Bhushan Shah
> On July 8, 2015, 4:45 p.m., Aleix Pol Gonzalez wrote: > > startkde/startplasma.cmake, line 119 > > > > > > No better way to display an error message? > > Martin Gräßlin wrote: > I don't know how else to do

Re: Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-08 Thread Aleix Pol Gonzalez
> On July 8, 2015, 1:15 p.m., Aleix Pol Gonzalez wrote: > > startkde/startplasma.cmake, line 119 > > > > > > No better way to display an error message? > > Martin Gräßlin wrote: > I don't know how else to do

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-08 Thread Martin Gräßlin
> On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: > > Looks good to me too, as long as it works. > > OTOH, it looks like a bad reason to offer an homogeneous experience, albeit > > being a not really interesting bit of Plasma. > > Hrvoje Senjan wrote: > I submited this patch to upstre

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-08 Thread Aleix Pol Gonzalez
> On July 7, 2015, 1:06 a.m., Aleix Pol Gonzalez wrote: > > Looks good to me too, as long as it works. > > OTOH, it looks like a bad reason to offer an homogeneous experience, albeit > > being a not really interesting bit of Plasma. > > Hrvoje Senjan wrote: > I submited this patch to upstre

Re: Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-08 Thread Martin Gräßlin
> On July 8, 2015, 1:15 p.m., Aleix Pol Gonzalez wrote: > > startkde/startplasma.cmake, line 109 > > > > > > Are you sure this belongs to the script? yes, it's compatibility for old X world. In startkde it used

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-08 Thread Kai Uwe Broulik
> On Juli 6, 2015, 11:06 nachm., Aleix Pol Gonzalez wrote: > > Looks good to me too, as long as it works. > > OTOH, it looks like a bad reason to offer an homogeneous experience, albeit > > being a not really interesting bit of Plasma. > > Hrvoje Senjan wrote: > I submited this patch to ups

Re: Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124293/#review82219 --- startkde/startplasma.cmake (line 109)

Re: Review Request 124292: [ksmserver] Force QPA platform xcb

2015-07-08 Thread Martin Gräßlin
> On July 8, 2015, 1:05 p.m., Aleix Pol Gonzalez wrote: > > +1 LGTM. > > > > Still, this is a workaround... ksmserver shouldn't be using X11 after all. > > Or there's a good reason? yes, there are good reasons. It is the X11 session manager. This is a functionality which is very X specific an

Re: Review Request 124292: [ksmserver] Force QPA platform xcb

2015-07-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124292/#review82217 --- +1 LGTM. Still, this is a workaround... ksmserver shouldn't b

Re: Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-08 Thread Martin Gräßlin
> On July 8, 2015, 12:45 p.m., Kai Uwe Broulik wrote: > > startkde/startplasmacompositor.cmake, line 141 > > > > > > We depend on 5.4 now, don't we? yeah, but that needs to be fixed in startkde first. I don't kn

Re: Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124293/#review82214 --- startkde/startplasma.cmake (lines 88 - 90)

Re: Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124293/#review82213 --- Ship it! Ship It! - Marco Martin On July 8, 2015, 10:26 a.

Review Request 124293: Add a startplasmacompositor and startplasma file

2015-07-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124293/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Shutdown/Logout/Restart problems with KDE/Plasma5

2015-07-08 Thread Siddhartha
On 8 July 2015 at 15:01, Ben Cooksley wrote: > And here is your problem. I'm going to guess that your session doesn't > restore and the system seems to take a long time to login as well. > To workaround as an immediate fix: killall -9 > polkit-kde-authentication-agent-1 Wow. Exactly this happene

Re: Shutdown/Logout/Restart problems with KDE/Plasma5

2015-07-08 Thread Ben Cooksley
On Wed, Jul 8, 2015 at 9:26 PM, Christian Butcher wrote: > I originally send this to kde-linux, and was advised to post to > plasma-devel. > > When I go to use the logout/shutdown/restart buttons in Plasma 5, the > computer does not take the action requested. > > A message in the style of > > Shut

Review Request 124292: [ksmserver] Force QPA platform xcb

2015-07-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124292/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Shutdown/Logout/Restart problems with KDE/Plasma5

2015-07-08 Thread Christian Butcher
I originally send this to kde-linux, and was advised to post to plasma-devel. When I go to use the logout/shutdown/restart buttons in Plasma 5, the computer does not take the action requested. A message in the style of Shutdown called with confirm -1 type 2 and mode -1 is appended to ~/.xs

Review Request 124290: Add missing licenses

2015-07-08 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124290/ --- Review request for Plasma. Repository: plasma-desktop Description -