Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82678 --- May I ask you a favor? Could you please try whether you can

Re: Review Request 124380: Make System Tray use a ProxyModel rather than three independent ones

2015-07-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124380/ --- (Updated July 20, 2015, 8:26 a.m.) Status -- This change has been

Re: Review Request 124382: RFC: Allow plasmoid to specify X-Plasma-NotificationAreaCategory

2015-07-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124382/#review82688 --- Ship it! at some point in kde4 it did try to guess it from

Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

2015-07-20 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

2015-07-20 Thread Martin Klapetek
On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? Bernhard Friedreich wrote: that should be possible yes.. but shouldn't it also work like this? I think you are supposed to just add

Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)

2015-07-20 Thread Martin Klapetek
On July 19, 2015, 6:51 p.m., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? Bernhard Friedreich wrote: that should be possible yes.. but shouldn't it also work like this? Martin Klapetek wrote: I think you

Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

2015-07-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/#review82708 --- This is rather surprising. How does it compile? std::cout

Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

2015-07-20 Thread David Faure
On July 20, 2015, 12:32 p.m., David Faure wrote: This is rather surprising. How does it compile? std::cout doesn't have operator for QString, and QString's implicit conversion to char * is disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the first

Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

2015-07-20 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/ --- (Updated July 20, 2015, 12:59 p.m.) Status -- This change has been

Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

2015-07-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124404/#review82704 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 20, 2015,

Re: Review Request 124382: RFC: Allow plasmoid to specify X-Plasma-NotificationAreaCategory

2015-07-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124382/ --- (Updated July 20, 2015, 12:17 p.m.) Status -- This change has been

Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

2015-07-20 Thread Aleix Pol Gonzalez
On July 20, 2015, 2:32 p.m., David Faure wrote: This is rather surprising. How does it compile? std::cout doesn't have operator for QString, and QString's implicit conversion to char * is disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the first

Re: Review Request 124404: kpackagetool: Fix output of non-latin text to stdout

2015-07-20 Thread Alexander Potashev
On Июль 20, 2015, 12:32 п.п., David Faure wrote: This is rather surprising. How does it compile? std::cout doesn't have operator for QString, and QString's implicit conversion to char * is disabled by -DQT_NO_CAST_TO_ASCII (which is set, otherwise that would be a bug in the first

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread Eric Koegel
On July 20, 2015, 6:22 a.m., Martin Gräßlin wrote: May I ask you a favor? Could you please try whether you can get kwin_wayland (drm/libinput) to work with consolekit2? That would be totally awesome! Of course I'm also interested in consolekit2 addons to screen locker if there

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread Eric Koegel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/ --- (Updated July 20, 2015, 2:04 p.m.) Review request for Plasma and Solid.

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82731 --- Thanks! daemon/backends/upower/powerdevilupowerbackend.cpp

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Jens Reuterberg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82734 --- Ship it! Ship It! - Jens Reuterberg On juli 20, 2015,

Re: Review Request 124388: Add ConsoleKit2 as a power backend

2015-07-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124388/#review82730 --- Looks good to me. Do you have commit access?

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82732 --- Nice! +1 from me. - Andrew Lake On July 20, 2015, 8:19

Review Request 124408: Make PlasmaCore.Dialog opacity work

2015-07-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124408/ --- Review request for Plasma. Repository: plasma-framework Description

Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/ --- Review request for Plasma and KDE Usability. Repository:

Kio.KRun Segmentation fault in plasma2 widget

2015-07-20 Thread Nicola Felice
I posted this message to the plasma5 forum (https://forum.kde.org/viewtopic.php?f=289t=127322) and an administrator replied to write here too. I'm playing with plasma widget development, I am currently trying to write a widget to launch a .desktop file. I have some problems finding the

[Breeze] [Bug 350434] New: SDDM theme does not use Breeze user icons

2015-07-20 Thread Markus S .
https://bugs.kde.org/show_bug.cgi?id=350434 Bug ID: 350434 Summary: SDDM theme does not use Breeze user icons Product: Breeze Version: 5.3.2 Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[Breeze] [Bug 350434] SDDM theme does not use Breeze user icons

2015-07-20 Thread Markus S .
https://bugs.kde.org/show_bug.cgi?id=350434 Markus S. kamika...@web.de changed: What|Removed |Added CC||kamika...@web.de,

Re: Review Request 124409: Begin fading the OSD immediately

2015-07-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124409/#review82738 --- lookandfeel/contents/osd/Osd.qml (line 48)