Meeting Monday

2015-07-31 Thread David Edmundson
Hangouts meeting at the usual time Monday. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 124509: Use small button for session combo

2015-07-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/#review83144 --- lookandfeel/contents/loginmanager/Main.qml (line 187)

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-31 Thread David Edmundson
On Fri, Jul 31, 2015 at 11:33 PM, Jonathan Riddell j...@jriddell.org wrote: Thanks for doing this, the kcm_useraccounts has long needed to be replaced. It was a longstanding todo item to replace it with user-manager which I've by coincidence just done tonight by using KEMailSettings as well

Reintroducing Feature Freezes

2015-07-31 Thread David Edmundson
There are _way_ too many changes happening at the last minute; with huge branches merging, KCM replacements, and entire new repos. This should happen at the start of the cycle *not* the end. Betas should not have new things in them, it should be things we think work, not things that have scarcely

Re: AccountsService qt binding for sddm, plasma-workspace

2015-07-31 Thread Jonathan Riddell
On Sat, Aug 01, 2015 at 02:04:09AM +0200, David Edmundson wrote: We had kcm_useraccounts in plasma-desktop, which is super old and rubbish We had user-manager, somwhere, which is Alex's one.It uses accounts-service, via it's own lib In plasma-desktop we have a branch caller user-accounts

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-31 Thread Leslie Zhai
On 2015年08月01日 08:04, David Edmundson wrote: On Fri, Jul 31, 2015 at 11:33 PM, Jonathan Riddell j...@jriddell.org mailto:j...@jriddell.org wrote: Thanks for doing this, the kcm_useraccounts has long needed to be replaced. It was a longstanding todo item to replace it with

Re: Review Request 124537: RFC: Add autocfg property magic for applet config dialogs

2015-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124537/#review83231 --- I like the idea, not sure about the autocfg_ prefix. was it

Review Request 124547: Use the same behavior of MouseArea to map coords of filtered child events

2015-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124547/ --- Review request for Plasma. Repository: kdeclarative Description

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/ --- (Updated July 31, 2015, 1:03 p.m.) Review request for Plasma and Vishesh

Re: Review Request 124543: Don't horizontally shift dialog

2015-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124543/#review83230 --- did you test it with left and right edge panels? - Marco

Review Request 124548: Proofread kgamma kcm docbook to kf5

2015-07-31 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124548/ --- Review request for Documentation and Plasma. Repository: kgamma

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/ --- (Updated July 31, 2015, 1:52 p.m.) Status -- This change has been

[Breeze] [Bug 350500] I can't read white text on white background.

2015-07-31 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=350500 --- Comment #9 from Martin Klapetek mklape...@kde.org --- Can I ask what Plasma theme are you using? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/#review83235 --- You even added categorized logging! Big +1, again :)

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/#review83236 --- Ship it! Ship It! - Jeremy Whiting On July 31, 2015, 7:03

Review Request 124555: use kwayland to move Plasma::Dialog

2015-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124555/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 124547: Use the same behavior of MouseArea to map coords of filtered child events

2015-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124547/ --- (Updated July 31, 2015, 3:16 p.m.) Status -- This change has been

Re: Review Request 124536: Expose immutable config options in ConfigPropertyMap

2015-07-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124536/#review83232 --- src/kdeclarative/configpropertymap.cpp (line 76)

[Powerdevil] [Bug 350807] Desktop freezes when monitor switched off

2015-07-31 Thread Dan Ciarniello
https://bugs.kde.org/show_bug.cgi?id=350807 --- Comment #2 from Dan Ciarniello da...@ciarniello.ca --- It is just the Plasma desktop; the computer otherwise works. Disabling compositing (I disabled it through System Settings - Display and Monitor - Compositor) doesn't make a difference, the

Re: Review Request 124555: use kwayland to move Plasma::Dialog

2015-07-31 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124555/#review83250 --- shell/waylanddialogfilter.cpp (line 26)

Re: Review Request 124537: RFC: Add autocfg property magic for applet config dialogs

2015-07-31 Thread Kai Uwe Broulik
On Juli 31, 2015, 12:55 nachm., Marco Martin wrote: I like the idea, not sure about the autocfg_ prefix. was it discussed in a bof? are there notes about it? Yeah, maybe cfgitem or something like that? Well, they mentioned they need good Kiosk support so I wanted to make the Plasma stuff

Re: Review Request 124555: use kwayland to move Plasma::Dialog

2015-07-31 Thread Marco Martin
On July 31, 2015, 7:26 p.m., Martin Gräßlin wrote: The copy of dialog.h somehow scares me - is there no other way? I'm afraid it will totally get out of sync especially given that the release cycles are not synced. ah, that copy is already around.. an alternative is to completely give

Re: Review Request 124555: use kwayland to move Plasma::Dialog

2015-07-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124555/#review83262 --- The copy of dialog.h somehow scares me - is there no other

Re: Review Request 124543: Don't horizontally shift dialog

2015-07-31 Thread Kai Uwe Broulik
On Juli 31, 2015, 12:52 nachm., Marco Martin wrote: did you test it with left and right edge panels? Didn't notice anything unusual. It also fixes the QueryDialog being shifted to the left corner of the screen if I put the lock_logout applet into a panel and ask it to suspend. - Kai Uwe

Review Request 124571: add features from kcm_useraccounts

2015-07-31 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124571/ --- Review request for Plasma. Repository: user-manager Description

Re: Review Request 124571: add features from kcm_useraccounts

2015-07-31 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124571/#review83268 --- Ship it! src/lib/accountmodel.cpp (line 164)

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-31 Thread Jonathan Riddell
Thanks for doing this, the kcm_useraccounts has long needed to be replaced. It was a longstanding todo item to replace it with user-manager which I've by coincidence just done tonight by using KEMailSettings as well as accountsservice. user-manager does much of what you have implemented in your

Re: Review Request 124571: add features from kcm_useraccounts

2015-07-31 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124571/ --- (Updated July 31, 2015, 9:17 p.m.) Status -- This change has been

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-31 Thread Leslie Zhai
well done! I will follow your code ;P On 2015年07月31日 14:04, Pier Luigi Fiorini wrote: 2015-07-29 11:02 GMT+02:00 David Edmundson da...@davidedmundson.co.uk: Hey, sorry for not replying. 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't have to rush. In general, I like

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread Martin Gräßlin
On Juli 30, 2015, 8:42 nachm., Mark Gaiser wrote: ksmserver/startup.cpp, lines 504-518 https://git.reviewboard.kde.org/r/124534/diff/1/?file=388761#file388761line504 You're mixing coding styles here. This looks different (more use of spaces) then the above chunk. Perhaps run

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-31 Thread Pier Luigi Fiorini
2015-07-29 11:02 GMT+02:00 David Edmundson da...@davidedmundson.co.uk: Hey, sorry for not replying. 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't have to rush. In general, I like it, I have some comments. I'm a bit concerned by the blocking calls in

[Powerdevil] [Bug 350807] Desktop freezes when monitor switched off

2015-07-31 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=350807 Kai Uwe Broulik k...@privat.broulik.de changed: What|Removed |Added CC||k...@privat.broulik.de

Re: Review Request 124571: add features from kcm_useraccounts

2015-07-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124571/#review83270 --- src/accountinfo.cpp (line 183)

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/#review83216 --- +1 I guess this code still needs to be ported to using the

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 109 - Fixed!

2015-07-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 08:44:04 + Build duration: 14 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 109 - Fixed!

2015-07-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 08:44:04 + Build duration: 14 min CHANGE SET Revision

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/ --- (Updated July 31, 2015, 8:32 a.m.) Review request for Plasma and Vishesh

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 117 - Still Unstable!

2015-07-31 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/117/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 08:31:44 + Build duration: 15 min CHANGE SET Revision

Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the KDE4 dir

2015-07-31 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/#review83217 --- +1 but someone else must approve (if nobody does in couple

Review Request 124543: Don't horizontally shift dialog

2015-07-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124543/ --- Review request for Plasma. Repository: plasma-framework Description

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

2015-07-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 09:52:09 + Build duration: 6 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 118 - Fixed!

2015-07-31 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/118/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 31 Jul 2015 09:52:09 + Build duration: 6 min 56 sec CHANGE SET Revision