Re: Review Request 124869: Fix widget explorer sometimes opening on the wrong side of the screen.

2015-08-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124869/#review84243 --- desktoppackage/contents/views/Desktop.qml (line 87)

Re: Review Request 124869: Fix widget explorer sometimes opening on the wrong side of the screen.

2015-08-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124869/#review84242 --- Ship it! Ship It! - Martin Gräßlin On Aug. 21, 2015, 7:12

Re: Review Request 124872: Default to Breeze colors

2015-08-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84241 --- Ship it! I must say I'm rather shocked at how this is impleme

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/#review84238 --- Ship it! the middle thing was done in order to not cross the

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 23, 2015, 9:16 p.m.) Status -- This change has been ma

Re: Review Request 123294: Fix check to see if we are the active window before showing notification in polkit agent

2015-08-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123294/ --- (Updated Aug. 23, 2015, 8:54 p.m.) Status -- This change has been di

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

2015-08-23 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=351665 Wolfgang Bauer changed: What|Removed |Added CC||wba...@tmo.at --- Comment #1 from Wolfgang Bau

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
> On Aug. 23, 2015, 1:36 p.m., Hanspeter Niederstrasser wrote: > > Ship It! Oops. My pressing "Ship it" doesn't actually commit. Someone with write access will have to push upstream. Thanks. - Hanspeter --- This is an automatically ge

[kwrited] [Bug 351665] New: KDE shown hidden menu items available but not openable

2015-08-23 Thread Nick Levinson
https://bugs.kde.org/show_bug.cgi?id=351665 Bug ID: 351665 Summary: KDE shown hidden menu items available but not openable Product: kwrited Version: unspecified Platform: unspecified OS: Linux Status: UNCONFIRMED

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84233 --- Ship it! Ship It! - Hanspeter Niederstrasser On Aug. 23, 2

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- (Updated Aug. 23, 2015, 1:26 p.m.) Review request for Build System, KDE S

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84226 --- Ship it! I'm not Harald, but no. it won't. - Sune Vuorela

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84222 --- +1 from me also, but could you add Harald Sitter to the review

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 141 - Still Failing!

2015-08-23 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/141/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 23 Aug 2015 12:56:35 + Build duration: 59 min CHANGE SET Revision f596c2cb6fa79ad311149ac20d142380d739c

Re: Plasma Interface Guidelines

2015-08-23 Thread Alex Merry
On 2015-08-23 10:35, Jens Reuterberg wrote: Perhaps link to the toolkit in the HIG? The PIG was supposed to be a more Plasma-specific thing, including details such as listing the available names for categories of Plasmoids. If the content in that page is no longer useful, I'm inclined to dele

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84220 --- +1 seems to make sense but it's not really my area, wait a day

Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-23 Thread Hanspeter Niederstrasser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/ --- Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,

Re: Review Request 124891: don't enable middle click paste in the panel by default

2015-08-23 Thread Kai Uwe Broulik
> On Aug. 23, 2015, 12:24 nachm., Kai Uwe Broulik wrote: > > You cannot imagine how often I accidentally placed a sticky note on my > > panel. > > > > Do we have a config UI for panel mouse actions? > > David Edmundson wrote: > We do not. > Personally I don't think it's needed, panels

Re: Review Request 124891: don't enable middle click paste in the panel by default

2015-08-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124891/ --- (Updated Aug. 23, 2015, 12:56 p.m.) Status -- This change has been m

Re: Review Request 124891: don't enable middle click paste in the panel by default

2015-08-23 Thread David Edmundson
> On Aug. 23, 2015, 12:24 p.m., Kai Uwe Broulik wrote: > > You cannot imagine how often I accidentally placed a sticky note on my > > panel. > > > > Do we have a config UI for panel mouse actions? We do not. Personally I don't think it's needed, panels rarely have an empty space. So we should

Re: Review Request 124891: don't enable middle click paste in the panel by default

2015-08-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124891/#review84214 --- Ship it! You cannot imagine how often I accidentally placed a

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 140 - Failure!

2015-08-23 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/140/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 23 Aug 2015 11:43:20 + Build duration: 15 min CHANGE SET Revision f38731529bb0479f011bdd85aca1c2be8f6be

Re: Review Request 124548: Proofread kgamma kcm docbook to kf5

2015-08-23 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124548/ --- (Updated Aug. 23, 2015, 12:12 p.m.) Status -- This change has been m

Review Request 124891: don't enable middle click paste in the panel by default

2015-08-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124891/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 124885: Fix issues in translation control module

2015-08-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124885/ --- (Updated Aug. 23, 2015, 11:42 a.m.) Status -- This change has been m

Re: Review Request 124885: Fix issues in translation control module

2015-08-23 Thread Albert Astals Cid
> On ago. 23, 2015, 1:47 a.m., Jeremy Whiting wrote: > > Ship It! > > Jeremy Whiting wrote: > Incidentally, the pt issue sounds like a QLocale bug, do we need to find > one or file a new one for that probably? > > John Layt wrote: > Yeah, looks a Qt bug, it has a table from CLDR of def

Re: Plasma Interface Guidelines

2015-08-23 Thread Jens Reuterberg
Perhaps link to the toolkit in the HIG? Den 23 aug 2015 10:34 fm skrev Alex Merry : > > Techbase has a page titled "Plasma Interface Guidelines"[0]. Leaving > aside the unfortunate acronym, this page is sparsely populated and last > edited in 2012. It is also linked from the development guidelin

Plasma Interface Guidelines

2015-08-23 Thread Alex Merry
Techbase has a page titled "Plasma Interface Guidelines"[0]. Leaving aside the unfortunate acronym, this page is sparsely populated and last edited in 2012. It is also linked from the development guidelines page[1]. Could someone have a look and decide what to do with that page, please? If it

Re: Review Request 124885: Fix issues in translation control module

2015-08-23 Thread John Layt
> On Aug. 23, 2015, 2:47 a.m., Jeremy Whiting wrote: > > Ship It! > > Jeremy Whiting wrote: > Incidentally, the pt issue sounds like a QLocale bug, do we need to find > one or file a new one for that probably? Yeah, looks a Qt bug, it has a table from CLDR of default countries to use so t