Review Request 124929: [screenlocker] Cleanup in LockWindow

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124929/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa

Re: Review Request 124923: Plasma 5 color picker plasmoid

2015-08-25 Thread Kai Uwe Broulik
> On Aug. 25, 2015, 9:22 nachm., Thomas Pfeiffer wrote: > > Great work! > > Two points: > > 1. The two icons in the Plasmoid look like they're two separate Plasmoids, > > which is confusing. They should be more visually connected (we're still > > brainstorming ideas for how to do this in the VD

Re: Review Request 124923: Plasma 5 color picker plasmoid

2015-08-25 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/#review84368 --- Great work! Two points: 1. The two icons in the Plasmoid look

Review Request 124923: Plasma 5 color picker plasmoid

2015-08-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/ --- Review request for Plasma and KDE Usability. Repository: kdeplasma-addons

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread René J . V . Bertin
> On Aug. 25, 2015, 3:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84338 --- > When built as SHARED as in the current code, libdraganddropp

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread David Edmundson
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Plasma 5.4 is out

2015-08-25 Thread Jonathan Riddell
https://www.kde.org/announcements/plasma-5.4.0.php ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 144 - Failure!

2015-08-25 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/144/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 25 Aug 2015 12:59:27 + Build duration: 9 min 53 sec CHANGE SET Revision 611f0aea39d1ff8f49653121f355fa9

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread Harald Sitter
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124892/#review84333 --- I've got both Gentoo and Arch saying this causes a major probl

Re: Plasma 5.4.0

2015-08-25 Thread Jonathan Riddell
Last minute update for kwin http://download.kde.org/stable/plasma/5.4.0/kwin-5.4.0.tar.xz";>kwin-5.4.0 3.6MB - 33371989e8d0eca0b46813891acd37b0e2c5f46b1660db2aa5e840105be8e917 + 81f0caced49288f38ef1b34f70d4f62f4f261bdf57f6875631ec1017cfd6c7d3 commit a97b6e0fd6a5eff53e3fccff825998feb4

Re: Review Request 124912: [screenlocker] Delay uninhibiting sleep till the lock window is shown

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124912/ --- (Updated Aug. 25, 2015, 12:54 p.m.) Status -- This change has been m

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124915/ --- (Updated Aug. 25, 2015, 12:54 p.m.) Status -- This change has been m

Re: Review Request 124912: [screenlocker] Delay uninhibiting sleep till the lock window is shown

2015-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124912/#review84332 --- Ship it! Ship It! - David Edmundson On Aug. 25, 2015, 7:54

Re: Review Request 124912: [screenlocker] Delay uninhibiting sleep till the lock window is shown

2015-08-25 Thread Martin Gräßlin
> On Aug. 25, 2015, 1:04 p.m., David Edmundson wrote: > > ksmserver/screenlocker/lockwindow.h, line 54 > > > > > > this is a pretty silly class name now, given it's not a window I think that would be too much to

Review Request 124918: fix interface name

2015-08-25 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124918/ --- Review request for Plasma. Repository: kscreen Description --- I a

Re: Review Request 124912: [screenlocker] Delay uninhibiting sleep till the lock window is shown

2015-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124912/#review84330 --- ksmserver/screenlocker/lockwindow.h (line 54)

Review Request 124917: [screenlocker] Start grace time when the greeter is shown

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124917/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124915/#review84328 --- Ship it! - David Edmundson On Aug. 25, 2015, 10:38 a.m., Ma

Re: Review Request 123653: New Minimize Windows Plasmoid

2015-08-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- (Updated Aug. 25, 2015, 10:41 a.m.) Status -- This change has been d

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124915/ --- (Updated Aug. 25, 2015, 12:38 p.m.) Review request for Plasma and David E

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread David Edmundson
> On Aug. 25, 2015, 10:15 a.m., David Edmundson wrote: > > ksmserver/screenlocker/lockwindow.cpp, line 85 > > > > > > that's f1 for normal distros > > > > > > maybe we can use either ttyname() he

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread Martin Gräßlin
> On Aug. 25, 2015, 12:15 p.m., David Edmundson wrote: > > ksmserver/screenlocker/lockwindow.cpp, line 84 > > > > > > that's > > sudo loginctl... > > > > doing it as a normal user will give an error.

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124915/#review84325 --- ksmserver/screenlocker/lockwindow.cpp (line 84)

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124915/#review84324 --- As an alternative we can also have it in orange: http://paste

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

2015-08-25 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=351665 --- Comment #4 from Wolfgang Bauer --- PS: (In reply to Nick Levinson from comment #2) > Clicking on the Software Updater icon or the Battery Monitor icon worked but > clicking on the Notifications icon did nothing. If that means there were no > notific

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124915/#review84323 --- ksmserver/screenlocker/lockwindow.cpp (line 81)

Re: Breeze-icons and Plasma Breeze-theme-icons

2015-08-25 Thread kainz.a
Ok I would prefere to have the icons at one place because Uri and I do a lot of work that the right icon in the right SIZE is available for the application in the screenshot you see toolbar icons (22px) for the widgets (64px) and this lack. https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/Plasm

Re: Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124915/ --- (Updated Aug. 25, 2015, 11:16 a.m.) Review request for Plasma and David E

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

2015-08-25 Thread Wolfgang Bauer
https://bugs.kde.org/show_bug.cgi?id=351665 Wolfgang Bauer changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Review Request 124915: [screenlocker] Add emergency mode for greeter crashing

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124915/ --- Review request for Plasma and David Edmundson. Bugs: 351696 https://b

Re: Review Request 124912: [screenlocker] Delay uninhibiting sleep till the lock window is shown

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124912/ --- (Updated Aug. 25, 2015, 9:54 a.m.) Review request for Plasma, Kai Uwe Bro

Review Request 124912: [screenlocker] Delay uninhibiting sleep till the lock window is shown

2015-08-25 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124912/ --- Review request for Plasma, Kai Uwe Broulik and David Edmundson. Repositor