Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-27 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/ --- Review request for Plasma. Repository: plasma-desktop Description

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-08-27 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #2 from Martin Klapetek mklape...@kde.org --- Max Screen Brightness for me says 100. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list

Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/#review84472 --- Ship it! Other than Mark's comments; concept of patch is

Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-27 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/ --- (Updated Aug. 27, 2015, 4:47 p.m.) Status -- This change has been

Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/#review84478 --- Ship it! Ship It! - Marco Martin On Aug. 27, 2015, 2:12

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-08-27 Thread Martin Klapetek
https://bugs.kde.org/show_bug.cgi?id=350676 Martin Klapetek mklape...@kde.org changed: What|Removed |Added CC||mklape...@kde.org ---

Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/ --- Review request for kwin, Plasma and Hans Chen. Repository: kwin

[Powerdevil] [Bug 346456] When screen turn off automatically, it will turn black twice.

2015-08-27 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=346456 --- Comment #2 from Weng Xuetian wen...@gmail.com --- Emm, I don't know. I also noticed that this also happens when I use keyboard to decreaes the brightness to zero, as shown in the video: http://youtu.be/9vdwxsO_zW8 -- You are receiving this mail

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-27 Thread Thomas Lübking
On Aug. 27, 2015, 7:04 nachm., Thomas Pfeiffer wrote: Since this is indeed a very often required feature, why do we keep it hidden? If it can have negative side-effects, it we should warn users about them, not hide the whole feature from them. or restricte to wayland? same process

Review Request 124956: Prevent the lockscreen password field from loosing focus

2015-08-27 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124956/ --- Review request for Plasma and David Edmundson. Repository:

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-08-27 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/#review84486 --- Since this is indeed a very often required feature, why do we

[Breeze] [Bug 351875] New: Some drop-down menus don't inherit the correct color value from Breeze-Dark theme.

2015-08-27 Thread Quiralta
https://bugs.kde.org/show_bug.cgi?id=351875 Bug ID: 351875 Summary: Some drop-down menus don't inherit the correct color value from Breeze-Dark theme. Product: Breeze Version: 5.4.0 Platform: Archlinux Packages

Re: Review Request 124956: Prevent the lockscreen password field from loosing focus

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124956/#review84505 --- The patch is at a wrong place: No matter what KAlarm does, it

Re: Review Request 124799: Add look and feel package for Breeze Dark theme.

2015-08-27 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124799/ --- (Updated Aug. 27, 2015, 7:19 p.m.) Status -- This change has been

Re: Review Request 124956: Prevent the lockscreen password field from loosing focus

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124956/#review84504 --- please put the patch on hold till my lockscreen related

Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/#review84451 --- ksmserver/screenlocker/greeter/greeterapp.cpp (line 140)

Re: Review Request 124948: [screenlocker] Render greeter backgrounds as black

2015-08-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124948/#review84454 --- Ship it! Ship It! - Marco Martin On Aug. 27, 2015, 8:48

Re: Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124933/ --- (Updated Aug. 27, 2015, 8:36 a.m.) Review request for Plasma. Changes

Re: Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter

2015-08-27 Thread Martin Gräßlin
On Aug. 26, 2015, 8:51 p.m., Kai Uwe Broulik wrote: Just place the anchors { horizontalCenter: parent.horizontalCenter bottom: parent.bottom } into the Loader to ensure the OSD is correctly positioned. I think the OSD should be loaded on demand,

Re: Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-27 Thread Martin Gräßlin
On Aug. 27, 2015, 12:01 p.m., Mark Gaiser wrote: ksmserver/screenlocker/greeter/greeterapp.cpp, line 140 https://git.reviewboard.kde.org/r/124947/diff/1/?file=399227#file399227line140 It might be nice to check if this pointer isn't 0 after the cast. Also, coding style.

Re: Review Request 124835: [client] Add a removed() signal to each class representing a global

2015-08-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124835/#review84466 --- Ship it! Ship It! - Sebastian Kügler On Aug. 20, 2015,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 148 - Fixed!

2015-08-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/148/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Aug 2015 11:10:05 + Build duration: 6 min 52 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 148 - Fixed!

2015-08-27 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/148/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Aug 2015 11:10:05 + Build duration: 6 min 52 sec CHANGE SET Revision

Re: Review Request 124835: [client] Add a removed() signal to each class representing a global

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124835/ --- (Updated Aug. 27, 2015, 11:35 a.m.) Status -- This change has been

Re: Review Request 124945: [panelconfiguration] Provide press feedback for Edge/SizeHandle

2015-08-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124945/#review84450 --- Ship it! Ship It! - Kai Uwe Broulik On Aug. 26, 2015,

Re: Review Request 124938: [panelconfiguration] Provide press feedback for Edge/SizeHandle

2015-08-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124938/ --- (Updated Aug. 27, 2015, 8:19 vorm.) Status -- This change has been

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-27 Thread Harald Sitter
On Aug. 25, 2015, 2:22 p.m., René J.V. Bertin wrote: When built as SHARED as in the current code, libdraganddropplugin.dylib gets installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given an OS X install_name of $PREFIX/lib/libdraganddropplugin.dylib. This mismatch can

Review Request 124948: [screenlocker] Render greeter backgrounds as black

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124948/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 124947: [screenlocker] Share QQmlEngine between all views in the greeter

2015-08-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124947/ --- Review request for Plasma and David Edmundson. Repository:

Review Request 124959: Shorten labels of QCheckBox so the accessibility kcm won't need a scrollbar.

2015-08-27 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124959/ --- Review request for Plasma. Bugs: 339407