Re: New activty switching plasmoid (bug 346684)

2015-09-03 Thread Ivan Čukić
Hi Tim, RB is more for patches than for complete (even little) projects. Do you want the applet to have a separate repository, or to be a part of kdeplasma-addons? Where is the code located now? Cheers, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76 __

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-03 Thread Samuel Gaist
> On Sept. 4, 2015, 6:03 a.m., Martin Gräßlin wrote: > > I'm missing an > > add_subdirectory(Darwin) > > > > otherwise I think the new CMakeLists would ever be found. It's already automatically handled by `add_subdirectory( ${CMAKE_SYSTEM_NAME} )` It's located just under the "SunOS" if - S

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125040/#review84806 --- I'm missing an add_subdirectory(Darwin) otherwise I think the

New activty switching plasmoid (bug 346684)

2015-09-03 Thread Tim Climis
Hi, This is my first time contributing, so I'm checking for procedural guidance. I have written an Activity Tray plasmoid as a compact activity switcher and I was told in the bug report to email this list. So here I am. :) I've been watching the list for a couple of days, and it looks like

Re: Review Request 125041: Move kaccess into separate source directory

2015-09-03 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125041/#review84804 --- Ship it! Ship It! - Jeremy Whiting On Sept. 3, 2015, 4:53

Review Request 125041: Move kaccess into separate source directory

2015-09-03 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125041/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-03 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125040/ --- Review request for Plasma. Repository: ksysguard Description --- T

Review Request 125038: Make SourceModel writeable

2015-09-03 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- Review request for Plasma. Repository: plasma-pa Description --- T

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-03 Thread David Edmundson
> On Sept. 3, 2015, 3:39 p.m., Martin Klapetek wrote: > > Have you tested this? Does the notification work with the zero timer? yes. I ran sudo timedatectl set-time 22:53 and watched the clock change and the debug appear. > On Sept. 3, 2015, 3:39 p.m., Martin Klapetek wrote: > > dataengines/t

Re: Review Request 125036: OSD type

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125036/ --- (Updated Sept. 3, 2015, 4:18 p.m.) Status -- This change has been ma

Re: Review Request 125036: OSD type

2015-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125036/#review84795 --- Ship it! Ship It! - Martin Gräßlin On Sept. 3, 2015, 6:09

Review Request 125036: OSD type

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125036/ --- Review request for kwin and Plasma. Repository: kwayland Description --

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/#review84792 --- Have you tested this? Does the notification work with the zero

Re: Review Request 125034: support for contrast protocol

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125034/ --- (Updated Sept. 3, 2015, 3:02 p.m.) Status -- This change has been ma

Re: Review Request 125035: support for contrast protocol

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125035/ --- (Updated Sept. 3, 2015, 3 p.m.) Status -- This change has been marke

Re: Review Request 125035: support for contrast protocol

2015-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125035/#review84794 --- Ship it! Ship It! - Martin Gräßlin On Sept. 3, 2015, 4:50

Re: Review Request 125034: support for contrast protocol

2015-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125034/#review84793 --- Ship it! Ship It! - Martin Gräßlin On Sept. 3, 2015, 4:49

Review Request 125035: support for contrast protocol

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125035/ --- Review request for kwin and Plasma. Repository: kwin Description --

Review Request 125034: support for contrast protocol

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125034/ --- Review request for kwin and Plasma. Repository: kwayland-integration De

Re: Review Request 124867: RTL support in login manager and lock screen

2015-09-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124867/ --- (Updated Sept. 3, 2015, 2:14 p.m.) Status -- This change has been ma

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/ --- (Updated Sept. 3, 2015, 2:12 p.m.) Status -- This change has been ma

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/#review84791 --- Ship it! Ship It! - Martin Gräßlin On Sept. 3, 2015, 3:58

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/ --- (Updated Sept. 3, 2015, 1:58 p.m.) Review request for kwin and Plasma.

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Thomas Lübking
> On Sept. 2, 2015, 4:30 nachm., Thomas Lübking wrote: > > I'll re-raise general concerns about the contrast effect. > > Why does it exist in the first place? > > > > https://bugs.kde.org/show_bug.cgi?id=337355#c12 > > Marco Martin wrote: > purely for the looks. it does look very different

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/#review84789 --- one more thing: please extend the registry autotest similar to

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/ --- (Updated Sept. 3, 2015, 1:13 p.m.) Review request for kwin and Plasma.

ISO for 2015-09-03

2015-09-03 Thread Harald Sitter
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist Earlier ISO as I am not around tomorrow. # changes - marble builds available # errata - iconloader changes broken icon loading in very peculiar ways. after first login on a new account the majority of icons are loaded from oxyge

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Marco Martin
> On Sept. 3, 2015, 11:12 a.m., Martin Gräßlin wrote: > > autotests/client/test_wayland_contrast.cpp, line 172 > > > > > > what do we do about the failing test? no idea, this fixed datatype seems tricky.. what d

Plasma 5.4.1 tars are up

2015-09-03 Thread Jonathan Riddell
Plasma 5.4.1 tars are up for packagers, due out on Tuesday https://www.kde.org/info/plasma-5.4.1.php Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125030/#review84787 --- autotests/client/test_wayland_contrast.cpp (line 172)

Re: Review Request 124945: [panelconfiguration] Provide press feedback for Edge/SizeHandle

2015-09-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124945/ --- (Updated Sept. 3, 2015, 10:23 a.m.) Status -- This change has been m

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-03 Thread Takahiro Hashimoto
> On 9月 3, 2015, 7:05 p.m., David Edmundson wrote: > > do you have commit access? No. - Takahiro --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review84783 -

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review84783 --- do you have commit access? - David Edmundson On Sept. 3, 20

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/ --- (Updated Sept. 3, 2015, 9:36 a.m.) Review request for Plasma. Repositor

Re: Review Request 125030: kwayland contrast protocol

2015-09-03 Thread Marco Martin
> On Sept. 2, 2015, 4:30 p.m., Thomas Lübking wrote: > > I'll re-raise general concerns about the contrast effect. > > Why does it exist in the first place? > > > > https://bugs.kde.org/show_bug.cgi?id=337355#c12 purely for the looks. it does look very different than a more opaque panel, even