Review Request 125053: Fix crash if trying to load an invalid applet in systray

2015-09-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125053/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-04 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125040/ --- (Updated Sept. 4, 2015, 9:40 p.m.) Status -- This change has been ma

Re: Review Request 125050: Fixed wrong path in cursor theme KCM

2015-09-04 Thread Ovidiu-Florin BOGDAN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125050/ --- (Updated Sept. 4, 2015, 9:54 p.m.) Status -- This change has been ma

Re: Review Request 125050: Fixed wrong path in cursor theme KCM

2015-09-04 Thread Ovidiu-Florin BOGDAN
> On Sept. 4, 2015, 9:44 p.m., David Edmundson wrote: > > patch looks good, but why are you in the else branch of > > if(X11_Xcursor_FOUND) > > > > ? > > > > You want to fix that on the packaging side rather than having this patch > > Ovidiu-Florin BOGDAN wrote: > I'm working on the baloo

Re: Review Request 125050: Fixed wrong path in cursor theme KCM

2015-09-04 Thread David Edmundson
> On Sept. 4, 2015, 6:44 p.m., David Edmundson wrote: > > patch looks good, but why are you in the else branch of > > if(X11_Xcursor_FOUND) > > > > ? > > > > You want to fix that on the packaging side rather than having this patch > > Ovidiu-Florin BOGDAN wrote: > I'm working on the baloo

Re: Review Request 125050: Fixed wrong path in cursor theme KCM

2015-09-04 Thread Ovidiu-Florin BOGDAN
> On Sept. 4, 2015, 9:44 p.m., David Edmundson wrote: > > patch looks good, but why are you in the else branch of > > if(X11_Xcursor_FOUND) > > > > ? > > > > You want to fix that on the packaging side rather than having this patch I'm working on the baloo KCM, and this stopped me from compilin

Re: Review Request 125050: Fixed wrong path in cursor theme KCM

2015-09-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125050/#review84846 --- Ship it! Ship It! - David Edmundson On Sept. 4, 2015, 6:42

Re: Review Request 125050: Fixed wrong path in cursor theme KCM

2015-09-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125050/#review84845 --- patch looks good, but why are you in the else branch of if(X11

Review Request 125050: Fixed wrong path in cursor theme KCM

2015-09-04 Thread Ovidiu-Florin BOGDAN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125050/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: New activty switching plasmoid (bug 346684)

2015-09-04 Thread Marco Martin
On Friday 04 September 2015 08:57:48 Ivan Čukić wrote: > Hi Tim, > > RB is more for patches than for complete (even little) projects. > > Do you want the applet to have a separate repository, or to be a part > of kdeplasma-addons? > > Where is the code located now? could be nice seeoing it in k

Re: Freeze kde-workspace repo for good

2015-09-04 Thread Marco Martin
On Friday 04 September 2015 15:45:46 Martin Graesslin wrote: > I want to reference this thread for sysadmin ticket, so please +1 quickly if > you agree or send a mail if you disagree. > > Cheers > Martin > > [1] https://git.reviewboard.kde.org/r/125043/ +1 -- Marco Martin _

Re: Freeze kde-workspace repo for good

2015-09-04 Thread Martin Klapetek
+1, although I don't think it would prevent people from creating patches...or would RB refuse a patch against those blocked branches? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailm

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-04 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125040/#review84825 --- Ship it! Ship It! - Martin Gräßlin On Sept. 4, 2015, 12:05

Re: Review Request 125040: Disable gui if the webkitwidgets module is not found

2015-09-04 Thread Martin Gräßlin
> On Sept. 4, 2015, 8:03 a.m., Martin Gräßlin wrote: > > I'm missing an > > add_subdirectory(Darwin) > > > > otherwise I think the new CMakeLists would ever be found. > > Samuel Gaist wrote: > It's already automatically handled by `add_subdirectory( > ${CMAKE_SYSTEM_NAME} )` > >

Freeze kde-workspace repo for good

2015-09-04 Thread Martin Graesslin
Hi all, given [1] I think it's time to let kde-workspace rest in peace. Thus I suggest that we ask sysadmin to block the repo for branches: * master * KDE/* * Plasma/* If we really want to push again to one of the branches our repo admins can still do so, but it prevents that people commit to

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-04 Thread Hans Chen
> On Aug. 27, 2015, 7:04 p.m., Thomas Pfeiffer wrote: > > Since this is indeed a very often required feature, why do we keep it > > hidden? If it can have negative side-effects, it we should warn users about > > them, not hide the whole feature from them. > > Thomas Lübking wrote: > or res

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-04 Thread Eike Hein
On 09/04/2015 09:31 AM, Takahiro Hashimoto wrote: > Should I apply developer account? Yup, let's get you on there. Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-04 Thread Takahiro Hashimoto
> On 9月 3, 2015, 7:05 p.m., David Edmundson wrote: > > do you have commit access? > > Takahiro Hashimoto wrote: > No. Should I apply developer account? - Takahiro --- This is an automatically generated e-mail. To reply, visit: http