Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/ --- (Updated Sept. 8, 2015, 6:57 a.m.) Status -- This change has been ma

Re: Review Request 125092: Add documentation about the library in a README.md

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125092/ --- (Updated Sept. 8, 2015, 6:44 a.m.) Status -- This change has been ma

Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/#review84989 --- Ship it! Ship It! - David Edmundson On Sept. 8, 2015, 4:09

Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread David Edmundson
> On Sept. 8, 2015, 6:34 a.m., David Edmundson wrote: > > src/declarativeimports/core/units.h, lines 41-42 > > > > > > size in which direction? > > Bhushan Shah wrote: > s/size of/width of/ > > If yo

Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread Bhushan Shah
> On Sept. 8, 2015, 12:04 p.m., David Edmundson wrote: > > src/declarativeimports/core/units.h, lines 41-42 > > > > > > size in which direction? s/size of/width of/ If you don't mind I will fix it when commiting

Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/#review84986 --- src/declarativeimports/core/units.h (lines 41 - 42)

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-07 Thread Martin Gräßlin
> On Sept. 7, 2015, 4:59 p.m., Thomas Lübking wrote: > > Hold it. > > > > Implementationwise, this looks wonky - if it's possible to get unbalanced > > input events (ie. releases w/o ever a press or vv.) from the system since > > the counter will run out of sync. > > > > => Are such unbalance

Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/ --- Review request for Plasma and Marco Martin. Repository: plasma-framework

Re: New activty switching plasmoid (bug 346684)

2015-09-07 Thread Tim Climis
On Friday, September 04, 2015 05:49:09 PM Marco Martin wrote: > On Friday 04 September 2015 08:57:48 Ivan Čukić wrote: > > Hi Tim, > > > > RB is more for patches than for complete (even little) projects. > > > > Do you want the applet to have a separate repository, or to be a part > > of kdeplasm

Re: Review Request 124986: [System Tray] Bring back shortcuts configuration

2015-09-07 Thread Thomas Pfeiffer
> On Aug. 30, 2015, 2:10 p.m., Thomas Pfeiffer wrote: > > Usability-wise it's fine. > > Visually, the clear buttons for the shortcuts should be right-aligned > > Kai Uwe Broulik wrote: > They are? Or what are you referring to? > > David Edmundson wrote: > @Thomas, FYI if you click on th

Re: Review Request 125091: Speedup finding the property change signals

2015-09-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125091/#review84978 --- Ship it! Ship It! - Sebastian Kügler On Sept. 7, 2015, 2:0

Re: Review Request 125092: Add documentation about the library in a README.md

2015-09-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125092/#review84977 --- Ship it! Ship It! - Sebastian Kügler On Sept. 7, 2015, 3:2

Re: Review Request 124472: WIP: Implement drag and drop support for icon widget

2015-09-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124472/ --- (Updated Sept. 7, 2015, 6:55 nachm.) Review request for Plasma and Bhusha

Re: Review Request 124114: Add "Lock Screen" to desktop toolbox

2015-09-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124114/ --- (Updated Sept. 7, 2015, 6:32 p.m.) Status -- This change has been ma

Re: Review Request 125092: Add documentation about the library in a README.md

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125092/#review84961 --- # KWayland KWayland is a Qt-style API to interact with the wa

Review Request 125092: Add documentation about the library in a README.md

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125092/ --- Review request for Plasma, Marco Martin and Sebastian Kügler. Repository:

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-07 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/#review84959 --- Hold it. Implementationwise, this looks wonky - if it's possi

Re: Review Request 124954: Add support for modifier only shortcuts on Wayland

2015-09-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124954/#review84957 --- Ship it! Ship It! - Sebastian Kügler On Aug. 27, 2015, 4:0

Re: Review Request 125018: Support for Dpms

2015-09-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125018/#review84952 --- Ship it! Only minor things. Looking good otherwise. src/cli

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-07 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/#review84954 --- Ship it! dataengines/time/timeengine.cpp (line 27)

Review Request 125091: Speedup finding the property change signals

2015-09-07 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125091/ --- Review request for Plasma. Repository: plasma-pa Description --- W

Re: Review Request 125088: Allow to change volume with mouse wheel

2015-09-07 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/#review84949 --- I'm not sure whether we should enable scrolling in the applet

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- (Updated Sept. 7, 2015, 3:13 p.m.) Review request for Plasma and Harald S

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
> On Sept. 7, 2015, 8:40 a.m., David Edmundson wrote: > > src/pulseaudio.cpp, line 379 > > > > > > int QMetaObject::indexOfSignal(const char * signal) const > > > > rather than looping I will also chang

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- (Updated Sept. 7, 2015, 2:11 p.m.) Review request for Plasma and Harald S

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/ --- (Updated Sept. 7, 2015, 12:10 p.m.) Review request for Plasma. Reposito

Review Request 125089: Fix changing volume with horizontal scroll

2015-09-07 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125089/ --- Review request for Plasma and Harald Sitter. Repository: plasma-pa Desc

Minutes Monday Plasma Hangout

2015-09-07 Thread Sebastian Kügler
Present: Martin G., Bhushan, Ovidiu-Florin, Vishesh, Sebastian Date: 7 September, 2015 Martin: - Working on tool to generate wrappers for wayland protocols in kwayland, almost complete - Working on DPMS - libinput now runs in a thread and compresses events - Would like feedback on the metashortc

Review Request 125088: Allow to change volume with mouse wheel

2015-09-07 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/ --- Review request for Plasma and Harald Sitter. Repository: plasma-pa Desc

Re: Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR

2015-09-07 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123190/ --- (Updated Sept. 7, 2015, 9:10 a.m.) Status -- This change has been ma

Re: Oxygen icons

2015-09-07 Thread David Edmundson
> 4. I need your go for it Go for it Other oxygen icon thread on kde-devel says: >Of course if there's still an important commit or bugfix done we can release a new version separately, but i think it makes sense to save the internet around 200M for every version that virtually changes nothing.

Re: Review Request 125085: [applets/pager] Remove show dashboard option

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125085/ --- (Updated Sept. 7, 2015, 7:29 a.m.) Status -- This change has been ma

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

2015-09-07 Thread David Faure
> On Sept. 7, 2015, 7:25 a.m., David Faure wrote: > > There's no need to call aliases() at all, trader queries (and in fact > > ksycoca already) do resolve aliases. And since you're calling this for one URL at a time, you don't need KFileItemActions, just do const KService::List apps = KMimeT

Re: Review Request 123779: Include the mimetype itself when querying for KFileItemActions::associatedApplications

2015-09-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123779/#review84938 --- There's no need to call aliases() at all, trader queries (and

Re: Review Request 125085: [applets/pager] Remove show dashboard option

2015-09-07 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125085/#review84936 --- Ship it! Ship It! - Bhushan Shah On Sept. 7, 2015, 12:37 p

Re: Review Request 125085: [applets/pager] Remove show dashboard option

2015-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125085/#review84935 --- Ship it! Ship It! - David Edmundson On Sept. 7, 2015, 7:07

Review Request 125085: [applets/pager] Remove show dashboard option

2015-09-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125085/ --- Review request for Plasma. Repository: plasma-desktop Description -