Re: Review Request 125200: Don't overflow action buttons in notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125200/#review85273 --- The text is elided in the Plasma button style, but it has to

Re: Review Request 125019: [kicker] make dashboard icon size scalable

> On 9月 13, 2015, 5:07 a.m., Eike Hein wrote: > > I currently don't want to make this configurable because I want to retain > > control over how Dashboard is presented to users and not allow it to be > > configured to a state that looks bad (this is a corner we've painted > > ourselves into

Re: Review Request 125019: [kicker] make dashboard icon size scalable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/ --- (Updated 9月 13, 2015, 8:30 a.m.) Status -- This change has been

Re: Review Request 125193: Set tooltip icon in notifications applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125193/#review85271 --- I thought the tooltip icon was automatically the one of the

Re: Review Request 125193: Set tooltip icon in notifications applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125193/ --- (Updated Sept. 12, 2015, 7:37 p.m.) Review request for Plasma and

Re: Review Request 125193: Set tooltip icon in notifications applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125193/#review85276 --- Ship it! Ship It! - Kai Uwe Broulik On Sept. 12, 2015,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 174 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/174/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 20:43:52 + Build duration: 2 min 9 sec CHANGE SET Revision

Re: Review Request 125196: Adjust notification count label text size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125196/ --- (Updated Sept. 12, 2015, 8:43 p.m.) Status -- This change has been

Re: Review Request 125200: Don't overflow action buttons in notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125200/#review85269 --- Ship it! There's a bug report somewhere which you should

Re: Review Request 125196: Adjust notification count label text size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125196/#review85280 --- Ship it! Ship It! - andreas kainz On Sept. 12, 2015, 3:26

Re: Review Request 125019: [kicker] make dashboard icon size scalable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/#review85277 --- I currently don't want to make this configurable because I

Re: Review Request 125207: Make more tests for button with descriptions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125207/#review85284 --- It is my patch :D But I'm glad the patch is correct. - David

Re: Review Request 125198: by default do not restore the previous session on next login

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/#review85293 --- I turn it off for my own machines. So +1 from me. - David

Review Request 125201: Fix eliding button text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125201/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 125201: Fix eliding button text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125201/ --- (Updated Sept. 12, 2015, 8:50 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 22 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 20:43:52 + Build duration: 5 min 15 sec CHANGE SET Revision

Re: Review Request 125200: Don't overflow action buttons in notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125200/ --- (Updated Sept. 12, 2015, 6:10 p.m.) Review request for Plasma. Changes

Re: Review Request 125196: Adjust notification count label text size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125196/#review85279 --- +1 - Kai Uwe Broulik On Sept. 12, 2015, 3:26 nachm., David

Re: Review Request 125207: Make more tests for button with descriptions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125207/ --- (Updated Sept. 12, 2015, 8:40 p.m.) Status -- This change has been

Re: Review Request 125207: Make more tests for button with descriptions

> On Sept. 12, 2015, 8:34 p.m., David Rosca wrote: > > It is my patch :D But I'm glad the patch is correct. Ooops sorry! Too many David's. - David --- This is an automatically generated e-mail. To reply, visit:

Review Request 125200: Don't overflow action buttons in notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125200/ --- Review request for Plasma. Repository: plasma-workspace Description

[kwrited] [Bug 351665] KDE shown hidden menu items available but not openable

https://bugs.kde.org/show_bug.cgi?id=351665 --- Comment #5 from Nick Levinson --- This is for consideration for future versions if applicable, given that this one is closed to bug fixes. Enter should be supported. I think it's common. I tested it (after the last post

Re: Review Request 125201: Fix eliding button text

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125201/#review85281 --- Ship it! Ship It! - David Edmundson On Sept. 12, 2015,

Re: Review Request 125207: Make more tests for button with descriptions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125207/#review85285 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 12, 2015,

Re: Review Request 125198: by default do not restore the previous session on next login

> On Sept. 12, 2015, 9:25 p.m., Kai Uwe Broulik wrote: > > Same for me. +1 > > OS X has a check box on the logout dialog, perhaps we could have something > > similar to make thmore discoverable Oooh! I like that idea a lot. It can default to what the user last set it to. - David

Re: Review Request 125200: Don't overflow action buttons in notification

> On Sept. 12, 2015, 9:29 p.m., Martin Klapetek wrote: > > The text is elided in the Plasma button style, but it has to do with the > > width computation in the style, I'm not sure exactly, but my guess is line > > 115, the "Math.max(theme.mSize(theme.defaultFont).width*12, > >

Review Request 125207: Make more tests for button with descriptions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125207/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 125193: Set tooltip icon in notifications applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125193/ --- (Updated Sept. 12, 2015, 8:43 p.m.) Status -- This change has been

Re: Review Request 125200: Don't overflow action buttons in notification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125200/ --- (Updated Sept. 12, 2015, 8:43 p.m.) Status -- This change has been

Re: Review Request 125198: by default do not restore the previous session on next login

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/#review85295 --- Same for me. +1 OS X has a check box on the logout dialog,

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

> On 9月 3, 2015, 12:41 a.m., Aleix Pol Gonzalez wrote: > > Good stuff! > > > > +1 Thanks Aleix:) Could I have more comments from any other guys? :) - Takahiro --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 125019: [kicker] make dashboard icon size scalable

> On 9月 13, 2015, 5:07 a.m., Eike Hein wrote: > > I currently don't want to make this configurable because I want to retain > > control over how Dashboard is presented to users and not allow it to be > > configured to a state that looks bad (this is a corner we've painted > > ourselves into

Re: Review Request 125174: Plasma 5 Quicklaunch applet

> On Sept. 12, 2015, 12:42 a.m., Martin Klapetek wrote: > > Is there any disadvantage to using Icon-only task manager and adding > > launchers in there? It seems like this applet would do exactly the same > > minus the task switching, so perhaps some portions of the code could be > > shared?

Re: Review Request 125187: Stop requiring Frameworks 5.15

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85240 --- We depend on git master of frameworks in Plasma master quite

Re: Review Request 125189: Fix loading of the configured cursor theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125189/#review85243 --- Ship it! Ship It! - David Edmundson On Sept. 12, 2015,

Review Request 125190: Daemonize the forked kwalletd process.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/ --- Review request for Plasma and Àlex Fiestas. Repository: kwallet-pam

Re: Review Request 125190: Daemonize the forked kwalletd process.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/ --- (Updated Sept. 12, 2015, 10:35 a.m.) Review request for Plasma and Àlex

Review Request 125187: Stop requiring Frameworks 5.15

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/ --- Review request for Plasma and David Faure. Repository: plasma-workspace

Re: Review Request 125187: Stop requiring Frameworks 5.15

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85238 --- Ship it! Ship It! - David Faure On Sept. 12, 2015, 9:38

Review Request 125189: Fix loading of the configured cursor theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125189/ --- Review request for Plasma and David Edmundson. Bugs: 344592

Re: Review Request 125190: Daemonize the forked kwalletd process.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/ --- (Updated Sept. 12, 2015, 10:37 a.m.) Review request for Plasma, Àlex

Re: Review Request 125189: Fix loading of the configured cursor theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125189/ --- (Updated Sept. 12, 2015, 11:16 a.m.) Status -- This change has been

Review Request 125191: Allow to set minimum user id lower than 1000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125191/ --- Review request for Plasma and David Edmundson. Bugs: 347942

Review Request 125198: by default do not restore the previous session on next login

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125199/ --- Review request for Plasma. Repository: plasma-desktop Description

Review Request 125193: Set tooltip icon in notifications applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125193/ --- Review request for Plasma. Repository: plasma-workspace Description

Review Request 125196: Adjust notification count label text size

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125196/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125198: by default do not restore the previous session on next login

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/ --- (Updated Sept. 12, 2015, 3:37 p.m.) Review request for Plasma.

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125199/ --- (Updated Sept. 12, 2015, 3:36 p.m.) Review request for Plasma. Changes

Re: Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125171/ --- (Updated Sept. 12, 2015, 4:08 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 21 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 13:57:38 + Build duration: 6 min 10 sec CHANGE SET Revision

Re: Review Request 125191: Allow to set minimum user id lower than 1000

> On Sept. 12, 2015, 1:41 nachm., David Edmundson wrote: > > Making it 1 might be better. > > SDDM has some checks to check if you're trying to login as root and quit. Are you sure? Logging in as root works fine here with SDDM 0.12.0 (if I set MinimumUid=0 in sddm.conf). I just tried. -

Re: Review Request 125191: Allow to set minimum user id lower than 1000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125191/ --- (Updated Sept. 12, 2015, 1:10 p.m.) Status -- This change has been

Re: Review Request 125191: Allow to set minimum user id lower than 1000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125191/#review85249 --- Making it 1 might be better. SDDM has some checks to check if

Re: Review Request 125191: Allow to set minimum user id lower than 1000

> On Sept. 12, 2015, 1:41 nachm., David Edmundson wrote: > > src/advanceconfig.cpp, line 33 > > > > > > then change / remove this? Well, this is also used as default value for the setting, see line 81. -

Re: Review Request 125191: Allow to set minimum user id lower than 1000

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125191/#review85252 --- Ship it! Ship It! - David Edmundson On Sept. 12, 2015,

Review Request 125195: Update the GTK icon cache when installing.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125195/ --- Review request for Plasma and Olivier Goffart. Repository: breeze

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 173 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Sep 2015 11:54:27 + Build duration: 1 min 25 sec CHANGE SET Revision