[Breeze] [Bug 352610] root apps use oxygen icons and widget style

2015-10-13 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=352610 Harald Sitter changed: What|Removed |Added Target Milestone|1.0 |--- Assignee|k...@davidedmundson.co.u

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/ --- (Updated Oct. 13, 2015, 8:58 p.m.) Review request for Plasma, David Edmun

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/ --- (Updated Oct. 13, 2015, 8:45 p.m.) Review request for Plasma, David Edmun

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/ --- (Updated Oct. 13, 2015, 8:43 p.m.) Review request for Plasma, David Edmun

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Ivan Čukić
> On Oct. 13, 2015, 6:49 p.m., Thomas Pfeiffer wrote: > > Great improvement overall! > > Two things: > > 1. The semantic of the button for stoping an Activity (close) does not > > correspond with "stop". Either they should be renamed to "Closed", or the > > icon should be changed to the one for

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Ivan Čukić
> On Oct. 13, 2015, 6:01 p.m., David Edmundson wrote: > > desktoppackage/contents/activitymanager/StoppedActivityItem.qml, line 47 > > > > > > what's this +4 for? It has single padding now - Ivan

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread andreas kainz
> On Okt. 13, 2015, 6:49 nachm., Thomas Pfeiffer wrote: > > Great improvement overall! > > Two things: > > 1. The semantic of the button for stoping an Activity (close) does not > > correspond with "stop". Either they should be renamed to "Closed", or the > > icon should be changed to the one f

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Ivan Čukić
> On Oct. 13, 2015, 6:49 p.m., Thomas Pfeiffer wrote: > > Great improvement overall! > > Two things: > > 1. The semantic of the button for stoping an Activity (close) does not > > correspond with "stop". Either they should be renamed to "Closed", or the > > icon should be changed to the one for

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/#review86819 --- Great improvement overall! Two things: 1. The semantic of the

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Marco Martin
> On Oct. 13, 2015, 6:40 p.m., Ivan Čukić wrote: > > desktoppackage/contents/activitymanager/StoppedActivityItem.qml, line 47 > > > > > > Double smallSpacing on top and bottom. Yes, it is a bit... but it looks >

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/#review86817 --- desktoppackage/contents/activitymanager/ActivityItem.qml (lin

Re: Review Request 125625: digitalclock: Use Text.HorizontalFit for date label in vertical panel

2015-10-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125625/#review86816 --- Thanks for that. Can you please check what happens if you drag

Re: Review Request 125626: New activity switcher UI

2015-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/#review86815 --- desktoppackage/contents/activitymanager/ActivityItem.qml (lin

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 219 - Still Failing!

2015-10-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/219/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Oct 2015 17:48:49 + Build duration: 12 min CHANGE SET Revision 3df21c1502488f752fa95da6b12fca9145d8e

Re: Review Request 125589: [Task Manager] Align context menu to task item

2015-10-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125589/ --- (Updated Oct. 13, 2015, 5:48 p.m.) Status -- This change has been ma

Review Request 125626: New activity switcher UI

2015-10-13 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/ --- Review request for Plasma, David Edmundson and Marco Martin. Repository:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 218 - Failure!

2015-10-13 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/218/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 13 Oct 2015 17:17:14 + Build duration: 12 min CHANGE SET Revision f41fa66fed69a088f4e6fd9bec387952540fd

Re: Review Request 125622: Use better guard against recursion when changing volume with sliders

2015-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125622/#review86814 --- Ship it! Ship It! - David Edmundson On Oct. 13, 2015, 3:21

Review Request 125625: digitalclock: Use Text.HorizontalFit for date label in vertical panel

2015-10-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125625/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 125622: Use better guard against recursion when changing volume with sliders

2015-10-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125622/ --- Review request for Plasma. Repository: plasma-pa Description --- A

Re: Review Request 125014: Rotate wallpaper based on image EXIF

2015-10-13 Thread Aleix Pol Gonzalez
> On Oct. 13, 2015, 4:32 p.m., Marco Martin wrote: > > All for it even tough i think i would prefer having the version bump > > associated to using new C++ api as well, so that we are sure on 5.4 it > > wouldn't build, not silently fail > > Marco Martin wrote: > but even with just the cmak

Re: Review Request 125014: Rotate wallpaper based on image EXIF

2015-10-13 Thread Marco Martin
> On Oct. 13, 2015, 2:32 p.m., Marco Martin wrote: > > All for it even tough i think i would prefer having the version bump > > associated to using new C++ api as well, so that we are sure on 5.4 it > > wouldn't build, not silently fail but even with just the cmake check is hopefully enough

Re: Review Request 125014: Rotate wallpaper based on image EXIF

2015-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125014/#review86809 --- Ship it! All for it even tough i think i would prefer having

Re: Review Request 125014: Rotate wallpaper based on image EXIF

2015-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125014/ --- (Updated Oct. 13, 2015, 2:28 p.m.) Review request for Plasma. Bugs: 352

Re: Review Request 125558: Allow look and feel packages to specify default configs for applets

2015-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125558/ --- (Updated Oct. 13, 2015, 12:44 p.m.) Status -- This change has been d

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125562/ --- (Updated Oct. 13, 2015, 12:31 p.m.) Status -- This change has been m

Re: Review Request 125569: introduce appletCreated signal

2015-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125569/ --- (Updated Oct. 13, 2015, 12:27 p.m.) Status -- This change has been m

Re: SoK Plasmoids

2015-10-13 Thread Bhushan Shah
Hi, On Sat, Oct 10, 2015 at 4:29 PM, kainz.a wrote: > I will do some Mentor tasks for Season of KDE. Most tasks will be > design (icon) stuff. But I would like to make some plasmoid tasks, BUT > I can't be the only Mentor for this. So if someone will support me it > would be great. In addition I'

Re: Review Request 125569: introduce appletCreated signal

2015-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125569/#review86803 --- Ship it! - David Edmundson On Oct. 9, 2015, 3:02 p.m., Marc

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125562/#review86802 --- Ship it! Ship It! - David Edmundson On Oct. 13, 2015, 11:1

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125568/#review86801 --- I tried the script on some elements, doesn't work with all of

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125562/ --- (Updated Oct. 13, 2015, 11:10 a.m.) Review request for Plasma and Eike He

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125562/ --- (Updated Oct. 13, 2015, 11:08 a.m.) Review request for Plasma and Eike He

[Breeze] [Bug 352510] Wifi Icons (Airplane Mode, Wifi) Doesn't display sometimes in network menu in menu bar

2015-10-13 Thread Jan Grulich
https://bugs.kde.org/show_bug.cgi?id=352510 Jan Grulich changed: What|Removed |Added Assignee|lu...@kde.org |plasma-devel@kde.org Product|plasma-nm

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-13 Thread David Kahles
> On Okt. 13, 2015, 1:08 vorm., David Edmundson wrote: > > src/kcm/package/contents/ui/VolumeSlider.qml, line 86 > > > > > > I don't understand what this line is doing > > > > if we do block wheel events

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/ --- (Updated Oct. 13, 2015, 9:50 a.m.) Status -- This change has been ma

Re: Review Request 125089: Fix changing volume with scrolling on high resolution touchpad

2015-10-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125089/ --- (Updated Oct. 13, 2015, 9:50 a.m.) Status -- This change has been ma

Re: HIG and components API

2015-10-13 Thread Marco Martin
On Monday 12 October 2015, Thomas Pfeiffer wrote: > We've been talking to Michael Spencer, one of the main driving forces > behind those components, about how we can collaborate (he seems quite > positive about the idea!). > If you see any areas where direct collaboration could make sense, speak up

Re: Review Request 125089: Fix changing volume with scrolling on high resolution touchpad

2015-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125089/#review86795 --- Ship it! Ship It! - David Edmundson On Oct. 12, 2015, 4:27

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/#review86794 --- src/kcm/package/contents/ui/VolumeSlider.qml (line 64)

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/#review86793 --- Ship it! Ship It! - David Edmundson On Oct. 12, 2015, 5:06

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-13 Thread David Rosca
> On Oct. 12, 2015, 11:08 p.m., David Edmundson wrote: > > applet/contents/ui/ListItemBase.qml, line 203 > > > > > > why don't we have all the PendingWheelEvent stuff here? Because in applet the wheel scrolling