Review Request 125666: Add Spectacle to KHotkeys, disable the existing printscreen.khotkeys file

2015-10-16 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125666/ --- Review request for Plasma, Martin Gräßlin and Jeremy Whiting. Repository:

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-16 Thread Uri Herrera
> On Oct. 13, 2015, 12:12 p.m., Marco Martin wrote: > > I tried the script on some elements, doesn't work with all of the svgs but > > the result seems pretty good, > > here is the theme with the questionable "wonton soup" color theme > > http://imgur.com/g5tsNs6 > > > > so it seems feasible, m

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin
> On Oct. 16, 2015, 3:14 p.m., Andrew Lake wrote: > > Is it fair to interpret this as a possible path to reducing the duplication > > of icons between the main icon theme and the plasma theme? yes, I want to keep some main ones in the plasma theme as some icons are actually composed from multi

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread David Edmundson
> On Oct. 16, 2015, 8:24 p.m., Martin Gräßlin wrote: > > did you try whether the proxy works without compositing? I just hit the > > "suspend compositing" global shortcut to test something and it gave me bad > > rendering results in the davetray area. I have. For me it works (for most clients

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review86935 --- did you try whether the proxy works without compositing? I jus

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-10-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review86933 --- Ship it! Good stuff. You can fix those and push directly. d

Re: Review Request 125626: New activity switcher UI

2015-10-16 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/ --- (Updated Oct. 16, 2015, 5:15 p.m.) Status -- This change has been ma

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/#review86932 --- src/declarativeimports/core/iconitem.cpp (line 342)

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

2015-10-16 Thread Jeremy Whiting
> On Oct. 16, 2015, 9:58 a.m., Martin Klapetek wrote: > > Screenshots? ;) Ok, added a screenshot with breeze dark theme, The colors look ok, but I guess Plasma::Dialog may have done some rounded corners or something iirc to make it look a bit better or added transparency or something. - Jere

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

2015-10-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/ --- (Updated Oct. 16, 2015, 10:04 a.m.) Review request for Plasma and Martin

Re: Review Request 125662: mangonel: Initial port to Qt5/KF5

2015-10-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/#review86929 --- Screenshots? ;) - Martin Klapetek On Oct. 16, 2015, 5:42 p.

Review Request 125662: mangonel: Initial port to Qt5/KF5

2015-10-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/ --- Review request for Plasma and Martin Tobias Holmedahl Sandsmark. Reposito

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/#review86927 --- Is it fair to interpret this as a possible path to reducing th

Re: Not able to install on my Nexus 5

2015-10-16 Thread Jonathan Riddell
> 3. After removing these flags (I'm not sure if removing these two flags is > right, but does nothing until removed), starts downloading, but after a few > percentage gets out and says, " unexpected EOF". Try using my mirror by changing the URLs in the command to http://mobile.edinburghlinux.co.

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/ --- (Updated Oct. 16, 2015, 2:48 p.m.) Review request for Plasma. Repositor

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin
> On Oct. 16, 2015, 1:19 p.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, lines 341-348 > > > > > > it looks like you already do all this on line 142 of this diff. yeah, this is due the

Re: Review Request 125660: Use PlasmaCore.IconItem in desktop toolbox

2015-10-16 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125660/ --- (Updated Oct. 16, 2015, 2:43 p.m.) Status -- This change has been ma

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread David Rosca
> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? > > David Edmundson wrote: > ah yes, forgot to finish that > > Does anyone have a mouse

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread David Rosca
> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? > > David Edmundson wrote: > ah yes, forgot to finish that > > Does anyone have a mouse

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 214 - Fixed!

2015-10-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Oct 2015 14:18:48 + Build duration: 7 min 45 sec CHANGE SET Revision 44fb5c45abc05a8bbc19d6fe65b6c

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 214 - Fixed!

2015-10-16 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/214/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Oct 2015 14:18:48 + Build duration: 7 min 45 sec CHANGE SET Revision 44fb5c45abc05a8bbc19d6fe65b6c

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread David Edmundson
> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? > > David Edmundson wrote: > ah yes, forgot to finish that > > Does anyone have a mouse

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread Marco Martin
> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? > > David Edmundson wrote: > ah yes, forgot to finish that > > Does anyone have a mouse

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/#review86922 --- src/declarativeimports/core/iconitem.cpp (line 144)

Re: Review Request 125654: Use shared engine in ksplashqml

2015-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125654/ --- (Updated Oct. 16, 2015, 2:18 p.m.) Status -- This change has been ma

Re: Review Request 125660: Use PlasmaCore.IconItem in desktop toolbox

2015-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125660/#review86921 --- Ship it! Ship It! - David Edmundson On Oct. 16, 2015, 2:16

Review Request 125660: Use PlasmaCore.IconItem in desktop toolbox

2015-10-16 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125660/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread David Edmundson
> On Oct. 16, 2015, 1:59 p.m., Marco Martin wrote: > > xembedsniproxy/sniproxy.cpp, line 274 > > > > > > else? ah yes, forgot to finish that Does anyone have a mouse with a horizontal scroll? If so can you open

Re: Review Request 125307: Add option for desktoptheme to set preferred icon theme

2015-10-16 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125307/ --- (Updated Oct. 16, 2015, 2:07 p.m.) Status -- This change has been di

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review86919 --- finally :D xembedsniproxy/sniproxy.cpp (line 223)

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/ --- (Updated Oct. 16, 2015, 1:26 p.m.) Review request for Plasma. Repositor

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread Marco Martin
> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/sniproxy.h, lines 42-50 > > > > > > hmm? > > David Edmundson wrote: > ah right, I need some advice on here. > > There are pro

Re: Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/#review86916 --- src/declarativeimports/core/iconitem.cpp (line 134)

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread Martin Gräßlin
> On Oct. 16, 2015, 2:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/CMakeLists.txt, line 50 > > > > > > are you sure you want -Wall. The last project I tried to build with > > that flag was unbuildable. > >

Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

2015-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125657/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread David Edmundson
> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote: > > xembedsniproxy/sniproxy.h, lines 42-50 > > > > > > hmm? ah right, I need some advice on here. There are properties that exist in the SNI spec that I can

Re: Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/#review86912 --- Overall looks good! General comments: * please use KSelectionO

Re: Qt 5.5

2015-10-16 Thread Jonathan Riddell
build.kde.org has qt 5.5 from 18 september, there are build failures since then https://build.kde.org/view/QT/job/qt5%205.5%20kf5-qt5/ Harald says he was able to do builds on Kubuntu CI of 5.5 so we should have that next week. I'll ask other distros if they have any problems Jonathan On Th

Re: Qt 5.5

2015-10-16 Thread David Edmundson
​The build.k.o failure: *18:19:49* fatal error: error writing to /tmp/ccTA71Ud.s: No space left on device David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125655: Xembed SNI Proxy

2015-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125655/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125654: Use shared engine in ksplashqml

2015-10-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125654/#review86910 --- Ship it! +2 for sharing the engine - Marco Martin On Oct.

Re: Review Request 125654: Use shared engine in ksplashqml

2015-10-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125654/#review86909 --- +1, looks good to me ksplash/ksplashqml/splashapp.cpp (line

[Powerdevil] [Bug 351693] Screen brightness is not restored after screen unlock (idle time)

2015-10-16 Thread Fabrizio Ruggeri via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=351693 --- Comment #2 from Fabrizio Ruggeri --- Kubuntu 15.04 Kde platform version 4.14.8 Kde plasma version 5.3.2 Qt version 5.4.1 Kernel: 3.19.0-30-generic (64bit) -- You are receiving this mail because: You are the assignee for the bug. __

Review Request 125654: Use shared engine in ksplashqml

2015-10-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125654/ --- Review request for Plasma. Repository: plasma-workspace Description ---

[Powerdevil] [Bug 351693] Screen brightness is not restored after screen unlock (idle time)

2015-10-16 Thread Fabrizio Ruggeri via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=351693 Fabrizio Ruggeri changed: What|Removed |Added CC||fabrizio.rugg...@gmail.com --- Comment #1 fr

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-16 Thread Marco Martin
> On Oct. 13, 2015, 12:12 p.m., Marco Martin wrote: > > I tried the script on some elements, doesn't work with all of the svgs but > > the result seems pretty good, > > here is the theme with the questionable "wonton soup" color theme > > http://imgur.com/g5tsNs6 > > > > so it seems feasible, m

Re: HIG and components API

2015-10-16 Thread Marco Martin
On Thursday 08 October 2015 18:18:24 Thomas Pfeiffer wrote: > Another thing about the context drawer: > Would it be possible to center the list of actions vertically so that it's > easier to reach with the thumb (at least if it has only a few actions)? Another question about the context view: do y