Re: Review Request 126544: [Kickoff] Hide history tab if empty

> On Dez. 28, 2015, 2:02 nachm., Aleix Pol Gonzalez wrote: > > Maybe show it as disabled at least? It's weird that UI structure change > > every now and then. > > Heiko Tietze wrote: > I agree with the idea to avoid changing UI structure. However, to disable > isn't good for tabs. >

Re: Review Request 126544: [Kickoff] Hide history tab if empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/ --- (Updated Dez. 28, 2015, 8:56 nachm.) Status -- This change has been

Review Request 126551: [Service Runner] WIP: Add support for Jump List Actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126551/ --- Review request for Plasma and Vishesh Handa. Repository:

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/#review90193 --- Did you try if particular options are used, like a different

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

> On Dec. 27, 2015, 4:54 p.m., Kai Uwe Broulik wrote: > > desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml, > > line 106 > > > > > > You didn't specify a width, ie. there'll be no

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

> On Dec. 26, 2015, 11:51 p.m., Ivan Čukić wrote: > > I have mixed feelings about this one. (to oppose those that are against it, > > and those that are for it) > > > > I like the picture. It would be awesome as a background for some > > kde-plasma-related brochures, videos etc. > > > > I'm

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/ --- (Updated Dec. 28, 2015, 9:58 a.m.) Review request for Plasma.

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/ --- (Updated Dec. 28, 2015, 9:59 a.m.) Review request for Plasma.

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126499/#review90197 --- Ship it! I prefer having the message inline under the

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/ --- (Updated Dec. 28, 2015, 11:37 a.m.) Status -- This change has been

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review90201 --- What about just adding a property to disable animation (as

Re: Review Request 126499: Add explanatory message why layout combo is disabled whilst widgets are locked

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126499/ --- (Updated Dec. 28, 2015, 11:31 a.m.) Status -- This change has been

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 28, 2015, 9:37 a.m.) Review request for Build System, KDE

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126538/#review90204 --- Ship it! Ship It! - Marco Martin On Dec. 28, 2015, 9:59

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 350 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/350/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 11:37:46 + Build duration: 5 min 5 sec CHANGE SET Revision

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126319/#review90192 --- Ship it! so, let's go with the last one? for me +1, any

Re: Review Request 126514: [Milou/KRunner] Support runner actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126514/#review90199 --- +1 from me lib/qml/ResultDelegate.qml (line 142)

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

> On Dec. 28, 2015, 2:42 a.m., David Edmundson wrote: > > shell/main.cpp, line 97 > > > > > > oh, I probably want to keep this and set the flag as appropriate. Yep it is useful. - Bhushan

Re: Review Request 126538: Don't duplicate a tonne of KCrash code

> On Dec. 28, 2015, 9:20 a.m., Marco Martin wrote: > > Did you try if particular options are used, like a different shell, > > plasmashell gets restarted with the same ones, same shell plugin? It does. - David --- This is an

Re: Review Request 126514: [Milou/KRunner] Support runner actions

> On Dez. 28, 2015, 2:19 nachm., Marco Martin wrote: > > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand > > QIcons as it uses IconItem internally > > Kai Uwe Broulik wrote: > Yes, but iconSource property of QQC Button is of "url" type. > > Kai Uwe Broulik wrote: >

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

> On Dez. 27, 2015, 6:24 nachm., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is

Jenkins-kde-ci: oxygen Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 12:31:07 + Build duration: 2 min 18 sec CHANGE SET Revision

Re: Review Request 126544: [Kickoff] Hide history tab if empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/#review90210 --- Maybe show it as disabled at least? It's weird that UI

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Dec. 28, 2015, 2:09 p.m.) Status -- This change has been

Re: Review Request 126514: [Milou/KRunner] Support runner actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126514/ --- (Updated Dez. 28, 2015, 12:33 nachm.) Review request for Plasma, KDE

Re: Review Request 126544: [Kickoff] Hide history tab if empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/ --- (Updated Dez. 28, 2015, 2:01 nachm.) Review request for Plasma, KDE

Re: Review Request 126514: [Milou/KRunner] Support runner actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126514/#review90212 --- hmm, PlasmaComponents.ToolButton.iconSource is supposed to

Re: Review Request 126514: [Milou/KRunner] Support runner actions

> On Dez. 28, 2015, 2:19 nachm., Marco Martin wrote: > > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand > > QIcons as it uses IconItem internally > > Kai Uwe Broulik wrote: > Yes, but iconSource property of QQC Button is of "url" type. And Plasma Button iconSource

Review Request 126544: [Kickoff] Hide history tab if empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/ --- Review request for Plasma, KDE Usability and Eike Hein. Repository:

Re: Review Request 126544: [Kickoff] Hide history tab if empty

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126544/#review90209 --- I don't really like how this is going to decreaes the load

Re: Review Request 126514: [Milou/KRunner] Support runner actions

> On Dez. 28, 2015, 2:19 nachm., Marco Martin wrote: > > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand > > QIcons as it uses IconItem internally Yes, but iconSource property of QQC Button is of "url" type. - Kai Uwe

Jenkins-kde-ci: oxygen Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 12:31:07 + Build duration: 2 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 44 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 12:28:52 + Build duration: 1 min 50 sec CHANGE SET Revision

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 44 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 12:28:52 + Build duration: 1 min 50 sec CHANGE SET Revision

Re: Review Request 126544: [Kickoff] Hide history tab if empty

> On Dec. 28, 2015, 2:04 p.m., David Edmundson wrote: > > applets/kickoff/package/contents/ui/FullRepresentation.qml, line 65 > > > > > > why? > > > > if were we to do this it should only do it if that

Re: Review Request 125921: Don't rely graphic objects in panel script engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125921/ --- (Updated Dec. 28, 2015, 3:43 p.m.) Review request for Plasma. Changes

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126524/ --- (Updated Dec. 28, 2015, 3:44 p.m.) Review request for Plasma and David

Review Request 126548: Kill PowerDevil runner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126548/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126514: [Milou/KRunner] Support runner actions

> On Dec. 28, 2015, 2:19 p.m., Marco Martin wrote: > > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand > > QIcons as it uses IconItem internally > > Kai Uwe Broulik wrote: > Yes, but iconSource property of QQC Button is of "url" type. > > Kai Uwe Broulik wrote: >

Re: Review Request 126514: [Milou/KRunner] Support runner actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126514/#review90233 --- Ship it! Ship It! - Marco Martin On Dec. 28, 2015, 3:49

Re: Review Request 126514: [Milou/KRunner] Support runner actions

> On Dec. 28, 2015, 2:19 p.m., Marco Martin wrote: > > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand > > QIcons as it uses IconItem internally > > Kai Uwe Broulik wrote: > Yes, but iconSource property of QQC Button is of "url" type. > > Kai Uwe Broulik wrote: >

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 351 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/351/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 28 Dec 2015 16:24:32 + Build duration: 13 min CHANGE SET Revision

Re: Review Request 125921: Don't rely graphic objects in panel script engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125921/ --- (Updated Dec. 28, 2015, 3:44 p.m.) Review request for Plasma. Bugs:

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > > > > > Ideally we should check the *calling* user can read this file, as you > > technically have a security bug. > >

Re: Review Request 125921: Don't rely graphic objects in panel script engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125921/ --- (Updated Dec. 28, 2015, 4:24 p.m.) Status -- This change has been

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > > > > > Ideally we should check the *calling* user can read this file, as you > > technically have a security bug. > >

Re: Review Request 126548: Kill PowerDevil runner

> On Dez. 28, 2015, 5:46 nachm., Xuetian Weng wrote: > > I can see that it provides suspend, sleep, hibernate feature which is still > > useful (Though for some reason I can't trigger it here). Maybe merge that > > part into sessions runner and drop others? > > Aleix Pol Gonzalez wrote: >

Re: Review Request 126548: Kill PowerDevil runner

> On Dez. 28, 2015, 5:46 nachm., Xuetian Weng wrote: > > I can see that it provides suspend, sleep, hibernate feature which is still > > useful (Though for some reason I can't trigger it here). Maybe merge that > > part into sessions runner and drop others? > > Aleix Pol Gonzalez wrote: >

Re: Review Request 126514: [Milou/KRunner] Support runner actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126514/ --- (Updated Dez. 28, 2015, 3:49 nachm.) Review request for Plasma, KDE

Re: Review Request 126514: [Milou/KRunner] Support runner actions

> On Dez. 28, 2015, 2:19 nachm., Marco Martin wrote: > > hmm, PlasmaComponents.ToolButton.iconSource is supposed to understand > > QIcons as it uses IconItem internally > > Kai Uwe Broulik wrote: > Yes, but iconSource property of QQC Button is of "url" type. > > Kai Uwe Broulik wrote: >

Re: Review Request 126514: [Milou/KRunner] Support runner actions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126514/ --- (Updated Dec. 28, 2015, 4:35 p.m.) Status -- This change has been

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > > > > > Ideally we should check the *calling* user can read this file, as you > > technically have a security bug. > >

Re: Review Request 126548: Kill PowerDevil runner

> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote: > > I can see that it provides suspend, sleep, hibernate feature which is still > > useful (Though for some reason I can't trigger it here). Maybe merge that > > part into sessions runner and drop others? I often suspend from KRunner. -

Re: Review Request 125921: Don't rely graphic objects in panel script engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125921/#review90228 --- Ship it! Ship It! - Marco Martin On Dec. 28, 2015, 3:44

Re: Review Request 126548: Kill PowerDevil runner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126548/#review90239 --- I can see that it provides suspend, sleep, hibernate feature

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126319/ --- (Updated Dec. 28, 2015, 5:47 p.m.) Status -- This change has been

Re: Review Request 126548: Kill PowerDevil runner

> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote: > > I can see that it provides suspend, sleep, hibernate feature which is still > > useful (Though for some reason I can't trigger it here). Maybe merge that > > part into sessions runner and drop others? > > Aleix Pol Gonzalez wrote: > I

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review90260 --- Ship it! OK, just one line break in the docs, then it can go

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 28, 2015, 11:14 nachm.) Review request for KDE Frameworks,

Re: Review Request 126548: Kill PowerDevil runner

> On Dez. 28, 2015, 5:46 nachm., Xuetian Weng wrote: > > I can see that it provides suspend, sleep, hibernate feature which is still > > useful (Though for some reason I can't trigger it here). Maybe merge that > > part into sessions runner and drop others? > > Aleix Pol Gonzalez wrote: >

Re: Review Request 126548: Kill PowerDevil runner

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126548/ --- (Updated Dez. 28, 2015, 6:28 nachm.) Status -- This change has been

Re: Splitting KActivities, 2nd attempt...

Sounds good overall, but one question: On Sunday 08 November 2015 12:04:54 Ivan Čukić wrote: > Hi everybody, > > We have a few problems at the moment because all the activities > components are in a single repository. Sometimes dependencies of the > service creep up into the library, builds

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

> On Dec. 28, 2015, 9:16 a.m., Marco Martin wrote: > > so, let's go with the last one? for me +1, any complaints? I went ahead and shipped; complaints were mostly focused on the intel-glitch-strip, outside of that I think we eliminated the glaring objective issues. I don't think there's

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

> On Dec. 27, 2015, 4:37 p.m., David Edmundson wrote: > > sddmauthhelper.cpp, line 74 > > > > > > Ideally we should check the *calling* user can read this file, as you > > technically have a security bug. > >

Re: robots.txt in quickgit.kde.org

On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley wrote: >> Is there some place where search engines can easily index our source >> code or are we shooting ourselves in the foot here? > > We could probably make it available by publishing the source trees > used by LXR / EBN. >

Re: Review Request 126544: [Kickoff] Hide history tab if empty

> On Dec. 28, 2015, 2:02 p.m., Aleix Pol Gonzalez wrote: > > Maybe show it as disabled at least? It's weird that UI structure change > > every now and then. I agree with the idea to avoid changing UI structure. However, to disable isn't good for tabs. Here is what we wrote in the tabcontrol

Re: Review Request 126544: [Kickoff] Hide history tab if empty

> On Dec. 28, 2015, 2:02 p.m., Aleix Pol Gonzalez wrote: > > Maybe show it as disabled at least? It's weird that UI structure change > > every now and then. > > Heiko Tietze wrote: > I agree with the idea to avoid changing UI structure. However, to disable > isn't good for tabs. > >

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/ --- (Updated Dez. 28, 2015, 11:34 nachm.) Review request for KDE Frameworks,

[Powerdevil] [Bug 357288] New: Setting "Screen Energy Saving" in "Energy Saving" config has no effect

https://bugs.kde.org/show_bug.cgi?id=357288 Bug ID: 357288 Summary: Setting "Screen Energy Saving" in "Energy Saving" config has no effect Product: Powerdevil Version: 5.5.0 Platform: Fedora RPMs OS: Linux

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

https://bugs.kde.org/show_bug.cgi?id=357288 --- Comment #1 from Raman Gupta --- Created attachment 96345 --> https://bugs.kde.org/attachment.cgi?id=96345=edit Configuration for power management -- You are receiving this mail because: You are the assignee for the bug.

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 352 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/352/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Dec 2015 00:22:34 + Build duration: 5 min 13 sec CHANGE SET Revision