Re: Review Request 126348: Make it possible to provide the metadata in json

2016-01-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/ --- (Updated Jan. 4, 2016, 8:04 p.m.) Status -- This change has been

Re: Review Request 126577: Update battery.svgz

2016-01-04 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126577/ --- (Updated Jan. 4, 2016, 6:44 p.m.) Status -- This change has been

Re: Review Request 126577: Update battery.svgz

2016-01-04 Thread Anthony Fieroni
> On Дек. 30, 2015, 5:24 след обяд, Marco Martin wrote: > > Ship It! I don't have access, upload it before 5.18 release :) - Anthony --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126548: Kill PowerDevil runner

2016-01-04 Thread Martin Gräßlin
> On Dec. 28, 2015, 6:46 p.m., Xuetian Weng wrote: > > I can see that it provides suspend, sleep, hibernate feature which is still > > useful (Though for some reason I can't trigger it here). Maybe merge that > > part into sessions runner and drop others? > > Aleix Pol Gonzalez wrote: > I

Re: kde/workspace repos on phabricator

2016-01-04 Thread Sebastian Kügler
On Wednesday, December 30, 2015 04:29:52 PM Marco Martin wrote: > On Wednesday 30 December 2015 17:53:36 Bhushan Shah wrote: > > Hello people, > > > > > > > > Just quick-ish update that kde/workspace repos are imported into > > phabricator, so I think its time we should start using phabricator

Minutes Monday Plasma Hangout

2016-01-04 Thread Sebastian Kügler
Present: kbroulik, notmart, mgraesslin, sebas, Date: January 4th, 2015 kbroulik: - work on dismissing dialogs: https://git.reviewboard.kde.org/r/124586/ - implementation for Unity launcher: https://git.reviewboard.kde.org/r/126621/ - querying the origin of a file in kfilemetadata - jump lists

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API

2016-01-04 Thread Kai Uwe Broulik
> On Jan. 4, 2016, 7:58 vorm., Heiko Tietze wrote: > > Pretty cool stuff. Guess there will some greediness from other launchers. > > On the first glance I read the tool as a launcher for Unity, which would be > > weird. So I suggest to think about renaming, maybe just without the space. I was

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API

2016-01-04 Thread Thomas Pfeiffer
> On Jan. 4, 2016, 7:58 a.m., Heiko Tietze wrote: > > Pretty cool stuff. Guess there will some greediness from other launchers. > > On the first glance I read the tool as a launcher for Unity, which would be > > weird. So I suggest to think about renaming, maybe just without the space. > > Kai

Proposal: integrity checks for packages and cryptographic signing

2016-01-04 Thread Martin Graesslin
Hi all, happy new year! I had a too long Christmas break and spent quite some thinking about how to improve the security situation on Plasma/Wayland and I think I found a solution to address one of the problems. tldr: we need to sign installed packages and verify the integrity when loading

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90598 --- applets/taskmanager/package/contents/ui/ConfigGeneral.qml

Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126579/ --- (Updated Jan. 4, 2016, 11:13 p.m.) Status -- This change has been

Re: Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Sebastian Kügler
> On Dec. 24, 2015, 8:23 p.m., Hrvoje Senjan wrote: > > backends/CMakeLists.txt, line 3 > > > > > > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should > > be marked as required in top

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Kai Uwe Broulik
> On Jan. 4, 2016, 11:01 nachm., Eike Hein wrote: > > Ship It! I need a proper frame graphic, "hover" isn't particularly good but I don't want to mess around with the tasks.svgz due to Review 126373 - Kai Uwe --- This is an

Re: Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Sebastian Kügler
> On Dec. 24, 2015, 8:23 p.m., Hrvoje Senjan wrote: > > backends/CMakeLists.txt, line 3 > > > > > > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should > > be marked as required in top

Re: Review Request 126373: change the taskbar color from blue to gray

2016-01-04 Thread Eike Hein
> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote: > > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo > > that cleans up all the random margins and inconsistent corner styles in it > > that currently mess up alignments inside and outside of task buttons as > > well as

Re: Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Martin Klapetek
> On Dec. 24, 2015, 9:23 p.m., Hrvoje Senjan wrote: > > backends/CMakeLists.txt, line 3 > > > > > > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should > > be marked as required in top

Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2016-01-04 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126579/#review90603 --- Ship it! Ship It! - Eike Hein On Jan. 1, 2016, 5:47 p.m.,

Re: Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results

2016-01-04 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126578/#review90602 --- Ship it! Ship It! - Eike Hein On Jan. 1, 2016, 5:55 p.m.,

Re: Review Request 126356: change minimum size of clipboard

2016-01-04 Thread David Edmundson
> On Dec. 15, 2015, 2:29 p.m., Martin Gräßlin wrote: > > applets/clipboard/contents/ui/clipboard.qml, line 69 > > > > > > this is not the actual size of the systray, but a hardcoded value which > > might match

Request for delaying Plasma 5.5.2 by a day

2016-01-04 Thread Martin Klapetek
Hey all, I was hoping the [1] would get at least one more tester over the Christmas but I got none. I consider that bug that crept in 5.5 to be quite serious (some people get random notifications positions on screen) and because nobody tested and/or reviewed it and 5.5.2 is upon us, I decided to

Re: Review Request 126629: update the sddm kcm first step

2016-01-04 Thread Andreas ka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126629/ --- (Updated Jan. 5, 2016, 2:34 a.m.) Review request for Plasma and David

Review Request 126629: update the sddm kcm first step

2016-01-04 Thread Andreas ka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126629/ --- Review request for Plasma and David Edmundson. Repository: sddm-kcm

Re: Review Request 126408: [notifications] Refactor the screen handling code

2016-01-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126408/ --- (Updated Jan. 5, 2016, 4:54 a.m.) Status -- This change has been

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- (Updated Jan. 4, 2016, 1:50 nachm.) Review request for Plasma, KDE

Re: Review Request 126408: [notifications] Refactor the screen handling code

2016-01-04 Thread Martin Gräßlin
> On Dec. 18, 2015, 8:04 a.m., Martin Gräßlin wrote: > > I have multi-screen, but didn't see the issue so far in the first place. So > > I'm unsure whether it makes sense for me to try, as the result might be > > incorrect. > > > > What you could try is running a nested kwin_wayland with

Re: Review Request 121010: Keep track of notifications that were covered by a fullscreen window

2016-01-04 Thread Martin Gräßlin
> On Dec. 25, 2015, 12:18 p.m., Kai Uwe Broulik wrote: > > Ping. > > > > (Is a roundtrip to the X Server that bad for the comparatively rare event > > of getting a notification?) yes, but not only because of the roundtrip, but because it's X11 specific. I don't know how that would work on

Re: Review Request 126591: [Task Manager] Adjust ToolTip when no thumbnail is available

2016-01-04 Thread Kai Uwe Broulik
> On Jan. 1, 2016, 8:18 nachm., Thomas Pfeiffer wrote: > > In which cases is no thumbnail available? > > Kai Uwe Broulik wrote: > In some cases when the window is minimized. > > I think now that we stop redirecting windows when the tooltip hides, > probably whenever a window is

Re: Review Request 126472: Don't always load the timetracker

2016-01-04 Thread David Edmundson
> On Dec. 22, 2015, 2:36 p.m., Sebastian Kügler wrote: > > Nice. > > > > I agree with Aleix that the env var would be good to have documented. (Is > > that even English?) But then, where? > > Martin Gräßlin wrote: > as an idea check: https://community.kde.org/KWin/Environment_Variables

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Kai Uwe Broulik
> On Jan. 4, 2016, 2:40 nachm., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? That would be sweet > On

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/ --- (Updated Jan. 4, 2016, 3:03 nachm.) Review request for Plasma, KDE

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Kai Uwe Broulik
> On Jan. 4, 2016, 2:40 nachm., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? > > Kai Uwe Broulik wrote:

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90547 --- +1 from me. Code is very neat and tidy. I don't really have

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2016-01-04 Thread Ken Vermette
> On Dec. 29, 2015, 11:56 p.m., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." > > Kai Uwe Broulik wrote: > I'm quite indifferent

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Marco Martin
> On Jan. 4, 2016, 2:40 p.m., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? > > Kai Uwe Broulik wrote: >

Re: Review Request 126463: Allow applets to set full ToolTip item

2016-01-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/ --- (Updated Jan. 4, 2016, 4:38 p.m.) Status -- This change has been

Re: Review Request 126625: paintedWidth/paintedheight for IconItem

2016-01-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126625/ --- (Updated Jan. 4, 2016, 4:33 p.m.) Review request for Plasma.

Re: Review Request 126625: paintedWidth/paintedheight for IconItem

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126625/#review90574 --- You can have a single size changed signal used by both

Re: Review Request 126597: Notificatioins rework

2016-01-04 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126597/ --- (Updated Ян. 4, 2016, 7:18 след обяд) Review request for Plasma, David

Re: Review Request 126625: paintedWidth/paintedheight for IconItem

2016-01-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126625/ --- (Updated Jan. 4, 2016, 5:20 p.m.) Status -- This change has been

Re: Review Request 126591: [Task Manager] Adjust ToolTip when no thumbnail is available

2016-01-04 Thread Eike Hein
> On Jan. 1, 2016, 8:18 p.m., Thomas Pfeiffer wrote: > > In which cases is no thumbnail available? > > Kai Uwe Broulik wrote: > In some cases when the window is minimized. > > I think now that we stop redirecting windows when the tooltip hides, > probably whenever a window is

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126621/#review90611 --- Ship it! Ship It! - Eike Hein On Jan. 4, 2016, 10:50

Re: Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Sebastian Kügler
> On Dec. 24, 2015, 8:23 p.m., Hrvoje Senjan wrote: > > backends/CMakeLists.txt, line 3 > > > > > > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should > > be marked as required in top

Re: Review Request 126578: [Kickoff/Kicker] Add context menu actions for search results

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126578/ --- (Updated Jan. 4, 2016, 11:13 p.m.) Status -- This change has been

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

2016-01-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/ --- (Updated Jan. 4, 2016, 5:38 p.m.) Status -- This change has been

Re: Review Request 124047: Improve clock's tooltip layout

2016-01-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated Jan. 4, 2016, 6:03 p.m.) Status -- This change has been

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/#review90580 --- Ship it! Ship It! - Kai Uwe Broulik On Jan. 4, 2016, 5:39

Re: Review Request 126566: Add "applicationcrash" notification event

2016-01-04 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126566/ --- (Updated Jan. 4, 2016, 5:58 p.m.) Status -- This change has been

Re: Review Request 126621: [Task Manager] Add support for Unity Launcher API and Application Jobs

2016-01-04 Thread Marco Martin
> On Jan. 4, 2016, 2:40 p.m., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 278 > > > > > > Do we need a paintedWidth/paintedHeight in IconItem? > > Kai Uwe Broulik wrote: >

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

2016-01-04 Thread Martin Klapetek
> On Dec. 21, 2015, 11:28 p.m., Kai Uwe Broulik wrote: > > desktoppackage/contents/applet/CompactApplet.qml, line 37 > > > > > > Doesn't it complain about "Cannot assign [undefined] to something"? If > > not,