Re: Review Request 126356: change minimum size of clipboard

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126356/#review90832 --- I'm not so sure if plasmoids started from desktop and panel ha

Re: Review Request 126356: change minimum size of clipboard

> On Jan. 10, 2016, 9:40 vorm., Heiko Tietze wrote: > > I'm not so sure if plasmoids started from desktop and panel have to be > > equal (if at all than I'd care about the caption). For what reason, > > familiarity? And the final size in the last picture > > (clipboardMinimumSize.png) is way t

Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126691/#review90839 --- That sounds like you're saying Qt has broken API. If that's t

Jenkins-kde-ci: kde-gtk-config Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kde-gtk-config%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:45:33 + Build duration: 3 min 32 sec CHANGE SET Revision 40a6fb250ab24c24aefb26

Jenkins-kde-ci: kinfocenter Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:46:33 + Build duration: 4 min 4 sec CHANGE SET Revision 078d20fbdfe4b72cb61dbd63f2

Jenkins-kde-ci: ksshaskpass Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ksshaskpass%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:47:38 + Build duration: 48 sec CHANGE SET Revision e15aa2930bf40264893da78c72ecfd9

Jenkins-kde-ci: oxygen Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 11 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:48:53 + Build duration: 4 min 34 sec CHANGE SET Revision 9f13dda472058015f7032c6d26949

Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 52 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:49:23 + Build duration: 7 min 12 sec CHANGE SET Revision 9f115b302c6485943f47d

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 41 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:51:33 + Build duration: 3 min 26 sec CHANGE SET Revision 278ba7050962ea58dc1

Re: Review Request 126300: Plasma Search KCM: display the runner descriptions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126300/ --- (Updated Jan. 10, 2016, 4:33 p.m.) Review request for Plasma and KDE Usab

Jenkins-kde-ci: polkit-kde-agent-1 Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/polkit-kde-agent-1%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:52:11 + Build duration: 1 min 44 sec CHANGE SET Revision cfa85fe7831a1fa887

Jenkins-kde-ci: sddm-kcm Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 7 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/sddm-kcm%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 14:52:53 + Build duration: 1 min 42 sec CHANGE SET Revision 1eea530d34e6d3e1c7e52985ab61

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 10, 2016, 5:10 nachm.) Review request for Plasma. Reposit

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 354 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/354/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 17:06:55 + Build duration: 7 min 7 sec CHANGE SET Revision 20ea3f6362e68eedb44ab93569301cee

Re: Review Request 126669: [Task Manager] Don't show on which virtual desktop a window is if there is just one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126669/ --- (Updated Jan. 10, 2016, 6:11 p.m.) Status -- This change has been ma

Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 53 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 10 Jan 2016 18:11:46 + Build duration: 7 min 12 sec CHANGE SET Revision f1ac92c5ee6de29721753

Re: Review Request 126513: Refactor kcm touchpad to fix some issue related to hotplug touchpad

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126513/#review90841 --- Ship it! Hard to review a big shuffle, but it looks fine to m

Re: Review Request 126689: Change minimum Size of Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126689/#review90844 --- Ship it! Ship It! - David Edmundson On Jan. 10, 2016, 12:0

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90843 --- src/declarativeimports/core/datamodel.cpp (line 463)

Re: Review Request 126689: Change minimum Size of Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126689/ --- (Updated Jan. 10, 2016, 7:56 p.m.) Status -- This change has been ma

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 9, 2016, 8:32 p.m., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just im

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/ --- (Updated Jan. 10, 2016, 8:44 nachm.) Review request for Plasma and KDE Us

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 10, 2016, 8:55 nachm.) Review request for Plasma. Changes

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 10, 2016, 8:59 nachm.) Review request for Plasma. Changes

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90848 --- src/declarativeimports/core/datamodel.cpp (line 466)

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 9, 2016, 8:32 nachm., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/ --- (Updated Jan. 10, 2016, 10:03 nachm.) Review request for Plasma. Change

Re: Review Request 126689: Change minimum Size of Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126689/#review90855 --- This actually doesn't do anything because the parent item has

Review Request 126713: fix font preview colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126713/ --- Review request for Plasma and Martin Klapetek. Bugs: 336089 https://b

Re: Review Request 126689: Change minimum Size of Calendar

> On Jan. 10, 2016, 11:10 p.m., Martin Klapetek wrote: > > This actually doesn't do anything because the parent item has > > > > Plasmoid.switchWidth: units.gridUnit * 12 > > Plasmoid.switchHeight: units.gridUnit * 12 > > > > ...so it would never get the full representation to *3. > > > > Plus

Re: Review Request 126687: [DataModel] Don't reset model when source is removed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126687/#review90857 --- +1 Though wait for Marco as I don't know this code at all -

Re: Review Request 126713: fix font preview colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126713/#review90858 --- Can I suggest you copy SNIProxy::convertFromNative from plasm

Re: Review Request 126713: fix font preview colors

> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote: > > Can I suggest you copy SNIProxy::convertFromNative from > > plasma-workspace/xembedsniproxy/sniproxy.cpp > > > > (which in itself is copied from KWindowSystem, which I think was copied > > from Qt) ...or maybe I should be the one

Re: Review Request 126713: fix font preview colors

> On Jan. 10, 2016, 10:31 p.m., David Edmundson wrote: > > Can I suggest you copy SNIProxy::convertFromNative from > > plasma-workspace/xembedsniproxy/sniproxy.cpp > > > > (which in itself is copied from KWindowSystem, which I think was copied > > from Qt) > > David Edmundson wrote: >

Re: Review Request 126689: Change minimum Size of Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126689/ --- (Updated Jan. 10, 2016, 11:39 p.m.) Review request for Plasma and Heiko T

Re: Review Request 126689: Change minimum Size of Calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126689/ --- (Updated Jan. 10, 2016, 11:41 p.m.) Review request for Plasma and Heiko T

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

> On Jan. 9, 2016, 8:32 p.m., Sebastian Kügler wrote: > > Very nice! > > > > Gut feeling feedback: > > > > - the error message's icon could take the place of the eject icon > > - the "safely remove" icon could go away, text made italic (not sure if > > there's prior art in the HIG, I'm just im