Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 57 - Still Failing!

2016-01-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jan 2016 21:11:35 + Build duration: 5 min 31 sec CHANGE SET Revision 5e95ef677ea5dd09137dc

Re: Review Request 126807: Ensure connection to exist before using

2016-01-21 Thread Andreas Cord-Landwehr
> On Jan. 19, 2016, 6:35 nachm., Rajeesh K V wrote: > > I must admit I don't understand the root cause or how m_connection could be > > null, but as this fixes the crash - ship it. > > Andreas Cord-Landwehr wrote: > If I am not mistaken, the root cause is the following: > * XLibTouchpad

Re: Review Request 126807: Ensure connection to exist before using

2016-01-21 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126807/ --- (Updated Jan. 21, 2016, 8:55 nachm.) Status -- This change has been

[Differential] [Changed Subscribers] D851: Port kded plugin to json metadata

2016-01-21 Thread arichardson (Alex Richardson)
arichardson added a subscriber: arichardson. INLINE COMMENTS CMakeLists.txt:78 Add SERVICE_TYPES kdedmodule.desktop here to ensure that all keys have the right type CMakeLists.txt:81 Could be simplified to use `kcoreaddons_add_plugin(kded_kwrite SOURCES kwrited.cpp JSON "kwrited.json" INSTA

[Differential] [Request, 11 lines] D851: Port kded plugin to json metadata

2016-01-21 Thread heikobecker (Heiko Becker)
heikobecker created this revision. heikobecker added a reviewer: plasma-devel. REPOSITORY rKWRITED KWriteD BRANCH master REVISION DETAIL https://phabricator.kde.org/D851 AFFECTED FILES CMakeLists.txt kwrited.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 51 - Still Failing!

2016-01-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jan 2016 16:42:07 + Build duration: 1 min 36 sec CHANGE SET Revision 988a7bef7e84a4a2fc6

Re: Review Request 126837: Load lockscreen wallpaper as fast as possible

2016-01-21 Thread Kai Uwe Broulik
> On Jan. 21, 2016, 4 nachm., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 102 > > > > > > Please use the active property of Loader rather than setting the source > > in variou

Re: Review Request 126837: Load lockscreen wallpaper as fast as possible

2016-01-21 Thread Marco Martin
> On Jan. 21, 2016, 4 p.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 102 > > > > > > Please use the active property of Loader rather than setting the source > > in various

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 50 - Still Failing!

2016-01-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Jan 2016 15:04:59 + Build duration: 1 min 3 sec CHANGE SET Revision 994de033983c32fca24f

Re: Review Request 126837: Load lockscreen wallpaper as fast as possible

2016-01-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126837/#review91421 --- lookandfeel/contents/lockscreen/LockScreen.qml (line 56)

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-21 Thread Hrvoje Senjan
> On Jan. 20, 2016, 11:26 p.m., Hrvoje Senjan wrote: > > so i lost kmail icon in tray after this it seems > > Marco Martin wrote: > do you have an empty space or no icon at all? empty space. - Hrvoje --- This is an automatically ge

Re: Review Request 126837: Load lockscreen wallpaper as fast as possible

2016-01-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126837/ --- (Updated Jan. 21, 2016, 3:04 p.m.) Status -- This change has been ma

Re: Review Request 126837: Load lockscreen wallpaper as fast as possible

2016-01-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126837/#review91419 --- Ship it! Ship It! - Sebastian Kügler On Jan. 21, 2016,

Review Request 126837: Load lockscreen wallpaper as fast as possible

2016-01-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126837/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 126822: AppletQuickItem: Don't try to set initial size bigger than parent size

2016-01-21 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126822/ --- (Updated Jan. 21, 2016, 2:41 p.m.) Status -- This change has been ma

Re: Review Request 126812: plasma-framework: Fix document.svgz to use color from stylesheet

2016-01-21 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126812/ --- (Updated Jan. 21, 2016, 2:42 p.m.) Status -- This change has been ma

Re: Review Request 126740: Add a script for optimizing svgs

2016-01-21 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126740/#review91416 --- optimize.svg.sh (line 1)

Re: Window thumbnail discussion

2016-01-21 Thread Kai Uwe Broulik
I misread the name, Window Metadata doesn't imply a restriction to thumbnails, so all good for future exploration I guess :)  Awesome stuff! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-21 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review91409 --- Ship it! Ship It! - andreas kainz On Jan. 11, 2016, 4:1

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-21 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126688/#review91408 --- Ship it! Ship It! - Heiko Tietze On Jan. 11, 2016, 4:19

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-01-21 Thread Lars Pontoppidan
> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote: > > Nice to see this applet coming back! > > > > I was wondering if there could be more code shared between this applet and > > our image wallpaper, perhaps even "just" allow the image wallpaper to > > function also as an applet. > > > > You ha

Re: Review Request 126688: RFC: [Device Notifier] Provide inline feedback

2016-01-21 Thread Marco Martin
> On Jan. 11, 2016, 8:12 p.m., Kai Uwe Broulik wrote: > > Someone suggested to style it like this: https://i.imgur.com/nPVhWr9.png > > > > While I'm not a huge fan of that excessive green background I agree that > > perhaps the message should be more prominently displayed, ie. moving back > >

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2016-01-21 Thread Mindaugas Baranauskas
> On Nov. 22, 2015, 1:24 p.m., Alex Merry wrote: > > Ship It! Seems that with this patch KDE Plasma crash more often: https://bugs.kde.org/show_bug.cgi?id=357895#c22 - Mindaugas --- This is an automatically generated e-mail. To reply,

Re: Review Request 126793: KF5 (Picture) Frame plasmoid

2016-01-21 Thread Marco Martin
> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote: > > Nice to see this applet coming back! > > > > I was wondering if there could be more code shared between this applet and > > our image wallpaper, perhaps even "just" allow the image wallpaper to > > function also as an applet. > > > > You ha

Re: Window thumbnail discussion

2016-01-21 Thread Martin Gräßlin
Am 2016-01-21 12:00, schrieb Kai Uwe Broulik: Hi, Yes, please! That's the crazy idea Thomas and I had a while ago. Looking forward to see it implemented. I would make it a bit more generic though, ie. not necessarily tied to just window thumbnails. We now ‎have Unity Launcher support and so I w

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

2016-01-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126642/#review91402 --- Ship it! I'm in general in favor of that, mostly for the s

Re: Review Request 126812: plasma-framework: Fix document.svgz to use color from stylesheet

2016-01-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126812/#review91401 --- Ship it! Ship It! - Marco Martin On Jan. 19, 2016, 12:4

Re: Review Request 126822: AppletQuickItem: Don't try to set initial size bigger than parent size

2016-01-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126822/#review91399 --- Ship it! Ship It! - Marco Martin On Jan. 20, 2016, 2:05

Re: Window thumbnail discussion

2016-01-21 Thread Kai Uwe Broulik
Hi,Yes, please! That's the crazy idea Thomas and I had a while ago. Looking forward to see it implemented. I would make it a bit more generic though, ie. not necessarily tied to just window thumbnails.We now ‎have

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-21 Thread Marco Martin
> On Jan. 20, 2016, 10:26 p.m., Hrvoje Senjan wrote: > > so i lost kmail icon in tray after this it seems do you have an empty space or no icon at all? - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.

Re: KWallet Runner

2016-01-21 Thread Sebastian Kügler
On Thursday, January 21, 2016 14:37:39 James Augustus Zuccon wrote: > At present I'm drawing my own dialog to display the passwords/maps which is > a bit repetitious code-wise. > > I was thinking it might be best to leverage KWalletManager with a command > line option that allows it to open a stan