Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 vorm., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126893: [kioslave/remote] fix knetattach .desktop filename

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126893/ --- (Updated Jan. 29, 2016, 5:11 p.m.) Review request for Plasma. Changes

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 vorm., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Jan. 25, 2016, 9 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated reposition

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Jan. 25, 2016, 8 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated reposition

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Ян. 25, 2016, 10 преди обяд, Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

> On Jan. 25, 2016, 9 a.m., Martin Gräßlin wrote: > > src/declarativeimports/core/tooltip.cpp, line 160 > > > > > > why bind it to compositingActive? > > Anthony Fieroni wrote: > To stop animated reposition

Re: Review Request 126892: [kioslave/remote] check return of createWizardEntry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126892/ --- (Updated Jan. 29, 2016, 5:11 p.m.) Review request for Plasma. Changes

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126878: [KRunner] Show single runner name

> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

[Differential] [Request, 178 lines] D884: Async variant to check whether power management is inhibited

graesslin created this revision. graesslin added reviewers: bshah, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY KScreenLocker checks whether power management is inhibited on idle time out. So far this used a sync and blocking dbus call.

Re: Review Request 126918: remove the legacy applets filter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126918/#review91782 --- Ship it! Ship it...but lets not do it 2 days before

Re: Performance issue with plasmoid and dataengine combination

Hey, what I would suggest for starters is to find where the CPU draining happens. Try running gdb --pid `pidof plasmashell`, wait for it to load and type "thread apply all bt", then type "continue" and after a bit hit ctrl+c and type "thread apply all bt". Maybe it will give some interesting