Re: Review Request 127024: Don't filter names if we have mimetypes

2016-02-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127024/#review92310 --- Indeed, mime filters supersede name filters.

Re: RFC: plasma logo as start menu icon and ksplash logo

2016-02-13 Thread Jens Reuterberg
As the one responsible for the logo work (since Uri who made that and other bits is in the VDG) I should probably shime in here. The three dots and the arrow is simply because of the connections to the K logo. The reasoning for it is to make it flexible (do note that we came in blind into

Re: Review Request 126878: [KRunner] Show single runner name

2016-02-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126878/ --- (Updated Feb. 13, 2016, 5:34 p.m.) Status -- This change has been

[Differential] [Changed Subscribers] D936: WindowThumbnail: Discard glx pixmap in stopRedirecting()

2016-02-13 Thread drosca (David Rosca)
drosca added a subscriber: plasma-devel. REVISION DETAIL https://phabricator.kde.org/D936 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: plasma-devel ___ Plasma-devel mailing list

[Differential] [Abandoned] D936: WindowThumbnail: Discard glx pixmap in stopRedirecting()

2016-02-13 Thread drosca (David Rosca)
drosca abandoned this revision. drosca added a comment. plasma-framework is not on phabricator, sorry. REVISION DETAIL https://phabricator.kde.org/D936 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: plasma-devel

[Differential] [Changed Subscribers] D933: Fix minimum size of Applet handle with Folder View

2016-02-13 Thread drosca (David Rosca)
drosca added a subscriber: plasma-devel. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D933 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, hein, Plasma Cc: plasma-devel

Review Request 127072: WindowThumbnail: Discard glx pixmap in stopRedirecting()

2016-02-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127072/ --- Review request for Plasma. Bugs: 357895

Review Request 127073: AppletQuickItem: Fix finding own attached layout

2016-02-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/ --- Review request for Plasma. Bugs: 358849

Review Request 127071: ButtonStyle: Fix text alignment with minimumWidth

2016-02-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127071/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

2016-02-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/#review92328 --- src/plasmaquick/appletquickitem.h (line 149)

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

2016-02-13 Thread David Rosca
> On Feb. 13, 2016, 11:33 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/appletquickitem.h, line 149 > > > > > > This looks binary incompatible. > > > > Also, add Q_DECL_OVERRIDE Looks fine to me

Re: Review Request 127073: AppletQuickItem: Fix finding own attached layout

2016-02-13 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127073/ --- (Updated Feb. 13, 2016, 11:48 p.m.) Review request for Plasma. Changes

[PATCH] [RFC] make handles obscure less of the screen behind them

2016-02-13 Thread Dirk Hohndel
I don't think this is the right way to do this. The patch below is the hack that I used for the last few Subsurface-mobile alpha builds to give people the idea that the handles really shouldn't be so visually dominant. So the background is even more transparent and instead of filling the path we

[PATCH] make context drawer smaller

2016-02-13 Thread Dirk Hohndel
This is an odd one. Not sure what the logic was behind that, but with the existing code on most phones the context drawer takes up the complete screen which makes it look really weird. /D From 59779ccf31f7a1f48a45401655aeb7eaa98cc4fe Mon Sep 17 00:00:00 2001 From: Dirk Hohndel

[PATCH] Allow the app to filter the back key even at the top level

2016-02-13 Thread Dirk Hohndel
The onBackRequested trick didn't work on the top level page. Which seems odd to me - why shouldn't an application be allowed to prevent the back key from exiting? In my case we have a slightly odd design (ask sebas why we ended up with that - he wrote it) where the top page actually morphs into