[Differential] [Accepted] D1045: Emit PaletteChanged when setting colors from look and feel package

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH kcm-laf (branched from master) REVISION DETAIL https://phabricator.kde.org/D1045 EMAIL PREFERENCES https://phabricator.kde.org/setti

Re: Review Request 127229: Workaround bug 352055

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127229/#review92970 --- Ship it! Yeah, either this or changing systray for 5.6 alr

[Differential] [Commented On] D1045: Emit PaletteChanged when setting colors from look and feel package

drosca added inline comments. INLINE COMMENTS kcms/lookandfeel/kcm.cpp:342 Yes, QDBusMessage::createSignal instead of KGlobalSettings as this just emits one signal. But KGlobalSettings is already used in this file so it doesn't really matter. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH

[Differential] [Closed] D1045: Emit PaletteChanged when setting colors from look and feel package

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPec5e86a51764: Emit PaletteChanged when setting colors from look and feel package (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricat

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/ --- (Updated March 1, 2016, 12:43 p.m.) Review request for Plasma and Marco M

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/#review92988 --- Ship it! It's perhaps a bit late for 5.6, but i think is p

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/#review92991 --- I am now satisfied with the current state and would like to p

Jenkins-kde-ci: kde-gtk-config Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 9 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kde-gtk-config%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 13:07:27 + Build duration: 1.2 sec CHANGE SET No changes _

Jenkins-kde-ci: khotkeys Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 13 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 13:10:47 + Build duration: 1.2 sec CHANGE SET No changes __

Jenkins-kde-ci: kmenuedit Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 9 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmenuedit%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 13:11:17 + Build duration: 1.2 sec CHANGE SET No changes __

Jenkins-kde-ci: plasma-desktop Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 72 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/72/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 13:15:12 + Build duration: 1 min 51 sec CHANGE SET Revision 7c5a4cb59d1b9d050fdab

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 63 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 13:16:37 + Build duration: 38 sec CHANGE SET Revision 7608d0aa3a0014544119a5add

Jenkins-kde-ci: sddm-kcm Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 9 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/sddm-kcm%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 13:17:52 + Build duration: 7.3 sec CHANGE SET No changes ___

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review92995 --- Turns out pkg_get_variable is available only in cmake 3.4, wh

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On März 1, 2016, 12:56 nachm., Friedrich W. H. Kossebau wrote: > > I am now satisfied with the current state and would like to propose it for > > merge into master. > > > > From what I saw there is one issue still left: sometimes after changing the > > config there is no immediate data updat

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On March 1, 2016, 12:56 p.m., Friedrich W. H. Kossebau wrote: > > I am now satisfied with the current state and would like to propose it for > > merge into master. > > > > From what I saw there is one issue still left: sometimes after changing the > > config there is no immediate data update

Re: Review Request 127229: Workaround bug 352055

> On March 1, 2016, 8:45 a.m., Marco Martin wrote: > > Yeah, either this or changing systray for 5.6 already :/ > > and i think it's an issue in Qml, since it's very old code and this problem > > really started only on 5.6 branch of Qt This problem did not only start on the 5.6 branch of Qt. Yo

Plasma 5.5.5 tars are up

Plasma 5.5.5 has been released with some important security fixes https://www.kde.org/announcements/plasma-5.5.5.php This is the last release in 5.5 series, 5.6 beta due tomorrow Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/ --- (Updated March 1, 2016, 3:18 p.m.) Status -- This change has been ma

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/#review93003 --- Don't forget to add that to the 5.6 feature list: https://no

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On March 1, 2016, 3:25 p.m., Kai Uwe Broulik wrote: > > Don't forget to add that to the 5.6 feature list: > > https://notes.kde.org/p/plasma_5_6 Okay, done. - Friedrich W. H. --- This is an automatically generated e-mail. To reply, v

Re: Review Request 126811: Emit contextualAppletsAboutToShow in systemtray

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126811/ --- (Updated March 1, 2016, 3:40 p.m.) Status -- This change has been ma

Re: Review Request 127225: ShellCorona is responsible for the memory management of views

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127225/ --- (Updated March 1, 2016, 3:42 p.m.) Status -- This change has been ma

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 451 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/451/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 15:41:17 + Build duration: 6 min 41 sec CHANGE SET Revision 109f6cfca5ef9c0266a555c6cd68b

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 451 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/451/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 15:41:17 + Build duration: 6 min 41 sec CHANGE SET Revision 109f6cfca5ef9c0266a555c6cd68b

5.6 Errata

Plasma 5.6 feature freeze, string freeze and beta is due tomorrow. Please add any significant problems or regressions to this page https://community.kde.org/Plasma/5.6_Errata editing on wikis seems to work again if you have set up an account on phabricator and don't add any external links Jonath

Re: Review Request 127229: Workaround bug 352055

> On March 1, 2016, 8:45 a.m., Marco Martin wrote: > > Yeah, either this or changing systray for 5.6 already :/ > > and i think it's an issue in Qml, since it's very old code and this problem > > really started only on 5.6 branch of Qt > > David Edmundson wrote: > This problem did not only

Re: Review Request 127229: Workaround bug 352055

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127229/ --- (Updated March 1, 2016, 4:23 p.m.) Status -- This change has been ma

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 64 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 16:35:48 + Build duration: 1 min 6 sec CHANGE SET Revision 16584dc70ef9121876de

Re: Plasma 5.5.5 tars are up

An update to plasma-workspace to pick up a fix commit 16584dc70ef9121876ded1604daf32774d1862e2 Author: Weng Xuetian Date: Tue Mar 1 08:05:23 2016 -0800 Workaround by always reset model when insert and remove from model. CCBUG: 352055 plasma-workspace;Plasma/5.5;16584dc70ef912187

Review Request 127247: [Icon Widget] Add shadow instead of background

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127247/ --- Review request for Plasma, KDE Usability and Eike Hein. Repository: plasm

Re: Review Request 127247: [Icon Widget] Add shadow instead of background

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127247/#review93036 --- Maybe get the DropShadow on the icon as well? - Aleix Pol Go

Re: Review Request 127247: [Icon Widget] Add shadow instead of background

> On März 1, 2016, 8:03 nachm., Aleix Pol Gonzalez wrote: > > Maybe get the DropShadow on the icon as well? I just did what FolderView does which the VDG +3'd so if we want a shadow around the icon it should be consistent - Kai Uwe ---

Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127248/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace

[Differential] [Updated] D948: Don't show applet handle outside of desktop

drosca updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH handle-position (branched from master) REVISION DETAIL https://phabricator.kde.org/D948 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, mart

[Differential] [Updated, 61 lines] D948: Don't show applet handle outside of desktop

drosca updated this revision to Diff 2510. drosca added a comment. Reset verticalCenterOffset when handleMerged changes. Also increment appletItem.z to fix handle showing under other applets. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127248/#review93038 --- BBC one is fine, not building it makes sense if it doesn't wo

Re: Review Request 127247: [Icon Widget] Add shadow instead of background

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127247/#review93039 --- Ship it! Ship It! - Marco Martin On March 1, 2016, 7:43

Re: Review Request 127247: [Icon Widget] Add shadow instead of background

> On March 1, 2016, 8:03 p.m., Aleix Pol Gonzalez wrote: > > Maybe get the DropShadow on the icon as well? > > Kai Uwe Broulik wrote: > I just did what FolderView does which the VDG +3'd so if we want a shadow > around the icon it should be consistent no, i don't think a shadow around the

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127248/#review93041 --- Ship it! yeah, it makes sense I did briefly try to port th

Re: Review Request 127247: [Icon Widget] Add shadow instead of background

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127247/ --- (Updated March 1, 2016, 9:53 p.m.) Status -- This change has been ma

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

> On March 1, 2016, 8:26 p.m., David Edmundson wrote: > > dataengines/weather/ions/envcan/CMakeLists.txt, line 9 > > > > > > translation domain needs settings > > > > (bbc too) and possibly wetter.com if

Re: 5.6 features

Hi, I just wrote together some nonsense there. Please extend, correct, review. I'm not very good at this. :) https://notes.kde.org/p/plasma_5_6 Cheers,  Kai Uwe ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/p

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

> On March 1, 2016, 8:26 p.m., David Edmundson wrote: > > BBC one is fine, not building it makes sense if it doesn't work. > > > > Have you tested the other one? > Have you tested the other one? Yes (sorry, thought that was implicit, but right, I should have mentioned, that's why there is als

Re: Review Request 127229: Workaround bug 352055

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127229/#review93047 --- With this patch my tray's hidden icon arrow no longer apears

Re: Review Request 127229: Workaround bug 352055

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127229/#review93048 --- https://quickgit.kde.org/?p=plasma-workspace.git&a=commit&h=4

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 65 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/65/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 21:57:19 + Build duration: 1 min 41 sec CHANGE SET Revision 42849c35780577cd9c7

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127248/#review93049 --- Ship it! you're right about the messages. ship it from me

Re: Review Request 127248: More weather dataengine ion plugins cleanup/port (for 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127248/ --- (Updated March 1, 2016, 10:44 p.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 457 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/457/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 22:44:20 + Build duration: 6 min 18 sec CHANGE SET Revision d1c4aeecc05f27a5cb803c89270d3

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 458 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/458/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 23:36:45 + Build duration: 6 min 54 sec CHANGE SET Revision f85026fafa1c7593e0b3958c57840

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 458 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/458/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 01 Mar 2016 23:36:45 + Build duration: 6 min 54 sec CHANGE SET Revision f85026fafa1c7593e0b3958c57840

Review Request 127252: Port all ion plugins away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127252/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace

Moving Breeze lookandfeel to breeze repository

Hi, More specifically: plasma-workspace/lookandfeel/ My Context: I was looking into why applications are trying to load oxygen icons instead of breeze on xdg-apps. The reason is that it was falling back because breeze couldn't be found. AFAIU, this is offered by $PREFIX/share/plasma/look-and-feel/

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 445 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/445/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 01:05:36 + Build duration: 7 min 22 sec CHANGE SET Revision ec5e86a51764e2540ac3d01e589ccea

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127252/#review93051 --- LGTM. +1 dataengines/weather/ions/wetter.com/ion_wettercom.

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 445 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/445/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 01:05:36 + Build duration: 7 min 22 sec CHANGE SET Revision ec5e86a51764e2540ac3d01e589ccea

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

> On March 2, 2016, 1:13 a.m., Aleix Pol Gonzalez wrote: > > dataengines/weather/ions/wetter.com/ion_wettercom.cpp, line 718 > > > > > > Shouldn't this be i18n? No, this is an identifier/key (and not exposed in

Review Request 127254: Fix showing openGL compatability warning to user

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127254/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 127254: Fix showing openGL compatability warning to user

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127254/#review93054 --- Ship it! shell/shellcorona.cpp (line 1722)

Re: Moving Breeze lookandfeel to breeze repository

On Wednesday, March 2, 2016 2:06:52 AM CET Aleix Pol wrote: > Hi, > More specifically: > plasma-workspace/lookandfeel/ > > My Context: > I was looking into why applications are trying to load oxygen icons > instead of breeze on xdg-apps. The reason is that it was falling back > because breeze coul

[Differential] [Closed] D1046: [server] Implement support for drag'n'drop through pointer device

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND413025c293b1: [server] Implement support for drag'n'drop through pointer device (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10