Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Alexander Potashev
2016-03-09 19:24 GMT+03:00 Sebastian Kügler : > Indeed. My change was not trying to get a generalized policy implemented, but > to fix the wrong use of the KDE brand. We do have people telling us that > they'll happily use KDE to refer to the desktop because we don't even use it >

Re: Review Request 127320: Inform applet to update menus before using them

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127320/#review93377 --- Ship it! uh, thanks for noticing it :) - Marco Martin

Re: Review Request 127319: [Weather widget] Fix occasional empty widget after configuring a new weather station

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127319/#review93374 --- Ship it! Ship It! - Marco Martin On March 9, 2016,

Re: Review Request 127260: Experiment: cache svg icons from icon theme

2016-03-09 Thread Marco Martin
> On March 4, 2016, 8:52 p.m., David Edmundson wrote: > > src/plasma/private/theme_p.cpp, line 233 > > > > > > I'm not sure this works. > > This compares if the cache file > icon file. > > > > This

Re: Review Request 127322: remove unused file

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127322/#review93373 --- Ship it! Ship It! - Marco Martin On March 9, 2016,

Re: Review Request 127315: Icon applet: Set sensible minimum height

2016-03-09 Thread Marco Martin
> On March 9, 2016, 3:12 p.m., Marco Martin wrote: > > applets/icon/package/contents/ui/main.qml, line 42 > > > > > > is the text visible in horizontal panels? > > Kai Uwe Broulik wrote: > It isn't so

Review Request 127322: remove unused file

2016-03-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127322/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 127260: Experiment: cache svg icons from icon theme

2016-03-09 Thread David Edmundson
> On March 4, 2016, 8:52 p.m., David Edmundson wrote: > > src/plasma/private/theme_p.cpp, line 233 > > > > > > I'm not sure this works. > > This compares if the cache file > icon file. > > > > This

Review Request 127319: [Weather widget] Fix occasional empty widget after configuring a new weather station

2016-03-09 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127319/ --- Review request for Plasma, Kai Uwe Broulik and Marco Martin. Repository:

Review Request 127320: Inform applet to update menus before using them

2016-03-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127320/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

2016-03-09 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127313/#review93364 --- Ship it! Ship It! - David Edmundson On March 9, 2016,

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 16 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 19:31:39 + Build duration: 1 min 50 sec CHANGE SET Revision

Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Sebastian Kügler
On Wednesday, March 09, 2016 18:01:12 Luigi Toscano wrote: > On Wednesday 09 of March 2016 09:26:05 Sebastian Kügler wrote: > > On Tuesday, March 08, 2016 22:04:26 Luigi Toscano wrote: > > > Sebastian Kügler ha scritto: > > > > On Tuesday, March 08, 2016 21:20:22 Luigi Toscano wrote: > > > >>

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Albert Astals Cid
El Wednesday 09 March 2016, a les 15:29:28, Sebastian Kügler va escriure: > Hi all, > > [For the sake of sanity, please reply to both list, this topic affects > applications and Plasma.] > > One of the topics we are discussing at the current Plasma sprint is whether > we really want khelpcenter

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-09 Thread Rajeesh K V
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/ --- (Updated March 9, 2016, 7:31 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 19:13:54 + Build duration: 1 min 40 sec CHANGE SET Revision

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/#review93363 --- Ship it! Ship It! - Xuetian Weng On March 9, 2016,

Re: Review Request 127318: [Applet] Actually delete applet when undo times out

2016-03-09 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127318/#review93362 --- src/plasma/private/applet_p.cpp (line 295)

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 19:01:34 + Build duration: 1 min 34 sec CHANGE SET Revision

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-09 Thread Rajeesh K V
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/ --- (Updated March 9, 2016, 7:14 p.m.) Review request for Plasma, David

Re: Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service

2016-03-09 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127285/ --- (Updated March 9, 2016, 7:12 p.m.) Status -- This change has been

Re: Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service

2016-03-09 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127285/#review93360 --- Ship it! Ship It! - Martin Klapetek On March 5, 2016,

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-09 Thread Rajeesh K V
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/ --- (Updated March 9, 2016, 6:57 p.m.) Review request for Plasma, David

Re: Review Request 127318: [Applet] Actually delete applet when undo times out

2016-03-09 Thread Kai Uwe Broulik
> On März 9, 2016, 6:19 nachm., Anthony Fieroni wrote: > > src/plasma/private/applet_p.cpp, line 325 > > > > > > About me, since i made this patch, when notification is closed lambda > > above is called with

Re: Review Request 127318: [Applet] Actually delete applet when undo times out

2016-03-09 Thread Anthony Fieroni
> On Март 9, 2016, 8:19 след обяд, Anthony Fieroni wrote: > > src/plasma/private/applet_p.cpp, line 325 > > > > > > About me, since i made this patch, when notification is closed lambda > > above is called with

Re: Review Request 127318: [Applet] Actually delete applet when undo times out

2016-03-09 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127318/#review93354 --- src/plasma/private/applet_p.cpp (line 325)

Re: Review Request 127318: [Applet] Actually delete applet when undo times out

2016-03-09 Thread Kai Uwe Broulik
> On März 9, 2016, 6:19 nachm., Anthony Fieroni wrote: > > src/plasma/private/applet_p.cpp, line 325 > > > > > > About me, since i made this patch, when notification is closed lambda > > above is called with

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review93351 --- Ship it! Ship It! - Marco Martin On March 9, 2016,

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 17:45:44 + Build duration: 57 sec CHANGE SET Revision

Review Request 127318: [Applet] Actually delete applet when undo times out

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127318/ --- Review request for Plasma. Repository: plasma-framework Description

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Luigi Toscano
On Wednesday 09 of March 2016 16:50:39 Sebastian Kügler wrote: > On Wednesday, March 09, 2016 17:30:01 Luigi Toscano wrote: > > > Let me cut right to the chase, do you want to maintain it? Does it need > > > to > > > be in Plasma? > > > > Yes, I can maintain it. In fact many features come from

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-09 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/ --- (Updated March 9, 2016, 5:21 p.m.) Status -- This change has been

Re: kdereview: breeze-grub & breeze-plymouth

2016-03-09 Thread Sebastian Kügler
On Wednesday, March 09, 2016 17:07:21 Jonathan Riddell wrote: > This does not build when using > -Wl,--no-undefined > > breeze-text/plugin.c:601: undefined reference to `pow' > breeze-text/plugin.c:601: undefined reference to `pow' offhand, it needs #include IIRC. -- sebas Sebastian Kügler

Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Ivan Čukić
> If, on the other side, you think that this is not important for components > part of Plasma, and if they are not used (because ends up hidden by their > generic name) in other environment, that's fine. That is exactly the point. These components are meant to be a part of plasma only. Nobody

Re: kdereview: breeze-grub & breeze-plymouth

2016-03-09 Thread Jonathan Riddell
On Wed, Feb 24, 2016 at 04:52:57PM +0100, Harald Sitter wrote: > On Fri, Feb 19, 2016 at 9:43 AM, Harald Sitter wrote: > > Salut! > > > > As mentioned yesterday by Andreas Kainz, the VDG is working on a > > unified design from boot to shutdown. To facilitate this we started > >

Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Luigi Toscano
On Wednesday 09 of March 2016 09:26:05 Sebastian Kügler wrote: > On Tuesday, March 08, 2016 22:04:26 Luigi Toscano wrote: > > Sebastian Kügler ha scritto: > > > On Tuesday, March 08, 2016 21:20:22 Luigi Toscano wrote: > > >> Alexander Potashev ha scritto: > > >>> 2016-03-08 23:04 GMT+03:00 Ivan

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Kai Uwe Broulik
> On März 9, 2016, 4:56 nachm., Marco Martin wrote: > > the patch is fine, but it's the one about not using unneeded loadPixmp, not > > the one about not animating when hidden? yeah disregard the unittest, sorry, just need to remove the qexpectfail - Kai Uwe

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review93347 --- the patch is fine, but it's the one about not using unneeded

[Differential] [Accepted] D1094: [KRunner] Don't override user input in history

2016-03-09 Thread xuetianweng (Xuetian Weng)
xuetianweng accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1094 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma,

[Differential] [Closed] D1094: [KRunner] Don't override user input in history

2016-03-09 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE20b97073bb3f: [KRunner] Don't override user input in history (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 16:50:48 + Build duration: 1 min 35 sec CHANGE SET Revision

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
On Wednesday, March 09, 2016 17:30:01 Luigi Toscano wrote: > > Let me cut right to the chase, do you want to maintain it? Does it need to > > be in Plasma? > > Yes, I can maintain it. In fact many features come from components I > already control. > > > You're right that Plasma devs don't seem

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated März 9, 2016, 4:39 nachm.) Review request for Plasma. Changes

Jenkins-kde-ci: kinfocenter Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

2016-03-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinfocenter%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 16:26:58 + Build duration: 1 min 41 sec CHANGE SET Revision

Jenkins-kde-ci: kinfocenter Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

2016-03-09 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinfocenter%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 16:26:58 + Build duration: 1 min 41 sec CHANGE SET Revision

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Luigi Toscano
On Wednesday 09 of March 2016 16:16:54 Sebastian Kügler wrote: > On Wednesday, March 09, 2016 17:05:14 Luigi Toscano wrote: > > That said, I perceive this email as "khelpcenter is not welcome in > > Plasma", > > probably with a maintainer ("hell-bent on keeping it" sounds very negative > > to me).

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Martin Klapetek
On Wed, Mar 9, 2016 at 11:20 AM, Martin Gräßlin wrote: > Am 2016-03-09 16:43, schrieb Yuri Chornoivan: > >> >> Hi, >> >> Just of curiosity, what is the next thing, after documentation (as >> Plasma almost does not have it), to get rid from Plasma? Is it >> Okular, Krusader,

Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Sebastian Kügler
On Wednesday, March 09, 2016 16:33:04 Matthias Klumpp wrote: > That's pretty much the reason for wanting specific names like "Plasma > Info Center". It's not about Plasma, it shows info about distro, hardware, graphics, etc. It's pretty much a dumping ground with multiple vague use cases.

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Marco Martin
On Wed, Mar 9, 2016 at 4:43 PM, Yuri Chornoivan wrote: > Hi, > > Just of curiosity, what is the next thing, after documentation (as Plasma > almost does not have it), to get rid from Plasma? Is it Okular, Krusader, > something else? Just to make simple, sleek and unintrusive. > >

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Martin Gräßlin
Am 2016-03-09 16:43, schrieb Yuri Chornoivan: написане Wed, 09 Mar 2016 17:29:28 +0200, Sebastian Kügler : Hi all, [For the sake of sanity, please reply to both list, this topic affects applications and Plasma.] One of the topics we are discussing at the current Plasma sprint

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
On Wednesday, March 09, 2016 17:43:37 Yuri Chornoivan wrote: > Just of curiosity, what is the next thing, after documentation (as Plasma > almost does not have it), to get rid from Plasma? Is it Okular, Krusader, > something else? Just to make simple, sleek and unintrusive. > > Thanks in

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
On Wednesday, March 09, 2016 17:05:14 Luigi Toscano wrote: > That said, I perceive this email as "khelpcenter is not welcome in Plasma", > probably with a maintainer ("hell-bent on keeping it" sounds very negative > to me). So not sure what should be the discussion about. The discussion is about

Re: Review Request 127263: Add Wireless Energy Saving action

2016-03-09 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated Bře. 9, 2016, 4:15 odp.) Review request for Plasma, Solid, KDE

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Marco Martin
On Wed, Mar 9, 2016 at 5:05 PM, Luigi Toscano wrote: > > There is a non-committed work to have search working again, which will cut the > bug list. You should have probably already noticed a bunch of commits which > fixes some language related issues. thanks for

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Yuri Chornoivan
написане Wed, 09 Mar 2016 17:29:28 +0200, Sebastian Kügler : Hi all, [For the sake of sanity, please reply to both list, this topic affects applications and Plasma.] One of the topics we are discussing at the current Plasma sprint is whether we really want khelpcenter as part

Re: remove khelpcenter from next Plasma release?

2016-03-09 Thread Luigi Toscano
On Wednesday 09 of March 2016 15:29:28 Sebastian Kügler wrote: > Hi all, > > [For the sake of sanity, please reply to both list, this topic affects > applications and Plasma.] > > One of the topics we are discussing at the current Plasma sprint is whether > we really want khelpcenter as part of

Re: Review Request 127263: Add Wireless Energy Saving action

2016-03-09 Thread Kai Uwe Broulik
> On März 9, 2016, 3:01 nachm., Anthony Fieroni wrote: > > I think it's needed complete comfiguration module, to replace tlp itself. > > Or when you use tlp this can conflict it. > Or when you use tlp this can conflict it. I don't consider some random 3rd party service running and messing

Re: Review Request 127315: Icon applet: Set sensible minimum height

2016-03-09 Thread Kai Uwe Broulik
> On März 9, 2016, 3:12 nachm., Marco Martin wrote: > > applets/icon/package/contents/ui/main.qml, line 42 > > > > > > is the text visible in horizontal panels? It isn't - Kai Uwe

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-09 Thread Matthias Klumpp
> On März 8, 2016, 5:20 nachm., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part is that there is a desktop >

[Differential] [Accepted] D1090: [krunner] Make it work on Wayland

2016-03-09 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Matthias Klumpp
First of all, I don't have a strong opinion on generic names - name the stuff whatever you want to! 2016-03-09 16:00 GMT+01:00 Sebastian Kügler : > [...] > > I find this whole discussion rather backwards. I could address the concerns by > coming up with some random bullshit name,

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-09 Thread Martin Gräßlin
> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part is that there is a desktop > file

remove khelpcenter from next Plasma release?

2016-03-09 Thread Sebastian Kügler
Hi all, [For the sake of sanity, please reply to both list, this topic affects applications and Plasma.] One of the topics we are discussing at the current Plasma sprint is whether we really want khelpcenter as part of the Plasma releases in the future. Some data points: - khelpcenter is

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-09 Thread Martin Gräßlin
> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part is that there is a desktop > file

Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Kai Uwe Broulik
> P.S: Sidenote: Could people please add Summary= fields to .desktop files too? > ;-)This is the No1 reason KDE apps are rejected for inclusion into AppStream > at time ;-) No, because there is no such thing as a "Summary" key in the desktop entry specification. If you reject applications

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-09 Thread Matthias Klumpp
> On März 8, 2016, 5:20 nachm., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part is that there is a desktop >

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-09 Thread Martin Gräßlin
> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part is that there is a desktop > file

Re: Review Request 127315: Icon applet: Set sensible minimum height

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127315/#review93339 --- Beware the text might be one or two lines and then you might

[plasmashell] [Bug 360310] [window list] Right resizing for

2016-03-09 Thread andreas via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=360310 andreas changed: What|Removed |Added Assignee|plasma-b...@kde.org |plasma-devel@kde.org

[plasmashell] [Bug 360308] [windows list] plasma don't work (unclutter and cascade windows)

2016-03-09 Thread andreas via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=360308 andreas changed: What|Removed |Added Component|General |Window List

Re: Review Request 127315: Icon applet: Set sensible minimum height

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127315/#review93338 --- applets/icon/package/contents/ui/main.qml (line 42)

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-09 Thread Hrvoje Senjan
> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part is that there is a desktop > file

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 15 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 14:54:28 + Build duration: 2 min 7 sec CHANGE SET Revision

Re: Review Request 127263: Add Wireless Energy Saving action

2016-03-09 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93336 --- I think it's needed complete comfiguration module, to

Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Sebastian Kügler
On Wednesday, March 09, 2016 15:25:01 Matthias Klumpp wrote: > 2016-03-09 10:26 GMT+01:00 Sebastian Kügler : > > [...] > > I'd like to address your feedback and come to a solution everyone is happy > > with, but for that, please provide suggestions what to use instead, and > > don't

[Differential] [Closed] D933: Fix minimum size of Applet handle with Folder View

2016-03-09 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPad38d1ada6f0: Fix minimum size of applet handle when there is Open with button (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D941: Fix position of new applets added with drag and drop

2016-03-09 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPf3f6867da885: Fix position of new applets added with drag and drop (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Review Request 127263: Add Wireless Energy Saving action

2016-03-09 Thread Jan Grulich
> On Bře. 9, 2016, 2:47 odp., Thomas Pfeiffer wrote: > > Thank you for the screenshot! > > It looks good to me, the only thing I'd change is relabeling "Manual > > configuration" to "Leave unchanged" (and changing functionality if that > > isn't what it does atm) and putting that as the first

Re: Review Request 127263: Add Wireless Energy Saving action

2016-03-09 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93334 --- Thank you for the screenshot! It looks good to me, the only

Review Request 127315: Icon applet: Set sensible minimum height

2016-03-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127315/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-09 Thread Martin Gräßlin
> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? I don't think it's needed. The important part is that there is a desktop file which is reverse domain name dot

Re: two exceptions for string freeze in Plasma

2016-03-09 Thread Matthias Klumpp
2016-03-09 10:26 GMT+01:00 Sebastian Kügler : > [...] > I'd like to address your feedback and come to a solution everyone is happy > with, but for that, please provide suggestions what to use instead, and don't > just point out "that's bad", because the previous naming was wrong,

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 14 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/14/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 12:10:02 + Build duration: 1 min 42 sec CHANGE SET Revision

[Differential] [Closed] D1093: Opening the activity switcher as a delayed call

2016-03-09 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb5b3dc08b3f3: Opening the activity switcher as a delayed call (authored by ivan). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 2 lines] D1094: [KRunner] Don't override user input in history

2016-03-09 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, xuetianweng. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY BUG: 360268 FIXED-IN: 5.6.0 TEST PLAN

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 7 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 11:40:47 + Build duration: 1 min 40 sec CHANGE SET Revision

[Differential] [Accepted] D1093: Opening the activity switcher as a delayed call

2016-03-09 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1093 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, mart,

[Differential] [Request, 2 lines] D1093: Opening the activity switcher as a delayed call

2016-03-09 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: broulik, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This way the close-on-focus-lost does not happen REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

Re: Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127313/ --- (Updated März 9, 2016, 11:33 vorm.) Review request for Plasma. Changes

Re: Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

2016-03-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127313/#review93329 --- Ship it! Ship It! - David Rosca On March 9, 2016,

Review Request 127313: [Icon Item] Don't call loadPixmap in setColorGroup

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127313/ --- Review request for Plasma. Repository: plasma-framework Description

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still Failing!

2016-03-09 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 09 Mar 2016 09:52:45 + Build duration: 1 min 35 sec CHANGE SET Revision

Re: Review Request 127263: Add Wireless Energy Saving action

2016-03-09 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated Bře. 9, 2016, 10:44 dop.) Review request for Plasma, Solid, KDE

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review93328 --- src/declarativeimports/core/iconitem.h (line 129)

Re: Review Request 127312: Remove QtScript dependency

2016-03-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127312/#review93327 --- Ship it! Ship It! - Marco Martin On March 9, 2016,

Re: Review Request 127312: Remove QtScript dependency

2016-03-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127312/ --- (Updated March 9, 2016, 10:30 a.m.) Status -- This change has been

Re: Review Request 122859: Don't animate from previous pixmap when IconItem has been invisible

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/ --- (Updated März 9, 2016, 10:29 vorm.) Review request for Plasma. Changes

Re: Review Request 127312: Remove QtScript dependency

2016-03-09 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127312/#review93326 --- Ship it! Ship It! - Sebastian Kügler On March 9, 2016,

Review Request 127312: Remove QtScript dependency

2016-03-09 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127312/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 127263: Add Wireless Energy Saving action

2016-03-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93324 --- I still haven't actually tried/compiled it because of this

  1   2   >