Re: Review Request 125755: Fix build with QT5.6

2016-03-18 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125755/ --- (Updated March 17, 2016, 11:18 a.m.) Status -- This change has been

[Differential] [Request, 2,262 lines] D1168: Split drm_backend.{h,cpp] into separate files

2016-03-18 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: graesslin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This changes splits up the monster file containing different types used in the DRM backend into separate files per class: -

[Differential] [Accepted] D1153: [plugins/qpa] Add a roundtrip platform function

2016-03-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH qpa-roundtrip-5.6 REVISION DETAIL https://phabricator.kde.org/D1153 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D1171: simple cleanup in geometryByDistance

2016-03-18 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6687d1a5094c: simple cleanup in geometryByDistance (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

2016-03-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/ --- (Updated March 16, 2016, 12:46 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 17 - Still Failing!

2016-03-18 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/17/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Mar 2016 12:04:26 + Build duration: 53 sec CHANGE SET Revision

Re: remove khelpcenter from next Plasma release?

2016-03-18 Thread Luigi Toscano
On Thursday 17 of March 2016 11:54:31 Aaron Honeycutt wrote: > Kubuntu uses it for our Documentation but our current tools do have a PDF > export option as well as epub so we could use a different tool to read > those files without khelpcenter. I do thank every developer for his/her > work and

[Powerdevil] [Bug 360537] Keyboard Backlight endless loop when changed, only inside plasma session

2016-03-18 Thread Fuchs via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=360537 --- Comment #10 from Fuchs --- Augh, obviously replace 2 above with $MAX, my bad. (And in this case maybe check for non-null, even though this should™ not be possible) -- You are receiving this mail because: You are the assignee

[Differential] [Commented On] D1161: PanelView length cleanup

2016-03-18 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS shell/panelview.cpp:282 it does, because resize calls resizeEvent, which calls position. shell/panelview.h:189 the reason I keep it is because t's possible for the contents to want to be longer than the user set maximum, or shorter

Re: Review Request 127389: Fix the krunner KCM UI

2016-03-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127389/ --- (Updated March 16, 2016, 12:07 p.m.) Status -- This change has been

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

2016-03-18 Thread Aleix Pol Gonzalez
> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote: > > shell/testcorona.cpp, line 22 > > > > > > PlasmaQuick doesn't have any headers installed, so the build fails. > > Aleix Pol Gonzalez wrote: > Are you

[Differential] [Accepted] D1152: [client] Perform ConnectionThread::roundtrip through QPA interface

2016-03-18 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH roundtrip-qpa-5.6 REVISION DETAIL https://phabricator.kde.org/D1152 EMAIL PREFERENCES

[Differential] [Closed] D1153: [plugins/qpa] Add a roundtrip platform function

2016-03-18 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINfe745177e0f5: [plugins/qpa] Add a roundtrip platform function (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1153?vs=2795=2802 REVISION

Re: Review Request 127352: [kstyle] Implement window shadows on Wayland

2016-03-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127352/ --- (Updated March 16, 2016, 1:33 p.m.) Status -- This change has been

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

2016-03-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/#review93672 --- Ship it! Ship It! - David Edmundson On March 17, 2016,

[Differential] [Request, 28 lines] D1171: simple cleanup in geometryByDistance

2016-03-18 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY cache screenGeometry in local var replace size().width() with width() REPOSITORY rPLASMAWORKSPACE Plasma Workspace

Re: Review Request 124495: Proofread ksysguard docbook for kf5

2016-03-18 Thread Luigi Toscano
> On Aug. 9, 2015, 4:38 p.m., Luigi Toscano wrote: > > Review on terminology fine by me; waiting a bit on the maintainer for the > > content. Plasma developers, any comment for this review? Can we commit it? - Luigi --- This is an

Re: Review Request 127412: reintroduce dbus calls for kwin script console

2016-03-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127412/ --- (Updated March 18, 2016, 10:43 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 512 - Still Failing!

2016-03-18 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/512/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Mar 2016 14:09:24 + Build duration: 40 sec CHANGE SET Revision

[Differential] [Commented On] D1170: Api to rename activities in desktop scripting

2016-03-18 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS shell/scripting/scriptengine.cpp:274 Edit: doesn't this leak? why not make it on the stack. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1170 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 480 - Still Failing!

2016-03-18 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/480/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 17 Mar 2016 16:09:52 + Build duration: 1 min 52 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 506 - Still Failing!

2016-03-18 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/506/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 17 Mar 2016 17:14:02 + Build duration: 1 min 27 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 503 - Still Failing!

2016-03-18 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/503/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 17 Mar 2016 12:46:41 + Build duration: 1 min 4 sec CHANGE SET Revision

Re: Review Request 127422: Dialog: Set SkipTaskbar/Pager states before showing window

2016-03-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127422/#review93696 --- Ship it! Ship It! - David Edmundson On March 18, 2016,