Re: Review Request 127485: KCM: Add button to set default devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/ --- (Updated March 24, 2016, 9:52 p.m.) Review request for Plasma and KDE

Re: Review Request 127485: KCM: Add button to set default devices

> On März 24, 2016, 9:37 nachm., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume

Re: Review Request 127485: KCM: Add button to set default devices

> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume

Re: Review Request 127485: KCM: Add button to set default devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/#review93950 --- I like the RadioButton but it should say "Default" or

Re: Review Request 127485: KCM: Add button to set default devices

> On March 24, 2016, 8:47 p.m., Thomas Pfeiffer wrote: > > Three visually independent pushbuttons to not indicate a selection. > > Why don't you use radio buttons? > > David Rosca wrote: > > Three visually independent pushbuttons to not indicate a selection. > > That's a bug in

Re: Review Request 127485: KCM: Add button to set default devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/ --- (Updated March 24, 2016, 9:08 p.m.) Review request for Plasma and KDE

Re: Review Request 127485: KCM: Add button to set default devices

> On March 24, 2016, 8:47 p.m., Thomas Pfeiffer wrote: > > Three visually independent pushbuttons to not indicate a selection. > > Why don't you use radio buttons? > Three visually independent pushbuttons to not indicate a selection. That's a bug in Breeze - it draws checked button same as

Re: Review Request 127485: KCM: Add button to set default devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/#review93944 --- Three visually independent pushbuttons to not indicate a

Review Request 127487: Fix bindings in KCM MuteButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127487/ --- Review request for Plasma. Repository: plasma-pa Description ---

Review Request 127485: KCM: Add button to set default devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/ --- Review request for Plasma and KDE Usability. Repository: plasma-pa

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/ --- (Updated Март 24, 2016, 8:25 след обяд) Review request for Plasma, David

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 24, 2016, 4:53 p.m., Thomas Pfeiffer wrote: > > Great that you're bringing streams back to the applet, much appreciated! > > > > I agree with Kai that we should hide the technical stream names, they are > > of no use to anybody not deeply interested in PulseAudio. If an application

[Differential] [Request, 26 lines] D1216: Disallow ptrace on greeter and kcheckpass process on FreeBSD

tcberner created this revision. tcberner added reviewers: graesslin, rakuco. tcberner set the repository for this revision to rKSCREENLOCKER KScreenLocker. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Use FreeBSDs `procctl` to disable gdb from

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 24, 2016, 4:53 p.m., Thomas Pfeiffer wrote: > > Great that you're bringing streams back to the applet, much appreciated! > > > > I agree with Kai that we should hide the technical stream names, they are > > of no use to anybody not deeply interested in PulseAudio. If an application

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93937 --- Great that you're bringing streams back to the applet, much

Considering a Qt 5.6 dependency for plasma-workspace

Hi, I'd like to suggest a Qt 5.6 dependency for plasma-workspace master (and maybe other repositories too). My personal interest is mostly because of the patch that drops KScreen dependency in plasmashell [1], but I still think it makes sense on other areas and it's unlikely that plasma 5.7 is

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/#review93934 --- src/plasmaquick/dialog.cpp (lines 1000 - 1001)

[Differential] [Closed] D1212: [server] Apply position change directly for desync sub-surfaces

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND818e320bd998: [server] Apply position change directly for desync sub-surfaces (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1212: [server] Apply position change directly for desync sub-surfaces

graesslin added inline comments. INLINE COMMENTS src/server/subcompositor_interface.cpp:211 I'm trying here to workaround Qt's bug in the least dangerous way. Qt has all surfaces in desync, that's why I check whether it's desync. For desync a direct update is not as bad as for a synced

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93933 --- Looks great, i want it for 5.6 :P 5.7 is far away... -

[Differential] [Closed] D1214: [server] Add const variants to methods in SubSurfaceInterface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND68ba45df4c8b: [server] Add const variants to methods in SubSurfaceInterface (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1214?vs=2939=2940#toc REPOSITORY

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 24, 2016, 2:50 p.m., Kai Uwe Broulik wrote: > > There was already a bunch of commented functionality that allowed that. You > > clicked an output and it would expand to reveal the applications. > > > > I like your tabbed approach much better as the UI is already cramped enough > >

[Differential] [Closed] D1211: [server] Remove sub-surface from parent when it's surface is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND1f46390c0473: [server] Remove sub-surface from parent when it's surface is destroyed (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 24, 2016, 2:53 p.m., Kai Uwe Broulik wrote: > > src/pulseaudio.h, line 100 > > > > > > You don't actually use the sources, rather have a "count" property? I copied it from SinkModel::sinks(), just

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93929 --- There was already a bunch of commented functionality that

[Differential] [Accepted] D1214: [server] Add const variants to methods in SubSurfaceInterface

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. A note to remove the non-const methods with the next BIC change would be useful, otherwise: good stuff. REPOSITORY rKWAYLAND KWayland BRANCH

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93930 --- src/pulseaudio.h (line 100)

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- (Updated March 24, 2016, 2:22 p.m.) Review request for Plasma and KDE

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- (Updated March 24, 2016, 2:28 p.m.) Review request for Plasma and KDE

Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- Review request for Plasma. Repository: plasma-pa Description ---

[Differential] [Closed] D1209: Revert "desktop grid: zoom hovered window"

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN746fc49bb6a3: Revert "desktop grid: zoom hovered window" (authored by sebas). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1209?vs=2936=2937 REVISION DETAIL

[Differential] [Accepted] D1209: Revert "desktop grid: zoom hovered window"

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. I don't have a strong opinion about it. As always I say: Desktop Grid needs to be rewritten in QML and merged with Present Windows. I see that it's difficult to get the

[Differential] [Updated, 20 lines] D1209: Revert "desktop grid: zoom hovered window"

sebas updated this revision to Diff 2936. sebas retitled this revision from "do not zoom in highlighted windows" to "Revert "desktop grid: zoom hovered window"". sebas updated the summary for this revision. sebas added a comment. update commit message REPOSITORY rKWIN KWin CHANGES SINCE

[Differential] [Updated, 20 lines] D1209: do not zoom in highlighted windows

sebas updated this revision to Diff 2935. sebas added a comment. put it as revert of original commit REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1209?vs=2928=2935 BRANCH sebas/dgunjar REVISION DETAIL https://phabricator.kde.org/D1209 AFFECTED FILES

[Differential] [Requested Changes To] D1209: do not zoom in highlighted windows

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. please upload it as a revert of the original commit REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1209 EMAIL PREFERENCES

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

> On March 23, 2016, 10:47 a.m., Marco Martin wrote: > > src/client.cpp, line 62 > > > > > > I'm not sure having hardcoded special cases in c++ for broken > > applications (hello chrome, as usual ;) is a good

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

> On March 23, 2016, 10:47 a.m., Marco Martin wrote: > > src/client.cpp, line 62 > > > > > > I'm not sure having hardcoded special cases in c++ for broken > > applications (hello chrome, as usual ;) is a good

[Differential] [Commented On] D1209: do not zoom in highlighted windows

sebas added a comment. Well, the zoom effect is definitely the wrong way, it's broken (can be triggered without moving the mouse, expands windows outside of their allotted area (looks like broken sizing/placement), isn't animated so feels very choppy, isn't using well-known highlight

[Differential] [Commented On] D1212: [server] Apply position change directly for desync sub-surfaces

graesslin added a comment. F99612: screenshot-incorrect-positioning.png The problem without the workaround. With the workaround the nested QQuickView is positioned exactly as expected. REPOSITORY rKWAYLAND KWayland REVISION DETAIL

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On March 24, 2016, 6:25 a.m., David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change > > value with mouse wheel

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On Март 24, 2016, 8:25 преди обяд, David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change > > value with mouse

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 24 Mar 2016 10:16:00 + Build duration: 1 min 0 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 1 - Successful!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 24 Mar 2016 09:41:56 + Build duration: 7 min 3 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 24 Mar 2016 09:41:56 + Build duration: 1 min 11 sec CHANGE SET No changes

[Differential] [Commented On] D1210: Fix untranslatable string

aspotashev added a comment. Oops, "arc land" landed it to master, while I expected it to land to Plasma/5.6. I then cherry-picked the commit to Plasma/5.6, I know it's not very good for later merging. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Closed] D1210: Fix untranslatable string

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe73045d3e68d: Fix untranslatable string (authored by aspotashev). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1210?vs=2931=2932

Re: Plasma 5.6 beta

Thanks Ivan! plasma-desktop/libs/kactivities-stats was not included in 5.5.x, thus only 5.5.95 and 5.6.0 suffer from this problem. -- Alexander Potashev 2016-03-24 12:43 GMT+03:00 Ivan Čukić : > I've renamed the one in plasma-desktop now. Strangely enough, this > collision

Re: Plasma 5.6 beta

I've renamed the one in plasma-desktop now. Strangely enough, this collision should have existed for a few releases now - the experimental copy of kactivitiesstats inside plasma-desktop existed for some time now. Cheerio, Ivan -- KDE, ivan.cu...@kde.org, http://cukic.co/ gpg key id: 850B6F76

[Differential] [Request, 2 lines] D1210: Fix untranslatable string

aspotashev created this revision. aspotashev added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Patch by Victor Ryzhykh REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH untrans REVISION DETAIL

Re: Plasma 5.6 beta

2016-03-15 1:14 GMT+03:00 Alexander Potashev : > 2016-03-02 21:50 GMT+03:00 Jonathan Riddell : >> kactivitymanagerd is added, see earlier e-mails from Ivan about the >> changes in kactivity release bits. > > Hi Jonathan, > > There is a file conflict between

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On March 24, 2016, 6:25 a.m., David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change > > value with mouse wheel

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On Март 24, 2016, 8:25 преди обяд, David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change > > value with mouse

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On March 24, 2016, 6:25 a.m., David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change > > value with mouse wheel

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

> On March 23, 2016, 10:47 a.m., Marco Martin wrote: > > src/client.cpp, line 62 > > > > > > I'm not sure having hardcoded special cases in c++ for broken > > applications (hello chrome, as usual ;) is a good

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127467/ --- (Updated March 24, 2016, 8:17 a.m.) Review request for Plasma. Summary

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93913 --- I know this is not a chat, but plasma-pa is needed to show

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On Март 24, 2016, 8:25 преди обяд, David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change > > value with mouse

Re: Common purpose for the Plasma team, and VDG

On Monday, November 9, 2015 11:38:42 PM CET kainz.a wrote: > Yes different communication systems are one of the main problem. Different > tasks are the second problem. When I read the VDG forum threads or the > Telegram thread there was discussion about some stuff but less than 5% are > bugfixing

Re: Freeze kde-workspace repo for good

On Friday, September 4, 2015 10:31:59 AM CEST Martin Klapetek wrote: > +1, although I don't think it would prevent people from creating > patches...or would RB refuse a patch against those blocked > branches? probably not, but it makes working with those easy: repo frozen, sorry cannot be

[Differential] [Updated] D1209: do not zoom in highlighted windows

graesslin added a comment. This is a relatively new feature, introduced with: commit https://phabricator.kde.org/rKWIN14d1fdf63fc27d908f062695e85fa55dde725b55 Author: Thomas Lübking Date: Mon Sep 14 11:36:56 2015 +0200 desktop grid: zoom hovered

[Differential] [Closed] D1208: [server] Add a workaround for a freeze in QtWayland

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND1934ea48cd1d: [server] Add a workaround for a freeze in QtWayland (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1207: [server] Add method to get to the main surface from a sub surface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND1304585f622d: [server] Add method to get to the main surface from a sub surface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93911 --- Please see https://git.reviewboard.kde.org/r/125088/. I