Re: Review Request 127512: Fix memory leak in Kicker

2016-03-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127512/#review94055 --- Ship it! Ship It! - David Edmundson On March 28, 2016,

Review Request 127512: Fix memory leak in Kicker

2016-03-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127512/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Des

Re: Review Request 127475: Make one more DBus call async

2016-03-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127475/ --- (Updated March 27, 2016, 9:22 a.m.) Status -- This change has been m

[Differential] [Request, 28 lines] D1236: kcm_activities: Remove form titles that should not be translatable

2016-03-27 Thread aspotashev (Alexander Potashev)
aspotashev created this revision. aspotashev added a reviewer: ivan. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY kcm_activities: Make QML-defined UI translatable Explicitly set translation domain "kcm_activities" in .qml files. These change

[Differential] [Updated] D1235: kcms/activities: Fix wrong usage of CMake macro ki18n_wrap_ui()

2016-03-27 Thread aspotashev (Alexander Potashev)
aspotashev added a reviewer: ivan. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1235 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: aspotashev, ivan Cc: plasma-devel __

[Differential] [Request, 6 lines] D1235: kcms/activities: Fix wrong usage of CMake macro ki18n_wrap_ui()

2016-03-27 Thread aspotashev (Alexander Potashev)
aspotashev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Guilty commit: commit 4f52285b8ba71f0130ae42ce01e72783996372e9 Author: Alexander Potashev Date: Sat Mar 26 15:12:09 2016 +0300 Make kcm_activ

[Differential] [Commented On] D1185: drkonqi mappings: Move baloo_file* to "frameworks-baloo|Baloo File Daemon"

2016-03-27 Thread aspotashev (Alexander Potashev)
aspotashev added a comment. Sebastian, Do you have an answer for Vishesh? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.6 REVISION DETAIL https://phabricator.kde.org/D1185 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: aspotas