Re: Review Request for KWayland for inclusion in frameworks

Hi David, did you forget to update the version number of KWayland to 5.22 or is something still missing in KWayland? Cheers Martin On Sunday, April 17, 2016 10:42:08 AM CEST David Faure wrote: > Hi Martin, > > Very nice run down of the check list! > > I approve the move of kwayland to framewo

[Differential] [Commented On] D1524: Actually create the outputmanagement interface

graesslin added a comment. In https://phabricator.kde.org/D1524#28312, @sebas wrote: > For the unit test to be useful, we have to be running kwin_wayland. Can we expect that to be the case? Yes of course! That's the point of kwin's tests. Each test starts the full kwin_wayland! S

Re: Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

> On Април 29, 2016, 12:49 след обяд, Marco Martin wrote: > > you removed the way it had to disable animations when it passed from > > visible to invisible. > > this will probably bring back the weird animation of icons when the > > tooltips come up > > Anthony Fieroni wrote: > I can't not

Re: Proposal: kde-libs.org, a repository of contributed libraries

On Tue, May 3, 2016 at 1:59 AM, Martin Klapetek wrote: > On Sun, May 1, 2016 at 7:51 AM, kdea wrote: > >> Excuse me, I sent the message in html format. Sending now in text >> format... >> >> Hi, yesterday I published a new version of my "Take a break" plasmoid ( >> http://kde-apps.org/content/sh

Re: Proposal: kde-libs.org, a repository of contributed libraries

On Sun, May 1, 2016 at 7:51 AM, kdea wrote: > Excuse me, I sent the message in html format. Sending now in text format... > > Hi, yesterday I published a new version of my "Take a break" plasmoid ( > http://kde-apps.org/content/show.php/Take+a+break?content=174127 ). It > now includes a little-bu

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 70 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 00:21:13 + Build duration: 10 min CHANGE SET Revision e8c5a28df28d2d66e8eaee47550425941e3

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/ --- (Updated May 3, 2016, 12:20 a.m.) Status -- This change has been mar

Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127734/ --- (Updated May 3, 2016, 12:20 a.m.) Status -- This change has been mar

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote: > > You broke the zoomed out view, ie. in the year/decade overview you now get > > a tick at *every* cell... > > Martin Klapetek wrote: > Oops, I'll fix, thanks. This is now fixed. - Martin -

Re: Proposal: kde-libs.org, a repository of contributed libraries

On Mon, May 2, 2016 at 6:28 PM, kdea wrote: > I didn't know https://inqlude.org/ . Some things I see: > > - It seems to be for big libraries, not for little, user-contributed > libraries. How is something good for big libraries but not for small? Also users won't contribute libraries, it will be

[Differential] [Closed] D1524: Actually create the outputmanagement interface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINa5189cc39304: Actually create the outputmanagement interface (authored by sebas). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1524?vs=3599&id=3618 REVISION DETAIL

[Differential] [Commented On] D1524: Actually create the outputmanagement interface

sebas added a comment. For the unit test to be useful, we have to be running kwin_wayland. Can we expect that to be the case? REPOSITORY rKWIN KWin BRANCH sebas/create_om REVISION DETAIL https://phabricator.kde.org/D1524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

Re: KDED deadlock in statusnotifierwatcher

They told me they are aware of the issue - the patch will be shipped with qt 5.6. Cheers, Ivan On Sun, May 1, 2016 at 11:58 AM, David Edmundson wrote: > Could you poke the Debian packagers towards that email please. > > David > > > ___ > Plasma-devel m

Re: Review Request 127802: [Converter Runner] Try QLocale::toDouble to get input value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127802/ --- (Updated May 2, 2016, 7:12 p.m.) Status -- This change has been mark

Re: Review Request 127802: [Converter Runner] Try QLocale::toDouble to get input value

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127802/#review95104 --- Ship it! Ship It! - David Edmundson On April 30, 2016,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 69 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/69/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 17:09:10 + Build duration: 10 min CHANGE SET Revision 46229c9e47409f5d82d3d7644b949944086

Re: Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

> On Април 27, 2016, 1:15 след обяд, David Edmundson wrote: > > In what conditions is it broken and why does it break? > > Anthony Fieroni wrote: > https://git.reviewboard.kde.org/r/127753/ > It has screenshots. > > David Edmundson wrote: > I can see a picture where it is broken. I

[Differential] [Closed] D1478: [Notifications] Don't group job finished notifications

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE46229c9e4740: [Notifications] Don't group job finished notifications (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1478?vs=3496&id=3612#toc REPOSITORY rPLA

[frameworks-kactivities] [Bug 360339] Plasma Crash on startup

https://bugs.kde.org/show_bug.cgi?id=360339 Ivan Čukić changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Ever confirmed|0

Re: Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

> On Април 27, 2016, 1:15 след обяд, David Edmundson wrote: > > In what conditions is it broken and why does it break? > > Anthony Fieroni wrote: > https://git.reviewboard.kde.org/r/127753/ > It has screenshots. > > David Edmundson wrote: > I can see a picture where it is broken. I

[frameworks-kactivities] [Bug 361658] kactivitymanage segfault (libQt5Sql.so.5.4.2) when running nomachines in KDE (other desktops work)

https://bugs.kde.org/show_bug.cgi?id=361658 Ivan Čukić changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED

Re: Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

> On April 27, 2016, 10:15 a.m., David Edmundson wrote: > > In what conditions is it broken and why does it break? > > Anthony Fieroni wrote: > https://git.reviewboard.kde.org/r/127753/ > It has screenshots. I can see a picture where it is broken. I believe that at some point it gets b

[frameworks-kactivities-stats] [Bug 362198] Plasma Crashes

https://bugs.kde.org/show_bug.cgi?id=362198 Ivan Čukić changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: Proposal: kde-libs.org, a repository of contributed libraries

I didn't know https://inqlude.org/ . Some things I see:   - It seems to be for big libraries, not for little, user-contributed libraries. - It seems to be for C++ qt libraries, not for pure qml plasmoid libraries. - It seems to be an index of libraries, not a repository of libraries.   I proposed s

[Differential] [Abandoned] D1491: Don't try to read X11 properties on ShellClient

graesslin abandoned this revision. graesslin added a comment. Better approach: https://phabricator.kde.org/D1527 REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1491 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma

[Differential] [Request, 53 lines] D1527: Make Toplevel::window() no longer virtual and introduce ::windowId()

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Toplevel::window() is the actual X11 window. This makes it difficult to use as the generic identifier f

[Differential] [Commented On] D1524: Actually create the outputmanagement interface

graesslin added a comment. btw. this screams unit test at me: should be easy to verify. Just try to connect with a client. REPOSITORY rKWIN KWin BRANCH sebas/create_om REVISION DETAIL https://phabricator.kde.org/D1524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Accepted] D1524: Actually create the outputmanagement interface

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH sebas/create_om REVISION DETAIL https://phabricator.kde.org/D1524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, graesslin, Plasma

[Differential] [Commented On] D1524: Actually create the outputmanagement interface

graesslin added a comment. btw. this screams unit test at me: should be easy to verify. Just try to connect with a client. REPOSITORY rKWIN KWin BRANCH sebas/create_om REVISION DETAIL https://phabricator.kde.org/D1524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

Re: Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

> On April 29, 2016, 9:49 vorm., Marco Martin wrote: > > you removed the way it had to disable animations when it passed from > > visible to invisible. > > this will probably bring back the weird animation of icons when the > > tooltips come up > > Anthony Fieroni wrote: > I can't notice a

Re: Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions

> On Април 29, 2016, 12:49 след обяд, Marco Martin wrote: > > you removed the way it had to disable animations when it passed from > > visible to invisible. > > this will probably bring back the weird animation of icons when the > > tooltips come up > > Anthony Fieroni wrote: > I can't not

[Differential] [Commented On] D1491: Don't try to read X11 properties on ShellClient

graesslin added inline comments. INLINE COMMENTS effects.cpp:1672 I don't really see a good way to expose this through a virtual and well the virtual check would do pretty much the same ;-) I'll think about it. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1491

[Differential] [Closed] D1482: Connect Application::screensCreated to WaylandServer::initOutputs

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN319869881c87: Connect Application::screensCreated to WaylandServer::initOutputs (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1482?vs=3501&id=3601#toc REPOSITORY rK

[Differential] [Closed] D1481: Make integration with KScreenLocker optional in WaylandServer

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf8f8e6146604: Make integration with KScreenLocker optional in WaylandServer (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1481?vs=3500&id=36

[Differential] [Closed] D1486: Only create damage_handle for Toplevel's without a Wayland Surface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINa0919d6c4d77: Only create damage_handle for Toplevel's without a Wayland Surface (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1486?vs=3505&

[Differential] [Closed] D1490: Don't call xcb_damage_subtract for Wayland windows

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN1845881fbf41: Don't call xcb_damage_subtract for Wayland windows (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1490?vs=3512&id=3604 REVISIO

[Differential] [Closed] D1487: Don't depend on operation mode in WindowPixmap

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINac1a8a014259: Don't depend on operation mode in WindowPixmap (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1487?vs=3506&id=3605 REVISION DE

[Differential] [Closed] D1483: Only destroy damage_handle if a damage_handle got created

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINbfa31d48cdbc: Only destroy damage_handle if a damage_handle got created (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1483?vs=3502&id=3602

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:51 p.m., Milian Wolff wrote: > > one more question: have you tried this with krita (or digicam) and their > > builtin functionality to change the app's color scheme? I.e. what about > > per-app changes vs. system-wide changes? I have to test this more, indeed probably won't

Re: Review Request 127810: Fix some gcc5.3 compile warnings in kwayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127810/ --- (Updated May 2, 2016, 3:54 p.m.) Status -- This change has been mark

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review95083 --- one more question: have you tried this with krita (or digicam

Re: Review Request 127812: Fix the return value of Plasma::Service::operationDescription() for the docs

> On May 2, 2016, 6:32 p.m., Marco Martin wrote: > > Ship It! Thanks. Can you also tell me how the example(i.e L69 - L64) would look now ? I'm having to do something similar while porting some code in the publictransport repo. - R.Harish

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:09 p.m., Sebastian Kügler wrote: > > Okay, let's try this in master and see if it's going to cause problems. > > Kai Uwe Broulik wrote: > Beware this is frameworks and the next frameworks release will be > upcoming Saturday > > Marco Martin wrote: > I was aiming at

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:09 p.m., Sebastian Kügler wrote: > > Okay, let's try this in master and see if it's going to cause problems. > > Kai Uwe Broulik wrote: > Beware this is frameworks and the next frameworks release will be > upcoming Saturday > > Marco Martin wrote: > I was aiming at

Re: Review Request 127810: Fix some gcc5.3 compile warnings in kwayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127810/#review95079 --- Ship it! - Sebastian Kügler On May 1, 2016, 8:32 p.m., A

Re: Review Request 127779: use system colors for monochrome icons

> On May 2, 2016, 1:09 p.m., Sebastian Kügler wrote: > > Okay, let's try this in master and see if it's going to cause problems. > > Kai Uwe Broulik wrote: > Beware this is frameworks and the next frameworks release will be > upcoming Saturday I was aiming at first for this one. Do you thi

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review95076 --- autotests/kiconloader_unittest.cpp (line 441)

Re: Review Request 127779: use system colors for monochrome icons

> On Mai 2, 2016, 1:09 nachm., Sebastian Kügler wrote: > > Okay, let's try this in master and see if it's going to cause problems. Beware this is frameworks and the next frameworks release will be upcoming Saturday - Kai Uwe --- This i

Re: Review Request 127779: use system colors for monochrome icons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127779/#review95075 --- Ship it! Okay, let's try this in master and see if it's go

[Differential] [Accepted] D1482: Connect Application::screensCreated to WaylandServer::initOutputs

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rKWIN KWin BRANCH init-outputs-on-connect REVISION DETAIL https://phabricator.kde.org/D1482 EMAIL PREFERENCES https://phabricat

Re: Review Request 127812: Fix the return value of Plasma::Service::operationDescription() for the docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127812/#review95074 --- Ship it! Ship It! - Marco Martin On May 2, 2016, 1 p.m.

Review Request 127812: Fix the return value of Plasma::Service::operationDescription() for the docs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127812/ --- Review request for Plasma, Bhushan Shah and Eike Hein. Repository: plasma

[Differential] [Request, 1 line] D1524: Actually create the outputmanagement interface

sebas created this revision. sebas added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's instantiated, but never created. This means that libkscreen's wayland backend is going to hang in

[Differential] [Closed] D1499: add override to bufferForScreen

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8e36d9c8e16c: add override to bufferForScreen (authored by sebas). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1499?vs=3532&id=3598 REVISION DETAIL https://phab

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 68 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 02 May 2016 12:04:09 + Build duration: 22 min CHANGE SET Revision 7e83c88ea3634bffec7fdf6c5500cd9e7c5

[Differential] [Accepted] D1478: [Notifications] Don't group job finished notifications

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. go for it but only master REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1478 EMAIL PREFERENCES https://phabricato

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

broulik added a comment. Right, the limit should only be enforced in the popup. I'll add a scrollbar and leave the history unchanged. REVISION DETAIL https://phabricator.kde.org/D1479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Pla

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

broulik added a comment. Ping. Also, should we target Plasma/5.6 with that? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1478 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: D

Minutes Monday Plasma Meeting

Minutes Plasma 'hangout', 2-5-2016, 12:00 CET Present: Sho, mgraesslin, bshah, notmart, kbroulik, Roman (subdiff) (just listening), sebas Akademy / QtCon planning: * mgraesslin: desktop security & wayland * bshah: plasma mobile * notmart: kirigami * kbroulik: Android Qt apps * sebas: KDE store t

Re: RFC: A Wayland virtual framebuffer server for our tests

On Friday, April 15, 2016 08:49:14 AM Martin Graesslin wrote: > So what do you think? What do you need for testing from the test windowing > system? Which option should we go for? > > I'm not telling you my personal opinion on what's best, don't want to > influence you. I think all three would