Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/ --- (Updated May 20, 2016, 4:29 p.m.) Review request for Plasma. Repository

Re: Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127826/ --- (Updated May 20, 2016, 6:59 p.m.) Status -- This change has been mar

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #4 from Markus --- I just upgraded to Kernel 4.6final... and still have that issue. Still unsure if this is a kernel or KDE issue. Any help to solve this issue is welcome. I really don't want to logoff/login just to fix the battery indicator

[Differential] [Accepted] D1648: [autotest] Add a test case for KWin::LibInput::Device

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH libinput-device-test REVISION DETAIL https://phabricator.kde.org/D1648 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated] D1647: kfontinst: Port to QDialog

volkov marked 2 inline comments as done. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1647 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: volkov, Plasma Cc: apol, plasma-devel, sebas _

[Differential] [Updated, 262 lines] D1647: kfontinst: Port to QDialog

volkov updated this revision to Diff 3908. volkov added a comment. Use the new signal and slot syntax for QDialogButtonBox objects. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1647?vs=3906&id=3908 REVISION DETAIL https://phabricator.k

[Differential] [Commented On] D1647: kfontinst: Port to QDialog

volkov added inline comments. INLINE COMMENTS > volkov wrote in Printer.cpp:349 > There is no need to set a parent in the constructor. QLayout::addWidget() > will do it later. >From the Qt documentation ( https://doc.qt.io/qt-5/layout.html ): "When you use a layout, you do not need to pass a pa

[Differential] [Commented On] D1647: kfontinst: Port to QDialog

volkov added inline comments. INLINE COMMENTS > apol wrote in Printer.cpp:349 > Pass this as the last argument, so it has a parent and doesn't leak. On this > one and the rest of `new QDialogButtonBox`. There is no need to set a parent in the constructor. QLayout::addWidget() will do it later.

[Differential] [Request, 666 lines] D1648: [autotest] Add a test case for KWin::LibInput::Device

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The usage of libinput is completely mocked. The test covers all the constant properties read by Device.

Re: Review Request 127976: Support selected state

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/#review95650 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 20, 2016,

[Differential] [Commented On] D1647: kfontinst: Port to QDialog

apol added a comment. Other than that it looks quite good, interesting how much code gets cleaned up. INLINE COMMENTS > Printer.cpp:349 > + > +QDialogButtonBox *buttonBox = new > QDialogButtonBox(QDialogButtonBox::Cancel); > +connect(buttonBox, SIGNAL(rejected()), this, SLOT(slotCan

Re: Review Request 127976: Support selected state

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/ --- (Updated May 20, 2016, 2:38 p.m.) Status -- This change has been mar

[Differential] [Request, 262 lines] D1647: kfontinst: Port to QDialog

volkov created this revision. volkov added a reviewer: Plasma. volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION

Review Request 127976: Support selected state

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127976/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

> On May 20, 2016, 9:41 a.m., Kai Uwe Broulik wrote: > > src/plasma/theme.cpp, line 199 > > > > > > Can you add an enum or re-use QIcon::State to avoid a boolean trap, > > same below > > Marco Martin wrote: >

Re: plasma review

On Friday 20 May 2016 11:50:54 Kai Uwe Broulik wrote: > Hi, > > > 1. right click on the desktop show activities also when there is only one > > activity, please make it visible when the user use activities and had > > there more than one activity > As already mentioned in the bug report you filed,

Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

> On May 20, 2016, 9:41 a.m., Kai Uwe Broulik wrote: > > src/plasma/theme.cpp, line 199 > > > > > > Can you add an enum or re-use QIcon::State to avoid a boolean trap, > > same below i was thinking about it, bu

Re: plasma review

thanks for the feedback kai > > > 2. give the user more posibilities for the right click some don't need > leave but need shutdown > > You can already configure what happens when you click on Leave in system > settings startup and shutdown, ie shutdown without confirmation or whatever. > ah that

Re: plasma review

Hi, > 1. right click on the desktop show activities also when there is only one > activity, please make it visible when the user use activities and had there > more than one activity As already mentioned in the bug report you filed, the ui is also for adding new activities so we can't just hid

[Differential] [Closed] D1640: [server] Improve the handling when clients disconnect

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDfd01e59a5fca: [server] Improve the handling when clients disconnect (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1640?vs=3883&i

Re: Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/#review95646 --- Can you extend the auto test to test this? src/plasma/theme

plasma review

Hi, as plasma 5 is really polished now I'm searching for the last missing stuff to finalize the UX behavior. Therefore I made a desktop review. https://share.kde.org/index.php/s/nCKkF8s9GcW7fvO The Results are: 1. right click on the desktop show activities also when there is only one activity, p

Review Request 127975: selected state for Plasma::Svg and PlasmaCore::IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Updated, 594 lines] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

graesslin updated this revision to Diff 3904. graesslin added a comment. Adjust to API changes REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1638?vs=3879&id=3904 BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1638 AFFECTED FILES

[Differential] [Updated, 5,794 lines] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

graesslin updated this revision to Diff 3903. graesslin added a comment. The SeatInterface now exposes TextInputInterface in similar ways to the other input devices. That is there is a setFocusedTextInputSurface and the focused TextInputInterface is exposed through focusedTextInput().

[Differential] [Closed] D1643: Rename project from FrameworkIntegration to PlasmaIntegration

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONc0ffbc2d87f7: Rename project from FrameworkIntegration to PlasmaIntegration (authored by broulik). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/ --- (Updated May 20, 2016, 9:22 a.m.) Review request for kde-workspace and Pl

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >