[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-29 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > xuetianweng wrote in main_wayland.cpp:449 > Don't do this. Otherwise qtvirtualkeyboard will be the only usable input > method for Qt. > > IMHO for wayland there should be a wayland specific im module that talk to > input method via wl_text.

[Differential] [Closed] D1690: kfontinst: Port away from kde_file.h

2016-05-29 Thread volkov (Alexander Volkov)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPf2e3f6aa7a27: kfontinst: Port away from kde_file.h (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1690?vs=4010=4052

[Differential] [Closed] D1657: kfontinst: Port away from KStandardDirs

2016-05-29 Thread volkov (Alexander Volkov)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPae20467d8cf5: kfontinst: Port away from KStandardDirs (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1686: kfontinst: Port away from KIO::NetAccess

2016-05-29 Thread volkov (Alexander Volkov)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP84d28ca240eb: kfontinst: Port away from KIO::NetAccess (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1685: kfontinst: Port to QDebug

2016-05-29 Thread volkov (Alexander Volkov)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb51239946148: kfontinst: Port to QDebug (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1685?vs=4003=4047 REVISION

[Differential] [Closed] D1675: kfontinst: Port to QTemporaryDir

2016-05-29 Thread volkov (Alexander Volkov)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP19d61b068792: kfontinst: Port to QTemporaryDir (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1675?vs=3970=4045

[Differential] [Closed] D1689: kfontinst: Port to QMimeDatabase

2016-05-29 Thread volkov (Alexander Volkov)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe22a2cb2988b: kfontinst: Port to QMimeDatabase (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1689?vs=4007=4051

[Differential] [Closed] D1676: kfontinst: Port to QApplication and QCommandLineParser

2016-05-29 Thread volkov (Alexander Volkov)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP7cb098ec90e1: kfontinst: Port to QApplication and QCommandLineParser (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1688: kfontinst: Port to QSaveFile

2016-05-29 Thread volkov (Alexander Volkov)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP385da207f04d: kfontinst: Port to QSaveFile (authored by volkov). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1688?vs=4006=4050

[Differential] [Updated] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

2016-05-29 Thread hein (Eike Hein)
hein added a comment. 0 means "on all desktops", probably because of that. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1706 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, graesslin,

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/ --- (Updated Май 30, 2016, 7:33 преди обяд) Review request for Plasma, Aleix

Re: Plasma depending on Qt 5.6.1 shortly

2016-05-29 Thread Aleix Pol
On Mon, May 23, 2016 at 1:03 PM, Sebastian Kügler wrote: > Hey, > > During today's Plasma meeting, we've decided to go ahead and switch Plasma's > Qt dependency to 5.6.1 (which is to be released shortly). > > That means: if you're building Plasma from git master, you'll have to

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/ --- (Updated May 30, 2016, 1:10 a.m.) Review request for Plasma, Martin

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread Daniel Vrátil
> On May 30, 2016, 12:20 a.m., Kai Uwe Broulik wrote: > > File Attachment: Agenda view - after - Agenda view - after > > > > > > What's that? > > Daniel Vrátil wrote: > Indicates that the event continues to the next day. IMO better

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread David Edmundson
> On May 29, 2016, 10:20 p.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/ui/CalendarView.qml, line 250 > > > > > > font.bold: true > > Daniel Vrátil wrote: > Doesn't work for some

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread Kai Uwe Broulik
> On Mai 29, 2016, 10:20 nachm., Kai Uwe Broulik wrote: > > File Attachment: Agenda view - after - Agenda view - after > > > > > > What's that? > > Daniel Vrátil wrote: > Indicates that the event continues to the next day. IMO

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/#review96012 --- +1, it's fair to add a failsafe for release. It's about the

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread Daniel Vrátil
> On May 30, 2016, 12:20 a.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/ui/CalendarView.qml, line 250 > > > > > > font.bold: true Doesn't work for some reason :( - Daniel

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread Daniel Vrátil
> On May 30, 2016, 12:20 a.m., Kai Uwe Broulik wrote: > > File Attachment: Agenda view - after - Agenda view - after > > > > > > What's that? Indicates that the event continues to the next day. IMO better than just showing "12:59 PM",

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96008 --- Good job! File Attachment: Agenda view - after - Agenda

[Differential] [Accepted] D1705: [System Tray] Don't iterate keys()

2016-05-29 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Good stuff! Clazy? Or you actually found this to be a paint point? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/ --- (Updated May 30, 2016, 12:14 a.m.) Review request for Plasma, Martin

Review Request 128052: Improve agenda view in digital-clock applet

2016-05-29 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/ --- Review request for Plasma, Martin Klapetek and Thomas Pfeiffer.

[Differential] [Request, 4 lines] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

2016-05-29 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, hein, graesslin. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When

[Differential] [Updated] D1705: [System Tray] Don't iterate keys()

2016-05-29 Thread broulik (Kai Uwe Broulik)
broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1705 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel, sebas

[Differential] [Request, 13 lines] D1705: [System Tray] Don't iterate keys()

2016-05-29 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Instead of allocating a

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Anthony Fieroni
> On Май 29, 2016, 6:30 след обяд, Kai Uwe Broulik wrote: > > shell/shellcorona.cpp, line 907 > > > > > > I think we need to figure out *why* containment is null, this assert is > > probably there for a reason.

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Kai Uwe Broulik
> On Mai 29, 2016, 3:30 nachm., Kai Uwe Broulik wrote: > > shell/shellcorona.cpp, line 907 > > > > > > I think we need to figure out *why* containment is null, this assert is > > probably there for a reason. >

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Anthony Fieroni
> On Май 29, 2016, 6:30 след обяд, Kai Uwe Broulik wrote: > > shell/shellcorona.cpp, line 907 > > > > > > I think we need to figure out *why* containment is null, this assert is > > probably there for a reason.

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/#review95983 --- -1 shell/shellcorona.cpp (line 907)

Re: plasma-desktop on other environments (bis)

2016-05-29 Thread René J . V . Bertin
Here's another question, side-ways related: Qt 5.6.1+ are likely to remove DBus support from the Mac platformsupport module. That's fine, but the change breaks my build of the qgenericunixtheme unless I deactivate DBus support in there too. That's mostly my problem of course, but can anyone

Re: Proposal: kde-libs.org, a repository of contributed libraries

2016-05-29 Thread Kevin Krammer
On Saturday, 2016-05-28, 16:05:46, kdea wrote: > They suggested me to upload the library to the "Qt Components" section of > http://qt-apps.org/ , so I did it, and the library is now available to other > developers. Wouldn't it make much more sense to register it with inqlude.org as a central

Re: Plasma 5.7 Repo Freeze this Thursday

2016-05-29 Thread Jonathan Riddell
On Sat, May 28, 2016 at 01:37:14PM +0100, David Edmundson wrote: > If any repos need to be added/removed split. Let me know ASAP The list of repositories I expect to release is below. Nothing changed from 5.6, as usual kaccounts-mobile is in kde/workspace but won't get added and simplesystray

[Breeze] [Bug 363602] Symlinked SVG files fails to load under Windows

2016-05-29 Thread Jasem Mutlaq via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363602 --- Comment #4 from Jasem Mutlaq --- Correction above: would NOT be avaiable -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list