[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-30 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > xuetianweng wrote in main_wayland.cpp:449 > Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the > session I wonder if it will be inherit by the whole desktop session. I don't understand the concern. The QT_IM_MODULE en

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread David Edmundson
> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write >

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-30 Thread xuetianweng (Xuetian Weng)
xuetianweng added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:449 > > Don't do this. Otherwise qtvirtualkeyboard will be the only usable input > > method for Qt. > > That's totally fine in this case. It only affects KWin and KWin doesn't have > any text input fields.

page-title frame drawing

2016-05-30 Thread René J . V . Bertin
Hi, Splitting this off from the "plasma-desktop on other environments" thread. What can you tell me about the "draw frame around page titles" option, more precisely when this frame is drawn? I'm seeing this kind of frame when I use the native OS X widget style, but as far as I know it doesn't

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96058 --- way better and the colors are all from the color scheme so it

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/ --- (Updated May 30, 2016, 11:05 p.m.) Review request for Plasma, KDE Usabili

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Andreas Kainz
> On Mai 30, 2016, 11:55 vorm., Andreas Kainz wrote: > > File Attachment: Agenda view - after - Agenda view - after > > > > > > first column entry is needed (today or all day in the first column) > > Daniel Vrátil wrote: > I'm not s

[Differential] [Accepted] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

2016-05-30 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1718 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, graesslin, Plasma C

[Differential] [Updated, 89 lines] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

2016-05-30 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 4076. broulik added a comment. Wrap everything inside if (QX11Info::isPlatformX11()) { REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1718?vs=4075&id=4076 REVISION DETAIL https://phabricator.kde.

[Differential] [Requested Changes To] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

2016-05-30 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > panelview.cpp:593 > #if HAVE_X11 > -xcb_connection_t *c = QX11Info::connection(); > -if (!c) { > +if (!QX11Info::isPlatformX11()) { >

[Differential] [Request, 5 lines] D1718: [PanelView] Check whether we're X11 before calling QX11Info::connection()

2016-05-30 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, graesslin. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QX11Info::conne

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 82 - Fixed!

2016-05-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 14:02:21 + Build duration: 5 min 51 sec CHANGE SET Revision 81e03b0ed59b6be6cb601c8380f528ca

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 82 - Fixed!

2016-05-30 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 14:02:21 + Build duration: 5 min 51 sec CHANGE SET Revision 81e03b0ed59b6be6cb601c8380f528ca

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 81 - Still Failing!

2016-05-30 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/81/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 13:56:16 + Build duration: 1 min 1 sec CHANGE SET Revision bc68a5233c34d7e7ac215e8c5b471e3b4

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 80 - Still Failing!

2016-05-30 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/80/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 13:51:16 + Build duration: 51 sec CHANGE SET Revision dcaa8b8a7c69db538df19d65ad5b28964deae2

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/ --- (Updated May 30, 2016, 9:51 a.m.) Status -- This change has been mar

[Differential] [Closed] D1717: fix flaky build

2016-05-30 Thread bshah (Bhushan Shah)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPdcaa8b8a7c69: fix flaky build (authored by bshah). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1717?vs=4073&id=4074 REVISION DETAIL

[Differential] [Accepted] D1717: fix flaky build

2016-05-30 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH fix-flaky-build REVISION DETAIL https://phabricator.kde.org/D1717 EMAIL PREFERENCES https://phabricator.kde.org/setti

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Anthony Fieroni
> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i writ

[Differential] [Commented On] D1717: fix flaky build

2016-05-30 Thread bshah (Bhushan Shah)
bshah added a comment. See: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/console REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1717 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Request, 1 line] D1717: fix flaky build

2016-05-30 Thread bshah (Bhushan Shah)
bshah created this revision. bshah added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY autotest needs kcm_lookandfeel compiled first, this breaks based on shade of moon TEST PLAN none REPOSITORY

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 79 - Failure!

2016-05-30 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 13:35:26 + Build duration: 2 min 47 sec CHANGE SET Revision e3bf0a5bb0a973a104c52ab3c22a8928

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Marco Martin
> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write >

[Differential] [Closed] D1668: Add the Device to the input event summary

2016-05-30 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN5f2245adaf8c: Add the Device to the input event summary (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1668?vs=3957&id=4071#toc REPOSITORY rKWIN KWin CHANGES SINCE

[Differential] [Updated] D1668: Add the Device to the input event summary

2016-05-30 Thread Martin Gräßlin
graesslin marked 2 inline comments as done. REPOSITORY rKWIN KWin BRANCH debug-console-device REVISION DETAIL https://phabricator.kde.org/D1668 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: sebas, plasma-devel __

[Differential] [Closed] D1667: Pass LibInput::Device* through the event handlers

2016-05-30 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN69cbb40903ec: Pass LibInput::Device* through the event handlers (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1667?vs=3956&id=4070#toc REPOSITORY rKWIN KWin CHANGE

[Differential] [Closed] D1666: [libinput] Add the Device to Event

2016-05-30 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN6d090cd263bb: [libinput] Add the Device to Event (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1666?vs=3955&id=4069 REVISION DETAIL https

[Differential] [Closed] D1715: [Desktop Toolbox] Close toolbox popup before triggering action

2016-05-30 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe3bf0a5bb0a9: [Desktop Toolbox] Close toolbox popup before triggering action (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.

[Differential] [Closed] D1716: [Panel Configuration] Close when pressing Escape

2016-05-30 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPf32e0c990e99: [Panel Configuration] Close when pressing Escape (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1716?

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/#review96041 --- Ship it! Ship It! - David Faure On May 30, 2016, 1:17 p

[Differential] [Updated] D1667: Pass LibInput::Device* through the event handlers

2016-05-30 Thread Martin Gräßlin
graesslin marked an inline comment as done. REPOSITORY rKWIN KWin BRANCH custom-input-events REVISION DETAIL https://phabricator.kde.org/D1667 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas Cc: sebas, plasma-devel ___

[Differential] [Accepted] D1715: [Desktop Toolbox] Close toolbox popup before triggering action

2016-05-30 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1715 EMAIL PREFERENCES https://phabricator.kde.org/settings/pane

[Differential] [Accepted] D1716: [Panel Configuration] Close when pressing Escape

2016-05-30 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1716 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broul

[Differential] [Updated] D1716: [Panel Configuration] Close when pressing Escape

2016-05-30 Thread broulik (Kai Uwe Broulik)
broulik retitled this revision from "[Panel Configuration] Close when pressing Escap" to "[Panel Configuration] Close when pressing Escape". REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1716 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/ --- (Updated Mai 30, 2016, 3:17 nachm.) Review request for KDE Frameworks, Pl

[Differential] [Request, 12 lines] D1716: [Panel Configuration] Close when pressing Escap

2016-05-30 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When pressing Escape the "More

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Aleix Pol Gonzalez
> On May 30, 2016, 1:32 p.m., Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? > > Anthony Fieroni wrote: > So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i > can't reproduce crash, KScreen is not finish recognazing, which i write >

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Anthony Fieroni
> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote: > > Could you look a bit into why is the containment null? So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i can't reproduce crash, KScreen is not finish recognazing, which i write above, corona.cpp:211 if (screen

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread Wolfgang Bauer
> On Mai 30, 2016, 2:35 nachm., David Faure wrote: > > keditfiletype/mimetypewriter.cpp, line 155 > > > > > > This could all be done with a single line, > > QDir().mkpath(packagesDirName); > > No need to

[Differential] [Request, 2 lines] D1715: [Desktop Toolbox] Close toolbox popup before triggering action

2016-05-30 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The still open dialog might st

Re: Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/#review96036 --- keditfiletype/mimetypewriter.cpp (line 155)

Review Request 128055: Create ~/.local/share/mime/packages if it doesn't exist

2016-05-30 Thread Wolfgang Bauer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128055/ --- Review request for KDE Frameworks, Plasma and David Faure. Bugs: 356237

[Differential] [Accepted] D1667: Pass LibInput::Device* through the event handlers

2016-05-30 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. nice work INLINE COMMENTS > pointer_input.cpp:198 > { > +Q_UNUSED(device) > if (!m_inited) { device is used here, though REPOSITORY rKWIN KWin BR

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Daniel Vrátil
> On May 30, 2016, 1:55 p.m., Andreas Kainz wrote: > > File Attachment: Agenda view - after - Agenda view - after > > > > > > third column for specific elements like importend, how many people are > > invited, ... I don't know if this i

Re: [plasma-workspace] /: Bump minimum requirement to Qt 5.6.0

2016-05-30 Thread Marco Martin
On Monday 30 May 2016, Aleix Pol wrote: > > Otherwise, I'm really glad we finally got the plasmashell goes QScreen > > in, thanks a lot for the perseverance! > > Putting a 5.6.1 there will make it not compile for anyone, if they > have Qt by the distro. i think that's actually fine, as forces us

[Differential] [Accepted] D1714: [server] Don't destroy SlideInterface when parent SurfaceInterface is destroyed

2016-05-30 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH slide-destroy-surface REVISION DETAIL https://phabricator.kde.org/D1714 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

[Differential] [Request, 42 lines] D1714: [server] Don't destroy SlideInterface when parent SurfaceInterface is destroyed

2016-05-30 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Destroying the SlideInterface on the server side before the client has a chance to cleanup results in a

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Andreas Kainz
> On Mai 30, 2016, 8:50 vorm., Marco Martin wrote: > > +1 in the calender view you can zoom from year view to month view would it be possible (useful) to zoom also in a week view or a day view. - Andreas --- This is an automatically ge

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96033 --- I don't use RB that often I hope you understand what I'd like

Re: [plasma-workspace] /: Bump minimum requirement to Qt 5.6.0

2016-05-30 Thread Aleix Pol
On Mon, May 30, 2016 at 1:48 PM, Sebastian Kügler wrote: > On maandag 30 mei 2016 11:29:50 CEST Aleix Pol wrote: >> Git commit c003b80cc2c8237218c01996fb419e9892f8f599 by Aleix Pol. >> Committed on 30/05/2016 at 11:11. >> Pushed by apol into branch 'master'. >> >> Bump minimum requirement to Qt 5.

[Differential] [Updated, 283 lines] D1672: Add support for touch events in fakeinput protocol and interface.

2016-05-30 Thread bdhruve (Bhavisha Dhruve)
bdhruve updated this revision to Diff 4063. bdhruve added a comment. Track touchIds and update autotests. (I am not sure if i did correctly or not.) REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1672?vs=4000&id=4063 BRANCH fake-input-touch REV

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 105 - Still Unstable!

2016-05-30 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/105/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 30 May 2016 11:30:10 + Build duration: 19 min CHANGE SET Revision c003b80cc2c8237218c01996fb419e9892

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Andreas Kainz
> On Mai 30, 2016, 9:38 vorm., Andreas Kainz wrote: > > Is It possible too sync the colors between agenda and calender view. > > > > II I I lkelike the > > Sebastian Kügler wrote: > I think that would look very cool, but there may be more than one item > with different colors for a given d

Re: [plasma-workspace] /: Bump minimum requirement to Qt 5.6.0

2016-05-30 Thread Sebastian Kügler
On maandag 30 mei 2016 11:29:50 CEST Aleix Pol wrote: > Git commit c003b80cc2c8237218c01996fb419e9892f8f599 by Aleix Pol. > Committed on 30/05/2016 at 11:11. > Pushed by apol into branch 'master'. > > Bump minimum requirement to Qt 5.6.0 That should have been 5.6.1, though. 5.6.0 contains a block

Re: Review Request 128040: [shellcorona] Containment can be nullptr

2016-05-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128040/#review96027 --- Could you look a bit into why is the containment null? - Ale

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

2016-05-30 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated May 30, 2016, 1:29 p.m.) Status -- This change has been mar

[plasma-workspace] /: Bump minimum requirement to Qt 5.6.0

2016-05-30 Thread Aleix Pol
Git commit c003b80cc2c8237218c01996fb419e9892f8f599 by Aleix Pol. Committed on 30/05/2016 at 11:11. Pushed by apol into branch 'master'. Bump minimum requirement to Qt 5.6.0 CCMAIL: plasma-devel@kde.org M +1-1CMakeLists.txt http://commits.kde.org/plasma-workspace/c003b80cc2c8237218c019

Re: Plasma depending on Qt 5.6.1 shortly

2016-05-30 Thread Aleix Pol
On Mon, May 30, 2016 at 10:38 AM, Marco Martin wrote: > On Monday 30 May 2016, Aleix Pol wrote: >> > TL;DR: rebuild your Qt, Plasma will depend on latest end of this week. >> >> Should we add the dependency then? The kscreen patch should be in, 5.7 >> official testing phases will start soon and it

[Differential] [Accepted] D1666: [libinput] Add the Device to Event

2016-05-30 Thread Sebastian Kügler
sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH libinput-device-in-event REVISION DETAIL https://phabricator.kde.org/D1666 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

Minutes Monday Plasma Meeting

2016-05-30 Thread Sebastian Kügler
Minutes Plasma 'hangout', 30-5-2016, 12:00 CET Present: mgraesslin, bshah, notmart, Sho, kbroulik, sebas mgraesslin: * Text input integrated in KWayland * virtual keyboard in KWin ready to push * cursor image deactivated if no pointer device connected * bunch of KWayland crash fixes * main proble

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Sebastian Kügler
> On May 30, 2016, 9:38 a.m., Andreas Kainz wrote: > > Is It possible too sync the colors between agenda and calender view. > > > > II I I lkelike the I think that would look very cool, but there may be more than one item with different colors for a given day, so it's more complicated than jus

[Differential] [Request, 16 lines] D1713: [server] Properly handle destructor in SlideInterface

2016-05-30 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The destructor was not properly implement. Let's use the generic one from Resource. Test case is a

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96022 --- Iam Not sure if you get aa better overview what's the agenda

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96020 --- Is It possible too sync the colors between agenda and calende

[Differential] [Request, 55 lines] D1711: [server] Don't destroy ShadowInterface when SurfaceInterface gets destroyed

2016-05-30 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Unlike the other cases this one is not as dangerous as the shadow protocol doesn't have a destructor re

[Differential] [Request, 42 lines] D1710: [server] Don't destroy ServerSideDecorationInterface when parent SurfaceInterface is destroyed

2016-05-30 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Destroying the ServerSideDecorationInterface on the server side before the client has a chance to clean

Re: Review Request 128052: Improve agenda view in digital-clock applet

2016-05-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128052/#review96018 --- +1 - Marco Martin On May 29, 2016, 11:11 p.m., Daniel Vrát

[Differential] [Updated] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop

2016-05-30 Thread Martin Gräßlin
graesslin added a comment. In NETWM -1 represents on all desktops REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1706 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, hein, graesslin Cc: plas

Re: Plasma depending on Qt 5.6.1 shortly

2016-05-30 Thread Marco Martin
On Monday 30 May 2016, Aleix Pol wrote: > > TL;DR: rebuild your Qt, Plasma will depend on latest end of this week. > > Should we add the dependency then? The kscreen patch should be in, 5.7 > official testing phases will start soon and it's absurd not to jump > in. "today is a good day to bump"

[Differential] [Request, 42 lines] D1708: [server] Don't destroy BlurInterface when parent SurfaceInterface is destroyed

2016-05-30 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Destroying the BlurInterface on the server side before the client has a chance to cleanup results in a