Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 195 - Still Unstable!

2016-06-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/195/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 21:34:49 + Build duration: 1 hr 15 min CHANGE SET Revision 7ba54681138072264ccd4d70421ce

[Differential] [Commented On] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-17 Thread broulik (Kai Uwe Broulik)
broulik added a comment. F152689: Screenshot_20160618_003202.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1940 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 51 lines] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-17 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds

[Differential] [Commented On] D1939: [Calculator Runner] Add "Copy to clipboard" action

2016-06-17 Thread broulik (Kai Uwe Broulik)
broulik added a comment. F152685: Screenshot_20160618_002329.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 24 lines] D1939: [Calculator Runner] Add "Copy to clipboard" action

2016-06-17 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allow

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

2016-06-17 Thread dhaumann (Dominik Haumann)
dhaumann added a comment. It's important to chime in here. There is a huge issue with fonts in general, that do not provide all font faces. What we need is: regular (sometimes called roman?), bold, italic (sometimes called oblique), and bold italic (4 flavours in total). As backgrou

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 194 - Still Unstable!

2016-06-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/194/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 20:09:29 + Build duration: 41 min CHANGE SET Revision 83e2b92752bd4dd4b560c64fd969dff4d4

Re: Review Request 128221: windowlist resizing

2016-06-17 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128221/ --- (Updated June 17, 2016, 8:48 p.m.) Status -- This change has been ma

Re: Review Request 128136: alignement for systemmonitoring applets

2016-06-17 Thread Andreas Kainz
> On Juni 17, 2016, 5:32 nachm., Thomas Pfeiffer wrote: > > I still think that the applets need a completely different layout in order > > to really be useful in panels (who would really want to use a whole panel > > just to show CPU load?), but that's probably for another patch. > > The change

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 193 - Still Unstable!

2016-06-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/193/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 19:26:12 + Build duration: 40 min CHANGE SET Revision e1692f1a21458986fac18daf6eb1d1037c

Re: porting the QtCurve kwin theme

2016-06-17 Thread Christoph Feck
On Thursday 16 June 2016 23:15:22 René J.V. Bertin wrote: > [...] > How complicated is it to port a KDE4 kwin style/decoration to KF5, I > presume that means using KDecoration2? Last year I created the "Skeleton" KWin 5 decoration to test KWin 5 decorations: http://developer.kde.org/~cfeck/skele

[Differential] [Closed] D1922: Use iconName in all runners

2016-06-17 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe1692f1a2145: Use iconName instead of icon in all runners (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1922?vs=4562&id=4594#toc REPOSITORY rPLASMAWORKSPAC

[Differential] [Closed] D1923: [Kicker RunnerMatchesModel] Use iconName() if possible

2016-06-17 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP6fd35500d5cc: [Kicker RunnerMatchesModel] Use iconName() if possible (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1923?vs=4563&id=4593#toc REPOSITORY rPLASM

Re: Review Request 128136: alignement for systemmonitoring applets

2016-06-17 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128136/#review96640 --- I still think that the applets need a completely different la

Re: Fonts rendering in titlebars with KDecoration2

2016-06-17 Thread René J . V . Bertin
On Friday June 17 2016 18:01:42 Christoph Feck wrote: > Is your decoration Qt Quick/QML based? If yes, see > http://blog.qt.io/blog/2012/08/08/native-looking-text-in-qml-2/ Not mine: Breeze and Oxygen. The Aurorae/Plastik decoration appears to be less affected. R. _

Re: Fonts rendering in titlebars with KDecoration2

2016-06-17 Thread Christoph Feck
On Friday 17 June 2016 11:28:32 René J.V. Bertin wrote: > Hi, > > Trying out kdecoration-viewer confirmed something I already noticed > when I ran KWin5 from a parallel prefix, replacing my usual KWin4. > The font in the window titlebars is the same, but looks different. Is your decoration Qt Qui

[Differential] [Request, 10 lines] D1938: [server] Ensure that Resource::Private::get returns nullptr if passed a nullptr

2016-06-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY A Resource might be unbound, but not yet destroyed. In that case this return a Re

[Differential] [Accepted] D1937: [server] Unset SurfaceInterface pointer in referenced objects when being destroyed

2016-06-17 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH unset-surface REVISION DETAIL https://phabricator.kde.org/D1937 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Request, 54 lines] D1937: [server] Unset SurfaceInterface pointer in referenced objects when being destroyed

2016-06-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This is a gotcha moment: 1. Create Surface with id 1 2. destroy that Surface

Re: Review Request 128221: windowlist resizing

2016-06-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128221/#review96627 --- Ship it! Ship It! - Sebastian Kügler On June 17, 2016,

[Differential] [Accepted] D1923: [Kicker RunnerMatchesModel] Use iconName() if possible

2016-06-17 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1923 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Closed] D1935: Speed and memory optimizations.

2016-06-17 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb8503ee2b1f3: Speed and memory optimizations. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1935?vs=4584&id=4588#toc REPOSITORY rPLASMADESKTOP Plasma Desktop C

[Differential] [Closed] D1934: Cleanup use of TasksModel data roles.

2016-06-17 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP94d0a17a3c3b: Cleanup use of TasksModel data roles. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1934?vs=4586&id=4587#toc REPOSITORY rPLASMADESKTOP Plasma Desk

[Differential] [Commented On] D1934: Cleanup use of TasksModel data roles.

2016-06-17 Thread hein (Eike Hein)
hein added a comment. [19:30] Sho_: sorry it's impossible ot review with that internet connection :/ [19:30] Sho_: https://phabricator.kde.org/D1934 ← make it readonly property var m and then ship it REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.or

[Differential] [Accepted] D1935: Speed and memory optimizations.

2016-06-17 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1935 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, dfaure,

[Differential] [Updated, 156 lines] D1934: Cleanup use of TasksModel data roles.

2016-06-17 Thread hein (Eike Hein)
hein updated this revision to Diff 4586. hein added a comment. Fix ReferenceErrors from dumb mistake. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1934?vs=4583&id=4586 BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1

[Differential] [Request, 34 lines] D1935: Speed and memory optimizations.

2016-06-17 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: broulik, dfaure. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY TasksModel will never change IsWindow|IsStartup|IsLauncher on a row after insertion, so we can avoid some object instanciat

[Differential] [Request, 156 lines] D1934: Cleanup use of TasksModel data roles.

2016-06-17 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: broulik, dfaure. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Avoid a wall of prop rebindings to access roles outside the delegates causing unnecessary calls to data(). Be 'typesaf

Re: Review Request 128216: [QueryMatch] Add iconName

2016-06-17 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128216/ --- (Updated June 17, 2016, 12:38 p.m.) Status -- This change has been m

[Differential] [Request, 5 lines] D1933: Avoid appending superfluous \n

2016-06-17 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We want a \n between lines, but by always ending with \n we end up with the tooltip subtext b

Fonts rendering in titlebars with KDecoration2

2016-06-17 Thread René J . V . Bertin
Hi, Trying out kdecoration-viewer confirmed something I already noticed when I ran KWin5 from a parallel prefix, replacing my usual KWin4. The font in the window titlebars is the same, but looks different. I have the Infinality Freetype and FontConfig patches installed, so any form or font rend

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 192 - Still Unstable!

2016-06-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 08:41:23 + Build duration: 46 min CHANGE SET Revision 7eff45a98f4e58276eb2cd3cc91ce43feb

[Differential] [Closed] D1931: Avoid asking model to create string-serialized icon data where possible.

2016-06-17 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP197eb36e06f8: Avoid asking model to create string-serialized icon data where possible. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabr

[Differential] [Updated] D1932: [tests] Add a test application for PlasmaShellSurface

2016-06-17 Thread Martin Gräßlin
graesslin added a dependency: D1928: Add a notification role to PlasmaShellSurface. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc: plasma-

[Differential] [Updated] D1928: Add a notification role to PlasmaShellSurface

2016-06-17 Thread Martin Gräßlin
graesslin added a dependent revision: D1932: [tests] Add a test application for PlasmaShellSurface. REPOSITORY rKWAYLAND KWayland BRANCH plasma-shell-notification REVISION DETAIL https://phabricator.kde.org/D1928 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Request, 201 lines] D1932: [tests] Add a test application for PlasmaShellSurface

2016-06-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY Creates a PlasmaShellSurface and allows to set the different roles through comman

[Differential] [Accepted] D1931: Avoid asking model to create string-serialized icon data where possible.

2016-06-17 Thread dfaure (David Faure)
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, dfaure Cc: p

[Differential] [Updated] D1931: Avoid asking model to create string-serialized icon data where possible.

2016-06-17 Thread hein (Eike Hein)
hein marked an inline comment as done. hein added a comment. I didn't like "WithIcon" because it sounds like it guarantees handing over an icon, but it's really a fallback - so would have to be LauncherUrlWithFallbackIcon, which is quite a mouthful. I think it's prettier to have LauncherUrl

[Differential] [Updated] D1931: Avoid asking model to create string-serialized icon data where possible.

2016-06-17 Thread hein (Eike Hein)
hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > dfaure wrote in ContextMenu.qml:225 > Is it expected that requestRemoveLauncher is "without icon" and > requestAddLauncher is "with icon"? Seems asymmetric but I don't know enough > about this to know if it's o

Re: porting the QtCurve kwin theme

2016-06-17 Thread René J . V . Bertin
On Friday June 17 2016 07:54:48 Martin Graesslin wrote: >Yes, a port to KDecoration2 is required. No, there is no guidebook for that. >The required effort is difficult to estimate as it depends on the actual >implementation. Whether it uses KCommonDecoration or KDecoration. I see that both clas

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 191 - Still Unstable!

2016-06-17 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/191/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Jun 2016 07:59:15 + Build duration: 41 min CHANGE SET Revision d0f4c452ff3c65077b27ab9c040c20c313

[Differential] [Updated] D1931: Avoid asking model to create string-serialized icon data where possible.

2016-06-17 Thread dfaure (David Faure)
dfaure added a comment. Maybe it should have been the other way around, LauncherUrlWithIcon where needed ;-) (it seems the icon is only rarely needed) INLINE COMMENTS > ContextMenu.qml:225 > } else { > -tasksModel.requestAddLauncher(visualParent.launcherUrl);

[Differential] [Commented On] D1479: [Notifications] Limit notification size and add scroll bar if needed

2016-06-17 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Hooray, so we missed 5.7. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, mck182 Cc: mart, colo

[Differential] [Updated] D1916: [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player

2016-06-17 Thread sitter (Harald Sitter)
sitter added a comment. This should fix https://bugs.kde.org/show_bug.cgi?id=361965 if I am not mistaken. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1916 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 30 lines] D1931: Avoid asking model to create string-serialized icon data where possible.

2016-06-17 Thread hein (Eike Hein)
hein created this revision. hein added a reviewer: dfaure. hein added a subscriber: plasma-devel. hein added a project: Plasma. REVISION SUMMARY Use LauncherUrlWithoutIcon data role where the icon is not needed, and get LauncherUrl procedurally where it is. This is a version of https://ph

[Differential] [Abandoned] D1921: Use data role that avoids unnecessary work by the source model.

2016-06-17 Thread hein (Eike Hein)
hein abandoned this revision. hein added a comment. Thanks for the accept, but this patch is actually wrong :) I'll rework the approach. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1921 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

Review Request 128221: windowlist resizing

2016-06-17 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128221/ --- Review request for Plasma. Repository: plasma-desktop Description -

[Differential] [Closed] D1925: Improve window-on-screen intersection test.

2016-06-17 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3b1618c5590b: Improve window-on-screen intersection test. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1925?vs

[Differential] [Closed] D1920: Add a LauncherUrlWithoutIcon data role as a speed optimization.

2016-06-17 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd0f4c452ff3c: Add a LauncherUrlWithoutIcon data role as a speed optimization. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabrica

[Differential] [Accepted] D1920: Add a LauncherUrlWithoutIcon data role as a speed optimization.

2016-06-17 Thread dfaure (David Faure)
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH blblblbl (branched from master) REVISION DETAIL https://phabricator.kde.org/D1920 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Updated, 105 lines] D1920: Add a LauncherUrlWithoutIcon data role as a speed optimization.

2016-06-17 Thread hein (Eike Hein)
hein updated this revision to Diff 4576. hein marked 2 inline comments as done. hein added a comment. Assume iconData is the only query item and, since the WithoutIcon data role won't add it, avoid unnecessary calls to launcherUrlsMatch and thus QUrl::adjusted. REPOSITORY rPLASMAWORKSPAC

[Differential] [Updated] D1930: Add support for new Notification role on PlasmaSurface

2016-06-17 Thread Martin Gräßlin
graesslin added a dependency: D1928: Add a notification role to PlasmaShellSurface. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1930 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-d

[Differential] [Updated] D1928: Add a notification role to PlasmaShellSurface

2016-06-17 Thread Martin Gräßlin
graesslin added a dependent revision: D1930: Add support for new Notification role on PlasmaSurface. REPOSITORY rKWAYLAND KWayland BRANCH plasma-shell-notification REVISION DETAIL https://phabricator.kde.org/D1928 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Request, 13 lines] D1930: Add support for new Notification role on PlasmaSurface

2016-06-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Sets notifications on all desktop and doesn't activate them. Un

[Differential] [Closed] D1927: Do not activate on-screen-display windows

2016-06-17 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8a85cc5f9c60: Do not activate on-screen-display windows (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1927?vs=4569&id=4574 REVISION DETAIL

[Differential] [Updated] D1928: Add a notification role to PlasmaShellSurface

2016-06-17 Thread Martin Gräßlin
graesslin added a dependent revision: D1929: [kwindowsystem] Wrap the notification type. REPOSITORY rKWAYLAND KWayland BRANCH plasma-shell-notification REVISION DETAIL https://phabricator.kde.org/D1928 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D1929: [kwindowsystem] Wrap the notification type

2016-06-17 Thread Martin Gräßlin
graesslin added a dependency: D1928: Add a notification role to PlasmaShellSurface. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D1929 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 4 lines] D1929: [kwindowsystem] Wrap the notification type

2016-06-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a project: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland BRANCH notification

[Differential] [Accepted] D1921: Use data role that avoids unnecessary work by the source model.

2016-06-17 Thread dfaure (David Faure)
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1921 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmunds

[Differential] [Accepted] D1925: Improve window-on-screen intersection test.

2016-06-17 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH blblblbl (branched from master) REVISION DETAIL https://phabricator.kde.org/D1925 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Commented On] D1920: Add a LauncherUrlWithoutIcon data role as a speed optimization.

2016-06-17 Thread dfaure (David Faure)
dfaure added inline comments. INLINE COMMENTS > tasksmodel.cpp:357 > || (launcherUrl.isValid() && > launcherUrlsMatch(launcherUrl, > - > launcherIndex.data(AbstractTasksModel::LauncherUrl).toUrl(), > IgnoreQueryItems))) { > +

[Differential] [Accepted] D1927: Do not activate on-screen-display windows

2016-06-17 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH osd-no-focus-5.7 REVISION DETAIL https://phabricator.kde.org/D1927 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ T

[Differential] [Accepted] D1928: Add a notification role to PlasmaShellSurface

2016-06-17 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH plasma-shell-notification REVISION DETAIL https://phabricator.kde.org/D1928 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Request, 23 lines] D1928: Add a notification role to PlasmaShellSurface

2016-06-17 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY Plasma needs to be able to mark windows as Notifications, so that KWin can put th

[Differential] [Updated, 21 lines] D1925: Improve window-on-screen intersection test.

2016-06-17 Thread hein (Eike Hein)
hein updated this revision to Diff 4571. hein marked an inline comment as done. hein added a comment. Make it not uncompilable nonsense. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1925?vs=4570&id=4571 BRANCH blblblbl (branched fr

[Differential] [Updated] D1925: Improve window-on-screen intersection test.

2016-06-17 Thread hein (Eike Hein)
hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > graesslin wrote in xwindowtasksmodel.cpp:785 > What if the center of the window is not on any screen? Yes that's possible. > > KWin's implementation calculates the distance to every screen and uses the > minima

[Differential] [Updated, 19 lines] D1925: Improve window-on-screen intersection test.

2016-06-17 Thread hein (Eike Hein)
hein updated this revision to Diff 4570. hein added a comment. Fall back to the screen frameGeometry().center() is closest to. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1925?vs=4565&id=4570 BRANCH blblblbl (branched from master)