Re: Review Request 128454: Kickoff query for CJK support

2016-07-16 Thread Leslie Zhai
> On 七月 15, 2016, 7:23 a.m., Eike Hein wrote: > > Being able to find ??/?? with just wy is cool, but I'm concerned about this > > being a sort of very narrow hack. It's only in a specific KRunner plugin, > > so it won't work in any other thing finding apps by name using lower-level > > APIs. A

Re: Review Request 128454: Kickoff query for CJK support

2016-07-16 Thread Leslie Zhai
> On 七月 15, 2016, 9:19 a.m., Kai Uwe Broulik wrote: > > Thanks. I can't really comment on this. Hi Kai, Thanks for your careful review ;-) I will fix the issues when I develop the same function KRunner plugin for KJieba. Regards, Leslie Zhai - Leslie -

Re: Review Request 128454: Kickoff query for CJK support

2016-07-16 Thread Leslie Zhai
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128454/ --- (Updated 七月 16, 2016, 7:19 a.m.) Status -- This change has been disc

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

2016-07-16 Thread Ivan Čukić
ivan added a comment. There is a problem with the dark colour scheme - the view now has white borders on the sides: F182088: systemsettings.png The second thing, I think that the items would benefit from more padding. The third is that the i

[Differential] [Changed Subscribers] D2173: WIP: New System Settings delegate design

2016-07-16 Thread Ivan Čukić
ivan added subscribers: jensreuterberg, colomar. ivan added a comment. @colomar @jensreuterberg There is one strange thing regarding the behaviour - the sub-item links. The first problem is that it is not obvious what is clickable and what is not - the only hint is a slight change in

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

2016-07-16 Thread Ivan Čukić
ivan added a comment. The last one - when closing the SySett, this is written a few dozen times: User of KWidgetItemDelegate should not delete widgets created by createItemWidgets! REPOSITORY rSYSTEMSETTINGS System Settings REVISION DETAIL https://phabricator.kde.org/D2173 EMAIL

Re: Review Request 128454: Kickoff query for CJK support

2016-07-16 Thread Eike Hein
> On July 15, 2016, 7:23 a.m., Eike Hein wrote: > > Being able to find ??/?? with just wy is cool, but I'm concerned about this > > being a sort of very narrow hack. It's only in a specific KRunner plugin, > > so it won't work in any other thing finding apps by name using lower-level > > APIs.

[Differential] [Closed] D2186: Enable image rotation from exif data

2016-07-16 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS167922b445a5: Enable image rotation from exif data (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2186?vs=5216&id=5229#toc REPOSITORY rKDEPLASMAADDON

Re: Review Request 128431: Fix race condition when new applications open

2016-07-16 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128431/ --- (Updated July 16, 2016, 3:12 p.m.) Status -- This change has been ma

Re: Review Request 128372: date and time kcm remove current location time zone

2016-07-16 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128372/ --- (Updated Juli 16, 2016, 8 nachm.) Status -- This change has been dis

Re: Review Request 128445: add a subsection for removable devices

2016-07-16 Thread Andreas Kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128445/ --- (Updated July 16, 2016, 10:11 p.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 266 - Still Unstable!

2016-07-16 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/266/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:23 + Build duration: 24 min CHANGE SET Revision e725f2aac8d301e8858cd7373871799f0e

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 197 - Aborted!

2016-07-16 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/197/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 16 Jul 2016 20:53:23 + Build duration: 54 min CHANGE SET No changes ___