Re: Properly fixing the containment scripting issue

2016-07-24 Thread Ivan Čukić
> so it can just change stuff in that one "activity"? (i'm fine with that, just > asking) Exactly. When Plasma starts for the first time, it knows (it is guaranteed) that at least one activity will exist. - Why not allow its containments to be customized. > then, as soon and if kamd comes

Re: Review Request 128429: Fix strings in tooltips

2016-07-24 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128429/#review97805 --- When assembling tooltips with +=, every xi18nc call will

[Differential] [Commented On] D2270: Try to be more clever about what sink to use for volume control

2016-07-24 Thread drosca (David Rosca)
drosca added inline comments. INLINE COMMENTS > davidedmundson wrote in device.cpp:68 > Use the values from pa_sink_state ? libpulse has pa_sink_state and pa_source_state, but here it is in Device - so for both sink and source. I can change it to use either PA_SOURCE_* or PA_SINK_* values

[Differential] [Accepted] D2270: Try to be more clever about what sink to use for volume control

2016-07-24 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > device.cpp:68 > +return IdleState; > +case 2: // PA_X_SUSPENDED > +return

Re: Properly fixing the containment scripting issue

2016-07-24 Thread Marco Martin
On Sunday 24 July 2016, Ivan Čukić wrote: > Plasma starts, if kamd is running, it has a normal current activity, > if not, it thinks there is an activity with a null UUID > (----). > > If plasma gets the null activity, and it has already been started > before, it

[Differential] [Closed] D2275: loop trough screens only once

2016-07-24 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP25863bd154a7: loop trough screens only once (authored by mart). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2275?vs=5467=5479

kirigami moved in kdereview

2016-07-24 Thread Marco Martin
Hi all, the kirigami project has been moved to kdereview. kirigami is a QtQuick module aimed in the future to become a framework (it has no dependencies by default besides Qt, optional to kdeclarative and plasma) It can be used to build mobile applications with QtQuick (as well as very simple

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-07-24 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358957 --- Comment #13 from Kai Uwe Broulik --- If the average user configures it for "no action" this means no action whatsoever. A user should not need to know there's a ton of different services who all mess with his or her session

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2016-07-24 Thread Thomas Fruehbeck via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358957 --- Comment #12 from Thomas Fruehbeck --- (In reply to Kai Uwe Broulik from comment #11) > If you set button handling to *no action* this doesn't mean some other > service should randomly do stuff instead... After having thought

[Differential] [Accepted] D2258: Do not detect kde4 directory but assume it is the same location, this means people who install as non-root with kde-srcbuild can install it

2016-07-24 Thread dfaure (David Faure)
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks. Installing outside the install prefix is against the law. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH master REVISION DETAIL

Properly fixing the containment scripting issue

2016-07-24 Thread Ivan Čukić
Hi all, As we have seen in this past period, there are quite a few issues with the layout.js plasma script and its execution. Most the issues stem from the fact that the scripting code was created in the era where each screen, each virtual desktop was able to have a different containment in it