Re: Review Request 128997: Fix most obvious clazy and clang warnings

> On Септ. 22, 2016, 2:42 преди обяд, David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

[Powerdevil] [Bug 369181] User session security vulnerability from screen lock being suppressed with power management

https://bugs.kde.org/show_bug.cgi?id=369181 Kai Uwe Broulik changed: What|Removed |Added Flags||Usability? CC|

[Powerdevil] [Bug 369181] New: User session security vulnerability from screen lock being suppressed with power management

https://bugs.kde.org/show_bug.cgi?id=369181 Bug ID: 369181 Summary: User session security vulnerability from screen lock being suppressed with power management Product: Powerdevil Version: 5.6.4 Platform: Debian testing

[Differential] [Request, 12 lines] D2831: Introduce an action to display what we're showing in the menu

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We let the developer introduce a tree of actions as a menu. This patch makes it possible for the applica

[Differential] [Request, 10 lines] D2830: ApplicationWindow.bannerPressed signal

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2830 AFFECTED FILES src/c

[Differential] [Request, 2 lines] D2829: Add description for volume applet

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes appstream test failure on CI. Also it's a useful thing to have anyway as the comment is

Re: Review Request 128997: Fix most obvious clazy and clang warnings

> On Sept. 22, 2016, 1:42 a.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? The warning was saying that it's a delete of something fwd-declared. A bit more resear

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 12 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 23:40:50 + Build duration: 8 min 2 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 12 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 23:40:50 + Build duration: 8 min 2 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 128997: Fix most obvious clazy and clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/#review99402 --- appmenu/appmenu.cpp (line 90)

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128996/ --- (Updated Sept. 21, 2016, 11:38 p.m.) Status -- This change has been

Review Request 128997: Fix most obvious clazy and clang warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128996/#review99401 --- Ship it! Ship It! - Matthias Klumpp On Sept. 21, 2016,

Jenkins-kde-ci: khotkeys Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 23:01:45 + Build duration: 2 min 12 sec CHANGE SET No changes JUNIT RESULTS N

Jenkins-kde-ci: khotkeys Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 23:01:45 + Build duration: 2 min 12 sec CHANGE SET No changes JUNIT RESULTS N

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 22:42:24 + Build duration: 9 min 27 sec CHANGE SET Revision 5d3f0d2a15598c8d4706

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128996/#review99399 --- +1 - David Edmundson On Sept. 21, 2016, 10:41 p.m., Aleix

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

> On Sept. 21, 2016, 10:35 p.m., John Salatas wrote: > > Reopened due to > > https://bugs.kde.org/show_bug.cgi?id=369160 No need to reopen it, just create a new review with any new changes in it. Hopefully we'll be a bit quicker at responding. Note that reviews have now moved onto phabricato

Review Request 128996: Don't generate appstream files for components that are not in rdn

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128996/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage Desc

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128402/#review99397 --- Reopened due to https://bugs.kde.org/show_bug.cgi?id=369160

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 358 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/358/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 19:04:06 + Build duration: 7 min 33 sec CHANGE SET Revision 40a1af32e109902a7fe07fdbd59b38

[Breeze] [Bug 363602] Symlinked SVG files fails to load under Windows

https://bugs.kde.org/show_bug.cgi?id=363602 Jasem Mutlaq changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

Re: Review Request 128977: Proofread/update emoticons kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128977/ --- (Updated Sept. 21, 2016, 7:03 p.m.) Status -- This change has been m

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 357 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/357/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 18:49:05 + Build duration: 7 min 31 sec CHANGE SET Revision c94a2cb6b0dedb9a67a66b15e7c02b

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 356 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/356/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 18:40:50 + Build duration: 7 min 41 sec CHANGE SET Revision 450724b0b50d396dcc5ebd08d6e918

Re: Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128978/ --- (Updated Sept. 21, 2016, 6:45 p.m.) Status -- This change has been m

Re: Review Request 128965: Update color kcm docbook to 5.8

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128965/ --- (Updated Sept. 21, 2016, 6:40 p.m.) Status -- This change has been m

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99390 --- for reference, look at what the recent commit b2d91a39740b00

[Differential] [Closed] D2827: Polish SwipeListItem

This revision was automatically updated to reflect the committed changes. apol marked an inline comment as done. Closed by commit rKIRIGAMIf90a5ca65f04: Polish SwipeListItem (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2827?vs=6856&i

[Differential] [Accepted] D2827: Polish SwipeListItem

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasm

[Differential] [Updated] D2827: Polish SwipeListItem

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > mart wrote in SwipeListItem.qml:362 > what's the rationale for this? Good point, fixed. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2827 EMAIL PREFERENCES https://phabrica

[Differential] [Updated, 28 lines] D2827: Polish SwipeListItem

apol updated this revision to Diff 6856. apol added a comment. Reduce magic numbers REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2827?vs=6855&id=6856 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2827 AFFECTED FILES src/control

[Differential] [Commented On] D2827: Polish SwipeListItem

mart added inline comments. INLINE COMMENTS > SwipeListItem.qml:362 > margins: Units.smallSpacing > +rightMargin: handleIcon.width * 2 > } what's the rationale for this? REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL http

[Differential] [Request, 21 lines] D2827: Polish SwipeListItem

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make sure we don't have 2 different code paths for contentItem initialization as one of them had a diffe

Re: Review Request 128973: Update icon lcm docbook

> On Sept. 21, 2016, 2:58 p.m., Marco Martin wrote: > > doc/kcontrol/icons/index.docbook, line 33 > > > > > > uppercase Plasma, Dolphin etc? > > Burkhard Lück wrote: > frameworks/kdoctools > > genera

Re: Review Request 128973: Update icon lcm docbook

> On Sept. 21, 2016, 2:58 nachm., Marco Martin wrote: > > doc/kcontrol/icons/index.docbook, line 33 > > > > > > uppercase Plasma, Dolphin etc? frameworks/kdoctools general.entities:400:Plasma"> general.entities

Re: Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128978/#review99365 --- Ship it! Ship It! - Marco Martin On Sept. 21, 2016, 1:3

Re: Review Request 128977: Proofread/update emoticons kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128977/#review99366 --- Ship it! Ship It! - Marco Martin On Sept. 21, 2016, 1:1

Re: Review Request 128973: Update icon lcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128973/#review99368 --- Fix it, then Ship it! doc/kcontrol/icons/index.docbook (l

Re: Review Request 128974: Proofread/update cursortheme kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128974/#review99367 --- Ship it! Ship It! - Marco Martin On Sept. 21, 2016, 12:

[Differential] [Changed Subscribers] D2826: Fix shortcuts editor with double click to activate enabled

mart added inline comments. INLINE COMMENTS > kglobalshortcutseditor.cpp:239 > }); > +connect(ui.components, &QListView::clicked, > +q, [this](const QModelIndex &index) { couldn't risk to call activateCompoent(9 two times in a row now? REPOSITORY rPLASMADESKTOP P

[Differential] [Request, 9 lines] D2826: Fix shortcuts editor with double click to activate enabled

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Semantically we want to show the suboptions on selection not activation. Also it fixes an iss

[Differential] [Updated] D2796: Fix valgrind warning in volume and channelMap memcmp

davidedmundson updated the summary for this revision. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2796 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 355 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/355/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 13:29:44 + Build duration: 24 min CHANGE SET Revision 14972276d9fb9eb34098a29cf6b47f461e2d

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 13:29:09 + Build duration: 19 min CHANGE SET Revision 14972276d9fb9eb34098a29cf6

Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128978/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

[Breeze] [Bug 369158] New: Breeze sddm theme broken on dual monitor setup (no cursor)

https://bugs.kde.org/show_bug.cgi?id=369158 Bug ID: 369158 Summary: Breeze sddm theme broken on dual monitor setup (no cursor) Product: Breeze Version: 5.7.95 Platform: Other OS: Linux Status: UN

Review Request 128977: Proofread/update emoticons kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128977/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

[Differential] [Closed] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEdacb6b27dcd0: [Panel Config View] Set Qt::WindowStaysOnTopHint (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

Review Request 128974: Proofread/update cursortheme kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128974/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

[Differential] [Accepted] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2825 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Request, 4 lines] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We set KeepAbove using KW

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 354 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/354/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 12:14:17 + Build duration: 17 min CHANGE SET Revision ea8374a149e592798e1f0cbdd667386c8d87

Review Request 128973: Update icon lcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128973/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

Re: Review Request 128760: Fix crash on exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/ --- (Updated Sept. 21, 2016, 12:19 p.m.) Status -- This change has been

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

https://bugs.kde.org/show_bug.cgi?id=369129 --- Comment #5 from Manuel Amador (Rudd-O) --- We should tackle the problem with KDE first, as KDE moves faster than GNOME and has a long history of innovating in this space (Solid). A KDE-only / Powerdevil-only solution is adequate for the first itera

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

https://bugs.kde.org/show_bug.cgi?id=369129 --- Comment #4 from Manuel Amador (Rudd-O) --- I don't think things further up the stack have the necessary information to make an informed decision. The "sound card" of HDMI outs and the video cards powering them appear as different PCI devices in man

Re: Review Request 128760: Fix crash on exit

> On Sept. 17, 2016, 11:39 p.m., Hugo Pereira Da Costa wrote: > > Sorry for the delay > > ... for some reason I don't always recieve notifications from reviewboard > > Hugo Pereira Da Costa wrote: > Ping ? > Do people have commit rights ? Should I commit it myself ? I think you should

[Differential] [Commented On] D2820: Updating the wallpaper cache only when the configuration file settles

davidedmundson added inline comments. INLINE COMMENTS > sortedactivitiesmodel.cpp:197 > bool initialized; > -KConfig plasmaConfig; > +KSharedConfig::Ptr plasmaConfig; > +QTimer updateTimer; Now it's a sharedconfig (a *very* sensible change) - you don't even need

Is it possible to include in the plasmoid file the translations?

Hello everyone, is it possible inside the .plasmoid file to include the various translations some how? I am referring to .mo files... regards, michail

[Differential] [Closed] D2824: Make sure that default devices are not null

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA270110e5520f: Make sure that default devices are not null (authored by drosca). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2824?vs=6

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

https://bugs.kde.org/show_bug.cgi?id=369129 Oliver Henshaw changed: What|Removed |Added CC||oliver.hens...@gmail.com --- Comment #3 from O

Re: Review Request 128966: Don't include kdeglobals when dealing with a cache config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128966/ --- (Updated Sept. 21, 2016, 12:44 p.m.) Status -- This change has been

Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128392/#review99349 --- Any news on that? - Marco Martin On July 11, 2016, 10:51 a

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 353 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/353/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 10:17:24 + Build duration: 12 min CHANGE SET Revision 6c3de2f1ffaf681533e4c624c11581702ce6

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

https://bugs.kde.org/show_bug.cgi?id=341762 bl...@vivaldi.net changed: What|Removed |Added CC||bl...@vivaldi.net --- Comment #8 from bl...@

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 352 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/352/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 09:54:08 + Build duration: 21 min CHANGE SET Revision 9d55c52f76cf831584d71d60a8806688f37e

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 09:53:44 + Build duration: 22 min CHANGE SET Revision 9d55c52f76cf831584d71d60a88

Re: Review Request 128948: Update shortcuts kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128948/ --- (Updated Sept. 21, 2016, 10:11 a.m.) Status -- This change has been

[Differential] [Closed] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP9d55c52f76cf: [KeyboardDaemon] Don't call getCurrentLayout() in destructor (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kd

[Differential] [Accepted] D2824: Make sure that default devices are not null

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2824 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is broken

https://bugs.kde.org/show_bug.cgi?id=364642 Elvis Angelaccio changed: What|Removed |Added Component|general |default Assignee|dolphin-bugs-n...

[Breeze] [Bug 365025] Breeze Dark Theme made Dolphin main view hard to read

https://bugs.kde.org/show_bug.cgi?id=365025 Elvis Angelaccio changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |plasma-devel@kde.org Product|dolp

Re: Review Request 128966: Don't include kdeglobals when dealing with a cache config

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128966/#review99348 --- Ship it! good catch - Marco Martin On Sept. 21, 2016, 6

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 351 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/351/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 09:26:17 + Build duration: 3 min 38 sec CHANGE SET Revision fb66f14b0410b0cc8a758165a58e734

[Differential] [Commented On] D2820: Updating the wallpaper cache only when the configuration file settles

mart added inline comments. INLINE COMMENTS > sortedactivitiesmodel.cpp:65 > +updateTimer.setSingleShot(true); > +updateTimer.setInterval(500); > + is a blind timer the only way to wait enough? :/ REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phab

[Differential] [Accepted] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2818 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

> On Sept. 19, 2016, 9:52 p.m., Marco Martin wrote: > > shell/scripting/panel.cpp, line 189 > > > > > > this can't rely on the order of qGuiApp->screens, but should use > > screenpool in shellcorona, it's the on

Re: Review Request 128948: Update shortcuts kcm docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128948/#review99346 --- Ship it! Ship It! - Marco Martin On Sept. 20, 2016, 5:2

[Differential] [Closed] D2823: [Device Notifier] Only ever pop up if device is visible in the list

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb28ea53b351c: [Device Notifier] Only ever pop up if device is visible in the list (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://p

[Differential] [Changed Subscribers] D2820: Updating the wallpaper cache only when the configuration file settles

broulik added inline comments. INLINE COMMENTS > sortedactivitiesmodel.cpp:49 > +, plasmaConfig(KSharedConfig::openConfig(PLASMACONFIG)) > +, updateTimer() > { Not needed? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/

[Differential] [Updated] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

sitter added a comment. seems to not be crashing anymore. unfortunately I can't comment on the correctness of the change REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2818 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefere

[Differential] [Accepted] D2823: [Device Notifier] Only ever pop up if device is visible in the list

sitter accepted this revision. sitter added a comment. lgtm. and it works \o/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2823 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmund

[Differential] [Request, 43 lines] D2824: Make sure that default devices are not null

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sometimes at the time when default sink/source change is signalled by pa, we don't have that device in sinks/

Re: Review Request 128965: Update color kcm docbook to 5.8

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128965/#review99344 --- Ship it! Ship It! - Olivier Churlaud On Sept. 21, 2016,

Re: Review Request 128760: Fix crash on exit

> On Sept. 17, 2016, 9:39 p.m., Hugo Pereira Da Costa wrote: > > Sorry for the delay > > ... for some reason I don't always recieve notifications from reviewboard Ping ? Do people have commit rights ? Should I commit it myself ? - Hugo ---

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99342 --- shell/scripting/panel.cpp (line 182)