[Differential] [Updated, 8 lines] D2843: Fix method that calls itself recursively

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson updated this revision to Diff 6889. davidedmundson added a comment. fix phab getting excited REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2843?vs=6888=6889 BRANCH master REVISION DETAIL

[Differential] [Request, 17 lines] D2843: Fix method that calls itself recursively

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Read the code. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 364 - Fixed!

2016-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/364/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:24:24 + Build duration: 8 min 46 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 364 - Fixed!

2016-09-22 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/364/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:24:24 + Build duration: 8 min 46 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 363 - Still Failing!

2016-09-22 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/363/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:17:55 + Build duration: 3 min 34 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 362 - Failure!

2016-09-22 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/362/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 01:08:32 + Build duration: 2 min 36 sec CHANGE SET Revision

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/ --- (Updated Sept. 23, 2016, 1:05 a.m.) Status -- This change has been

[Differential] [Request, 2 lines] D2842: Add kinfocenter to the computer tab of Kickoff

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 368080 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL

[Differential] [Request, 1 line] D2841: Don't load system apps model twice

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The system apps model is set from QML via ComputerModel::setSystemApplications This is

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 361 - Still Unstable!

2016-09-22 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/361/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 23 Sep 2016 00:44:42 + Build duration: 9 min 34 sec CHANGE SET Revision

[Differential] [Closed] D2836: Enable high DPI support in KCMShell

2016-09-22 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rKDECLITOOLS91dd63abce3e: Enable high DPI support in KCMShell (authored by davidedmundson). REPOSITORY rKDECLITOOLS KDE CLI Utilities CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2838: Fix memory leak + cleanup in projecthandlertest

2016-09-22 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKb78aceee04f4: Fix memory leak + cleanup in projecthandlertest (authored by davidedmundson). REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2838: Fix memory leak + cleanup in projecthandlertest

2016-09-22 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D2838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D2836: Enable high DPI support in KCMShell

2016-09-22 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDECLITOOLS KDE CLI Utilities BRANCH master REVISION DETAIL https://phabricator.kde.org/D2836 EMAIL PREFERENCES

Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist

2016-09-22 Thread José Manuel Santamaría Lema
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118865/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 117750: populate the konsole and enable it by default in plasmoidviewer

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117750/#review99467 --- Closing as this review request is more than 2 years old. If

Re: Review Request 126640: [WindowThumbnail] Discard pixmap on map events.

2016-09-22 Thread Mihail Ivchenko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126640/ --- (Updated Sept. 22, 2016, 8:44 p.m.) Status -- This change has been

Re: Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center

2016-09-22 Thread Harshit Agarwal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2016-09-22 Thread Nikolaos Chatzidakis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/ --- (Updated Sept. 22, 2016, 8:43 p.m.) Status -- This change has been

Re: Review Request 120306: Exclude X11 when building for Wayland

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/#review99474 --- Closing as this review request is more than 2 years old. If

Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devices are displayed

2016-09-22 Thread Benedikt Gollatz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112812/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 120306: Exclude X11 when building for Wayland

2016-09-22 Thread Pier Luigi Fiorini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120306/ --- (Updated Sept. 22, 2016, 8:43 p.m.) Status -- This change has been

Re: Review Request 117494: Proposed Patch for Bug 198661 - Add option to disable scroll on taskbar

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117494/#review99473 --- Closing as this review request is more than 2 years old. If

Re: Review Request 112208: KMix qml applet

2016-09-22 Thread Diego Casella
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/ --- (Updated Sept. 22, 2016, 8:41 p.m.) Status -- This change has been

Re: Review Request 120248: Override the implicitSizes in the ruler completley

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120248/ --- (Updated Sept. 22, 2016, 8:36 p.m.) Status -- This change has been

Re: Review Request 112208: KMix qml applet

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review99472 --- Closing as this review request is more than 2 years old. If

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2016-09-22 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/#review99471 --- Closing as this review request is more than 2 years old. If

Re: Review Request 112812: Use type description sort order in devicenotifier when non-removable devices are displayed

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112812/#review99458 --- Closing as this review request is more than 2 years old. If

Re: Review Request 105932: Fix for Bug 165792 - Allow multirow panels

2016-09-22 Thread Tobias Franz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105932/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118865/#review99470 --- Closing as this review request is more than 2 years old. If

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2016-09-22 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

2016-09-22 Thread Yichao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 117750: populate the konsole and enable it by default in plasmoidviewer

2016-09-22 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117750/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 118697: Treat albums with different artists as different albums

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118697/#review99468 --- Closing as this review request is more than 2 years old. If

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review99469 --- Closing as this review request is more than 2 years old. If

Re: Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116800/#review99466 --- Closing as this review request is more than 2 years old. If

Re: Review Request 118697: Treat albums with different artists as different albums

2016-09-22 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118697/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 117736: Plasmaboard: don't use m_keyboardSize for plasmoid size

2016-09-22 Thread Sergei Lopatin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117736/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been

Re: Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer

2016-09-22 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116800/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been

Re: Review Request 117615: Implementation of Search in Local Browsing in Plasma Media Center

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117615/#review99465 --- Closing as this review request is more than 2 years old. If

Re: Review Request 117444: Bug 313734 - konsole profiles widget loses cursor highlight

2016-09-22 Thread Jeffrey Enns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117444/ --- (Updated Sept. 22, 2016, 8:39 p.m.) Status -- This change has been

Re: Review Request 117736: Plasmaboard: don't use m_keyboardSize for plasmoid size

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117736/#review84690 --- Closing as this review request is more than 2 years old. If

Re: Review Request 117444: Bug 313734 - konsole profiles widget loses cursor highlight

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117444/#review99464 --- Closing as this review request is more than 2 years old. If

Re: Review Request 116744: Play All Button in Plasma Media Center

2016-09-22 Thread Atul Dubey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116744/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/#review99460 --- Closing as this review request is more than 2 years old. If

Re: Review Request 117101: This patch fixes font size behaviour when pmc is resized.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117101/#review99463 --- Closing as this review request is more than 2 years old. If

Re: Review Request 116983: Fix the height of the buttonsbar

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116983/#review99462 --- Closing as this review request is more than 2 years old. If

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110122/#review99459 --- Closing as this review request is more than 2 years old. If

Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important notifications.

2016-09-22 Thread James Pike
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110122/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been

Re: Review Request 115162: Launch single instance of plasma-mediacenter

2016-09-22 Thread Sujith Haridasan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been

Re: Review Request 117101: This patch fixes font size behaviour when pmc is resized.

2016-09-22 Thread Nikolaos Chatzidakis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117101/ --- (Updated Sept. 22, 2016, 8:38 p.m.) Status -- This change has been

Re: Review Request 116983: Fix the height of the buttonsbar

2016-09-22 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116983/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been

Re: Review Request 116744: Play All Button in Plasma Media Center

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116744/#review99461 --- Closing as this review request is more than 2 years old. If

Re: Review Request 110504: Group tasks by activity

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110504/#review99457 --- Closing as this review request is more than 2 years old. If

Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2016-09-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105677/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 110504: Group tasks by activity

2016-09-22 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110504/ --- (Updated Sept. 22, 2016, 8:35 p.m.) Status -- This change has been

Re: Review Request 105677: Plasmapkg: Add KWin/Decoration support to Plasmapkg

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105677/#review99456 --- Closing as this review request is more than 2 years old. If

Re: Review Request 108308: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108308/#review99455 --- Closing as this review request is more than 2 years old. If

Re: Review Request 103101: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing

2016-09-22 Thread Anton Kreuzkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/103101/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 105932: Fix for Bug 165792 - Allow multirow panels

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/105932/#review99454 --- Closing as this review request is more than 2 years old. If

Re: Review Request 102727: quicklaunch: Add a confirmation dialog before the delete

2016-09-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102727/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 103101: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/103101/#review99453 --- Closing as this review request is more than 2 years old. If

Re: Review Request 102727: quicklaunch: Add a confirmation dialog before the delete

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102727/#review99452 --- Closing as this review request is more than 2 years old. If

Re: Review Request 102350: Implement automatic scanning of source code for required data engines

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102350/#review99451 --- Closing as this review request is more than 2 years old. If

Re: Review Request 102350: Implement automatic scanning of source code for required data engines

2016-09-22 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102350/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 102291: Trigger installation of missing components when installing a package

2016-09-22 Thread Kevin Kofler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102291/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/#review99449 --- Closing as this review request is more than 2 years old. If

Re: Review Request 102291: Trigger installation of missing components when installing a package

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102291/#review99450 --- Closing as this review request is more than 2 years old. If

Re: Review Request 114424: Add shadow to lancelot main window when using a qt style which supports kde shadow hints

2016-09-22 Thread Yichao Yu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114424/ --- (Updated Sept. 22, 2016, 8:34 p.m.) Status -- This change has been

Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2016-09-22 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/ --- (Updated Sept. 22, 2016, 8:33 p.m.) Status -- This change has been

Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/#review99448 --- Closing as this review request is more than 2 years old. If

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2016-09-22 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/ --- (Updated Sept. 22, 2016, 8:33 p.m.) Status -- This change has been

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107869/#review99447 --- Closing as this review request is more than 2 years old. If

Re: Review Request 109124: qml port currentappcontrol

2016-09-22 Thread Gregor Tätzner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/ --- (Updated Sept. 22, 2016, 8:32 p.m.) Status -- This change has been

Re: Review Request 109124: qml port currentappcontrol

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109124/#review99446 --- Closing as this review request is more than 2 years old. If

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114428/#review99444 --- Closing as this review request is more than 2 years old. If

Re: Review Request 117139: Make menu strings conform to KDE's usability guidelines. Capitalize menu words.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/#review99445 --- Closing as this review request is more than 2 years old. If

Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements

2016-09-22 Thread Heena Mahour
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114428/ --- (Updated Sept. 22, 2016, 8:32 p.m.) Status -- This change has been

Re: Review Request 111770: Implemented search feature in Local Browsing.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111770/#review99443 --- Closing as this review request is more than 2 years old. If

Re: Review Request 119575: Fix krunner contacts pllugin

2016-09-22 Thread Marc Deop
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/ --- (Updated Sept. 22, 2016, 8:31 p.m.) Status -- This change has been

Re: Review Request 119575: Fix krunner contacts pllugin

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/#review99442 --- Closing as this review request is more than 2 years old. If

Re: Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

2016-09-22 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119990/ --- (Updated Sept. 22, 2016, 8:31 p.m.) Status -- This change has been

Re: Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119990/#review99441 --- Closing as this review request is more than 2 years old. If

Re: Review Request 126640: [WindowThumbnail] Discard pixmap on map events.

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126640/#review99440 --- Ship it! So sorry we missed this for so long. I'm not

Re: Review Request 126524: Fixed custom wallpaper being not respected by sddm.

2016-09-22 Thread Joshua Noack
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126524/ --- (Updated Sept. 22, 2016, 3:56 p.m.) Status -- This change has been

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/ --- (Updated Sept. 22, 2016, 7:24 p.m.) Status -- This change has been

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread Pascal VITOUX
> On sep. 22, 2016, 8:53 après-midi, David Edmundson wrote: > > Do you have commit access? No I don't. - Pascal --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99427

Re: Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/#review99427 --- Ship it! Do you have commit access? - David Edmundson

[Differential] [Closed] D2839: make media frame start with random image if set to random

2016-09-22 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS5be10115438c: Make media frame start with random image if set to random (authored by jnicolay, committed by davidedmundson). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST

Widget's Configuration Icon Colors

2016-09-22 Thread John Salatas
Hi! My desktop is configured as follows: Look and Feel: Breeze Desktop Theme: Breeze Screenshot 1 shows Kickoff's Application Launcher Settings Now I change Desktop Theme to Breeze Dark Screenshot 2 shows Kickoff's Application Launcher Settings again. As you can see the Icon (start-here-kde)

[Differential] [Commandeered] D2839: make media frame start with random image if set to random

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson commandeered this revision. davidedmundson edited reviewers, added: jnicolay; removed: davidedmundson. This revision now requires review to proceed. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2839 EMAIL PREFERENCES

[Differential] [Accepted] D2839: make media frame start with random image if set to random

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2839 EMAIL PREFERENCES

[Differential] [Request, 7 lines] D2839: make media frame start with random image if set to random

2016-09-22 Thread jnicolay (Joachim Nicolay)
jnicolay created this revision. jnicolay added a reviewer: Plasma. jnicolay set the repository for this revision to rKDEPLASMAADDONS Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY On startup the media

[Differential] [Closed] D2837: Cleanup test case properly

2016-09-22 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKd5e06ba31129: Cleanup test case properly (authored by davidedmundson). REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2837?vs=6878=6881 REVISION

[Differential] [Accepted] D2837: Cleanup test case properly

2016-09-22 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMASDK Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D2837 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Request, 6 lines] D2838: Fix memory leak + cleanup in projecthandlertest

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Had to open the file to fix something. Fixed some obvious improvements REPOSITORY

[Differential] [Request, 1 line] D2837: Cleanup test case properly

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise if a test fails it would leave a dangling folder which causes subsequent tests to

[Differential] [Request, 1 line] D2836: Enable high DPI support in KCMShell

2016-09-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY I already have this set in system settings for a year so this won't cause any new problems.

[Differential] [Commented On] D2835: add a temporary timer

2016-09-22 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2835#52790, @davidedmundson wrote: > have you seen Aleix's timing stuff in p-f? i don't think it's really useful anymore, as in plasma-framework just tracks how long it takes to build the corona/containments/applets, which is

  1   2   >