broulik added inline comments.
INLINE COMMENTS
> Panel.qml:79
> when: containment
> value: {
> +if (!containment) {
The binding is still evaluated and a value assigned to "value", it's just that
Binding {} won't propagate it to its target when "when" doesn't evalua
mart added inline comments.
INLINE COMMENTS
> mouse.cpp:796
> + foreach (QObject *obj, children) {
> +QAbstractSpinBox *field = qobject_cast(obj);
> +if (field != NULL) {
not sure about this manual resize.
couldn't the kcm just have used a gridlayout instead?
REPOSITORY
rPLASMADESKTO
mart added inline comments.
INLINE COMMENTS
> aspotashev wrote in lnflogic.cpp:66
> Double space here in "Plasma Look And Feel".
fixed
REPOSITORY
rPLASMASDK Plasma SDK
REVISION DETAIL
https://phabricator.kde.org/D2449
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpr
mart added a comment.
what's the status of that?
REPOSITORY
rKIRIGAMI Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2778
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc: plasma-devel, apol
marten added a comment.
A grid layout would fix it, but I assume that the point of using a form
layout is that it would automatically pick up the platform and style policy
(field and label alignment, stretch policy etc).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://p
apol abandoned this revision.
apol added a comment.
I don't like the patch, I'll find a way to work around it.
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D2778
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kiri
So the current version after revisions looks like this. To this comes of
course addendums like the one in previous versions. We simply want feedback on
this so that we know the previous objections are cleared out and we can go
forward
"Plasma is for people using a computing device in a professi
Plasma Meeting minutes 19-9-2016 via IRC
Present: bshah, Sho, Riddell, notmart, sebas
bshah:
- Two mobile IMG updates
- Build fix for discover packaging on MCI
- new appstream and packagekit
- now mobile have new kirigami based discover
- Got tips from mck182 on how to debug the accounts
VDG:
- Breeze Dark for LibreOffice bug fixes were done by kmux from the limux
team. Will be backported and shipped with the next 5.2.x update too.
- Breeze-dark Icon theme for LibreOffice will be shiped with the next major
LO release
- alex update the breeze mimetype icons 90% done will be shiped w
System Settings
To unify and standardize the stystem configurations the modules cursor
theme, colors, emoticons, window decoration get an update.
On 26.09.2016 13:27, Olivier Churlaud wrote:
Hi,
Sorry if I come late, I wasn't aware of this thread...
Le lundi 26 septembre 2016, 12:56:25 CEST Jens Reuterberg a écrit :
"Plasma is for people using a computing device in a professional context,
where productivity, performance and privacy are e
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPc0f7ba8504d3: [Task Manager] Use Qt.binding for
prefix (authored by broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2730?vs=6604&
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAPA59aa9bda6507: [plasma-pa] Set
NotificationAreaCategory to Hardware (authored by broulik).
REPOSITORY
rPLASMAPA Plasma Audio Volume Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/#review99540
---
Ship it!
Ship It!
- Kai Uwe Broulik
On Sept. 23, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128870/#review99542
---
Ping
- Kai Uwe Broulik
On Sept. 9, 2016, 9:41 vorm., Kai U
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128999/
---
(Updated Sept. 26, 2016, 3:56 p.m.)
Status
--
This change has been m
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
At Plasma dependency freeze Discover depended on Kirigami 1.0.
That means it *has* to work
The Plasma dependency freeze was on the 9th of September.
Discover, at dependency freeze, depends on Kirigami 1.0
(and btw, still does)
With Kirigami 1.0 my plasma-discover crashes on boot:
QQmlApplicationEngine failed to load component
qrc:/qml/DiscoverWindow.qml:128 Type DiscoverDrawer unavail
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
(master only)
REPOSITORY
rDISCOVER Discover Software Store
BRANCH
master
REVISION DETAIL
This was discussed in the meeting today, seems a mistake was made in
not freezing this properly. After some discussion it was decided the
best options was to go with the Kirigami 1.1 release which is out
today.
Jonathan
On 26 September 2016 at 18:04, David Edmundson
wrote:
> The Plasma depende
apol accepted this revision.
apol added a reviewer: apol.
apol added a comment.
This revision is now accepted and ready to land.
Please also merge to master and revert the patch there.
REPOSITORY
rDISCOVER Discover Software Store
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kd
Ack, thanks. Just read the full log.
At which point:
- I'll merge https://phabricator.kde.org/D2859 into both branches
- someone should email plasma-packagers (if not done already)
David
apol accepted this revision.
apol added a reviewer: apol.
This revision is now accepted and ready to land.
REPOSITORY
rDISCOVER Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2859
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefe
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.
Should be discarded, it's incompatible with another RR
REPOSITORY
rDISCOVER Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D2858
EMAIL PREFERENCES
https://
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128802/
---
(Updated Sept. 26, 2016, 8:24 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129033/
---
Review request for Plasma.
Repository: systemsettings
Description
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129033/#review99550
---
Ship it!
Ship It!
- David Edmundson
On Sept. 26, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129033/
---
(Updated Sept. 26, 2016, 10:45 p.m.)
Status
--
This change has been
After some review of the existing System Setting overview page I come up
that the subgroups for each main group should be at least near the same,
therefore I'd like to update the Network section.
The main problem of the network section is that you can't configure the
network. The network (lan, wla
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129035/
---
Review request for Plasma.
Repository: systemsettings
Description
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129035/
---
(Updated Sept. 26, 2016, 9:13 p.m.)
Review request for Plasma.
Reposito
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129036/
---
Review request for Plasma.
Repository: plasma-desktop
Description
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129037/
---
Review request for Plasma.
Repository: kscreenlocker
Description
--
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129038/
---
Review request for Plasma.
Repository: sddm-kcm
Description
---
ne
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129039/
---
Review request for Plasma.
Repository: plasma-desktop
Description
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129040/
---
Review request for Plasma.
Repository: plasma-desktop
Description
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129041/
---
Review request for Plasma.
Repository: plasma-desktop
Description
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129039/#review99553
---
Weight changes - I think we can improve on that, and it's goo
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129040/#review99554
---
Ship it!
Ship It!
- David Edmundson
On Sept. 26, 2016,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129035/#review99556
---
Description doesn't match patch - I think you've missed addin
On Mon, Sep 26, 2016 at 10:01 PM, kainz.a wrote:
> After some review of the existing System Setting overview page I come up
> that the subgroups for each main group should be at least near the same,
> therefore I'd like to update the Network section.
>
> The main problem of the network section is
This revision was automatically updated to reflect the committed changes.
Closed by commit rDISCOVER676ce98c0c08: Bump kirigami dependency to include
things we rely on (authored by davidedmundson).
REPOSITORY
rDISCOVER Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde
https://bugs.kde.org/show_bug.cgi?id=357288
Raman Gupta changed:
What|Removed |Added
Status|RESOLVED|UNCONFIRMED
Resolution|UPSTREAM
davidedmundson abandoned this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2826
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, je
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
::activated depends on the mouse click behaviour - as double click
starts a rename this led t
sebas created this revision.
sebas added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This adds a KScreen::Config::Feature for per-display scaling. As we plan
to introduce this with Wayland, we nee
46 matches
Mail list logo