---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129091/#review100188
---
Ship it!
Ship It!
- Eike Hein
On Oct. 6, 2016, 6:03 p.
hein accepted this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3106
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, mart, hein, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
davidedmundson added a subscriber: plasma-devel.
davidedmundson added a project: Plasma.
REVISION SUMMARY
I didn't like the last fix, here's another one, which is maybe a bit
neater?
We have a SourceModel that
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We have a SourceModel that inherits from AbastractModel AbastractModel
inherits from both QOb
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129234/
---
Review request for Plasma.
Repository: kpackage
Description
---
My
This revision was automatically updated to reflect the committed changes.
Closed by commit rLIBKSCREEN6cc05cae8143: allow changing an output's modelist
at runtime (authored by sebas).
REPOSITORY
rLIBKSCREEN KScreen Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3117?vs=7555&i
> Maybe we don't just lack documentation.
>
> What kind of contributions are we expecting? It would be interesting
> to have an outline of what kind of things we're interested in having
> so people doesn't only contribute but also know confidently that
> they're working in our direction.
>
> Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128957/
---
(Updated Oct. 20, 2016, 8:07 p.m.)
Review request for Plasma and David Ed
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/521/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Oct 2016 19:54:20 +
Build duration: 10 min
CHANGE SET
Revision dfefc273af38b9031ba596c20c52165ae4
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128956/
---
(Updated Oct. 20, 2016, 7:53 p.m.)
Status
--
This change has been ma
On Mon, Oct 17, 2016 at 7:00 PM, Jonathan Riddell wrote:
> we need more contributors, junior jobs are best way to get started
> the most critical thing we can do for developer recruitment
> is change the way we publish/blog
> our blogs are mostly work notes aimed at users, we need to
>
On Thu, Oct 20, 2016 at 9:23 AM, Sebastian Kügler wrote:
> On Monday, October 17, 2016 5:56:16 PM UTC Jonathan Riddell wrote:
>> * regression / integration testing (possibly with openQA)
>> (Riddell, bshah, einar77, ...)
>> I want to work on some kind of integration testing /
>> regression te
ltoscano added a comment.
Should this be backported to the 5.8 LTS, if it proves to be stable?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2986
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: roberts, #pl
sitter added inline comments.
INLINE COMMENTS
> graesslin wrote in decoratedclientprivate.h:79
> @sitter with your distro hat on: what do you think works best? We have here a
> public api with a "private" library which is used by KWin.
Even if the API is public... plasma libs have no ABI stabil
graesslin added a subscriber: sitter.
graesslin added inline comments.
INLINE COMMENTS
> graesslin wrote in decoratedclientprivate.h:79
> As that's adding new virtuals we either need to move that into a subclass or
> increase the so version of the private lib (or just ignore, but then distros
>
graesslin added inline comments.
INLINE COMMENTS
> decoratedclientprivate.h:79
>
> +virtual bool hasApplicationMenu() const = 0;
> +virtual bool isApplicationMenuActive() const = 0;
As that's adding new virtuals we either need to move that into a subclass or
increase the so version of
broulik updated the summary for this revision.
broulik updated this revision to Diff 7575.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Switch from using winids and DBus stuff to just reading properties on windows
REPOSITORY
rKWIN KWin
CHANGES
broulik retitled this revision from "WIP: Restore application menu button" to
"[KDecoration] Restore application menu button".
broulik updated this revision to Diff 7574.
broulik added a comment.
Clean up a bit and better wording
REPOSITORY
rKDECORATION Window Decoration Library
CHANGES SI
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7572.
broulik added a comment.
deleteLater() the importer - fixes activating menu items
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3086?vs=7570&i
broulik updated the summary for this revision.
broulik updated the test plan for this revision.
broulik updated this revision to Diff 7570.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3086?vs=7461&id=7570
REVISION DETAIL
https://phabr
broulik updated this revision to Diff 7569.
broulik added a comment.
Add missing qdbusmenubar_p.h file as well as some typos and cleanups
Linking autotests fails :/
REPOSITORY
rPLASMAINTEGRATION Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
https://phabricator.k
https://bugs.kde.org/show_bug.cgi?id=371276
Harald Sitter changed:
What|Removed |Added
Resolution|--- |INVALID
Status|UNCONFIRMED
davidedmundson added a comment.
Seems to work.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3098
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: mart, plasma-devel, lesliezhai,
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/520/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 20 Oct 2016 11:52:52 +
Build duration: 15 min
CHANGE SET
Revision 1948839b82b53c0bd085b2f7a7bff6c960
https://bugs.kde.org/show_bug.cgi?id=371276
Rajeesh K V changed:
What|Removed |Added
CC||rajeeshknamb...@gmail.com
--- Comment #3 from Raj
antlarr closed this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2981
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreute
https://bugs.kde.org/show_bug.cgi?id=371276
--- Comment #2 from Harald Sitter ---
If it works on neon it's hardly a problem with the theme though. Not quite sure
what to do with this.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=371276
--- Comment #1 from somnium ---
I forgot to mention the plymouth version: it is plymouth 0.9.2
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=371276
Bug ID: 371276
Summary: Only black screen with breeze plymouth theme in plasma
5.8.2
Product: Breeze
Version: 5.8.2
Platform: openSUSE RPMs
OS: Linux
S
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
BRANCH
platform-cursor-show-hide
REVISION DETAIL
https://phabricator.kde.org/D3119
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferenc
This revision was automatically updated to reflect the committed changes.
Closed by commit rKINFOCENTERb09e02621149: Pass transient parent window to
KToolTipWindow (authored by graesslin).
REPOSITORY
rKINFOCENTER KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3113?vs=7547
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
for me good to go (maybe wait for eike's ship it as well)
REPOSITORY
rPLASMADESKTOP Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3106
EMAIL PREFERENCES
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rSYSTEMSETTINGS256b4a1d: Pass transient parent window to
KToolTipWindow (authored by graesslin).
REPOSITORY
rSYSTEMSETTINGS System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D31
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D2981
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailp
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rLIBKSCREEN KScreen Library
BRANCH
sebas/modelistchange
REVISION DETAIL
https://phabricator.kde.org/D3117
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/em
graesslin added a comment.
In https://phabricator.kde.org/D3112#57826, @bcooksley wrote:
> This looks fine to me. The whole KToolTip class thing should at some point
be replaced or merged with the code which Dolphin and KInfoCenter use - which
is basically the same last I recall.
antlarr added a comment.
Oops, sorry, I wrote a reply yesterday but forgot to submit it :/
INLINE COMMENTS
> mart wrote in accountmodel.cpp:165
> is there absolutely nothing left needing this?
I can't find anything at least. I tested the systemsettings window is updated
correctly everywhere
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
On Wayland we do not need the selection. By only creating the
KSel
mart added a comment.
ping?
REPOSITORY
rUSERMANAGER User Manager
REVISION DETAIL
https://phabricator.kde.org/D3102
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abett
graesslin added a dependency: D3119: Add way to hide/show cursor in Platform.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3120
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayland
Cc: plasma-devel, k
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
The implementation delegates to the Platform to perform the actual
graesslin added a dependent revision: D3120: [kwineffects] Add hide/show cursor
to EffectsHandler.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3119
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #kwin, #plasma_on_wayla
graesslin created this revision.
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added subscribers: kwin, plasma-devel.
Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY
Some platforms support to hide and show the cursor. This will be nee
sebas added a comment.
To make it work, we'll also need https://phabricator.kde.org/D3117
I haven't tested it, though.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2155
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
sebas requested a review of this revision.
sebas added a reviewer: Plasma.
sebas added a comment.
Requesting review, as this patch is correct with the dynamic modelist
changes. I'd like it in.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2155
EMAIL PREFERENCE
sebas added a comment.
This would go together with https://phabricator.kde.org/D2155 .
REPOSITORY
rLIBKSCREEN KScreen Library
REVISION DETAIL
https://phabricator.kde.org/D3117
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, #plasma
Cc: graessl
On Tuesday, October 18, 2016 11:17:02 PM UTC Martin Klapetek wrote:
> As the former KAccounts maintainer, I'd like to share some insights on this.
Thanks for your insights.
> There was
> an OwnCloud lib or Plasma thingy at some point where I pleaded to have the
> account setup done through (K)Acc
On Tuesday, October 18, 2016 11:24:00 AM UTC Marco Martin wrote:
> On Monday 17 October 2016, Jonathan Riddell wrote:
> > we need more contributors, junior jobs are best way to get
> >
> > started the most critical thing we can do for developer recruitment
> > is change the way we publish/bl
On Monday, October 17, 2016 6:06:41 PM UTC Jonathan Riddell wrote:
> no discussion on this on during the meeting, do we need 5.7, are
> distros happy with 5.7?
We discussed it in the other thread, the conclusion is that we'd like to
depend on 5.7 in Plasma 5.9.
The question whether that works fo
On Tuesday, October 18, 2016 1:16:33 PM UTC Marco Martin wrote:
> On Tuesday 18 October 2016, Martin Klapetek wrote:
> > On Mon, Oct 17, 2016 at 12:59 PM, Jonathan Riddell
wrote:
> > > biggest pain point from bugzilla is mostly still
> > >
> > > multiscreen. I'm not sure we have a solid plan
On Monday, October 17, 2016 5:56:16 PM UTC Jonathan Riddell wrote:
> * regression / integration testing (possibly with openQA)
> (Riddell, bshah, einar77, ...)
> I want to work on some kind of integration testing /
> regression testing for plasma and plasma mobile stuff combined
> bshah:
On Tuesday, October 18, 2016 12:44:01 PM UTC Martin Graesslin wrote:
> Other issues we regularly get reported is windows not opening on the screen
> the user expects them to open. Mostly a problem, because on X11 almost
> every application provides a positioning hint which kwin honors.
>
> Both i
bcooksley added a comment.
This looks fine to me. The whole KToolTip class thing should at some point be
replaced or merged with the code which Dolphin and KInfoCenter use - which is
basically the same last I recall.
REPOSITORY
rSYSTEMSETTINGS System Settings
BRANCH
wayland-fix-tooltips
53 matches
Mail list logo
