[Differential] [Commented On] D3306: Convert virtual backend to per screen rendering

graesslin added a comment. code looks fine to me. Which tests are failing for you? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3306 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: graesslin,

[Differential] [Request, 20 lines] D3313: Return a reference to AppData instead of the whole tuple

apol created this revision. apol added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way we can use Private::appData(WId) for modifying the cache values Doesn't imply a copy every time we

[Differential] [Accepted] D3312: scale property for KScreen::Output

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. we probably don't want the qDebug line though REPOSITORY rLIBKSCREEN KScreen Library BRANCH sebas/scaleprop REVISION

[Differential] [Updated, 46 lines] D3312: scale property for KScreen::Output

sebas updated this revision to Diff 8028. sebas added a comment. - parse scale from json files REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3312?vs=8027=8028 BRANCH sebas/scaleprop REVISION DETAIL https://phabricator.kde.org/D3312

[Differential] [Request, 40 lines] D3312: scale property for KScreen::Output

sebas created this revision. sebas added a reviewer: graesslin. sebas added a subscriber: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This adds a scale property to KScreen::Output. By default, it's

[Differential] [Updated, 189 lines] D3302: [Task Manager] Indicate applications playing audio

broulik updated this revision to Diff 8026. broulik added a comment. - Handle pid changing in the model Task bar can shuffle around tasks so the delegate is re-used but shows a different application; in this case we want to update. I just had Dolphin think it had an audio stream of

[Differential] [Commented On] D3302: [Task Manager] Indicate applications playing audio

apol added a comment. +1 really cool! INLINE COMMENTS > main.xml:92 > > + > + Whether to indicate applications that are playing audio > including an option to mute them. Do we really need to make it configurable? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Updated, 187 lines] D3302: [Task Manager] Indicate applications playing audio

broulik retitled this revision from "RFC: [Task Manager] Indicate applications playing audio" to "[Task Manager] Indicate applications playing audio". broulik updated the summary for this revision. broulik updated the test plan for this revision. broulik updated this revision to Diff 8024.

[Differential] [Updated, 21 lines] D3268: Applet: Show device icons and active port name

drosca updated this revision to Diff 8025. drosca added a comment. Change label to "PortName (DeviceName)" REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3268?vs=7913=8025 BRANCH device-icons (branched from master) REVISION

[Differential] [Commented On] D3268: Applet: Show device icons and active port name

drosca added a comment. Updated screenshot: F498804: Spectacle.TJ7708.png REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3268 EMAIL PREFERENCES

[Differential] [Closed] D3311: Dependency resolution code was moved to KPackage

apol closed this revision. REVISION DETAIL https://phabricator.kde.org/D3311 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3311: Dependency resolution code was moved to KPackage

mart accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3311 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated] D3311: Dependency resolution code was moved to KPackage

apol retitled this revision from "Dependency resolution code was moved to KPackagDependency resolution code was moved to KPackagee" to "Dependency resolution code was moved to KPackage". REVISION DETAIL https://phabricator.kde.org/D3311 EMAIL PREFERENCES

Re: Review Request 129098: Add keyboard icons for kimpanel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129098/ --- (Updated Nov. 8, 2016, 3:31 p.m.) Status -- This change has been

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review100730 --- I update the stylesheed stuff so please have a look if the

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- (Updated Nov. 8, 2016, 4:21 p.m.) Status -- This change has been

Re: Review Request 128907: Remove Konqueror kcm docbooks from plasma-desktop repo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128907/ --- (Updated Nov. 8, 2016, 4:16 p.m.) Status -- This change has been

[Differential] [Updated] D3311: Dependency resolution code was moved to KPackagDependency resolution code was moved to KPackagee

apol updated the summary for this revision. apol added a dependency: D3299: Let KPackage know about X-Plasma-RootPath. REVISION DETAIL https://phabricator.kde.org/D3311 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: plasma-devel,

Re: Review Request 128907: Remove Konqueror kcm docbooks from plasma-desktop repo

> On Sept. 14, 2016, 2:55 nachm., Aleix Pol Gonzalez wrote: > > will you do the move from kde-runtime -> kdebase-apps? > > Luigi Toscano wrote: > First we may want to split kde-baseapps (see the email on > kde-core-devel), but apart from that, yes. > > Burkhard Lück wrote: > ALeix: >

[Differential] [Request, 18 lines] D3311: Dependency resolution code was moved to KPackagDependency resolution code was moved to KPackagee

apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN plasma still starts with all plasmoids BRANCH master REVISION DETAIL https://phabricator.kde.org/D3311

[Differential] [Closed] D3308: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7c443aa53900: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3309: [XWindowTasksModel] Check for service being empty before searching new ones

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE61860066a4ce: [XWindowTasksModel] Check for service being empty before searching new ones (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3292: Revamp Wayland application identification; align Wayland and X11 models

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE273631af51ad: Revamp Wayland application identification; align Wayland and X11 models (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3292: Revamp Wayland application identification; align Wayland and X11 models

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3292 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Accepted] D3308: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3308 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc:

[Differential] [Updated, 7 lines] D3308: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome

broulik updated this revision to Diff 8017. broulik added a comment. Add comment REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3308?vs=8014=8017 REVISION DETAIL https://phabricator.kde.org/D3308 AFFECTED FILES

[Differential] [Requested Changes To] D3308: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Can you add a comment explaining the why? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3308 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D3309: [XWindowTasksModel] Check for service being empty before searching new ones

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If our regular

[Differential] [Request, 6 lines] D3308: [taskmanagerrulesrc] Add Rewrite Rule for Google-chrome

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Google Chrome

[Differential] [Planned Changes To] D3265: Make it possible for 5.8 to compile against the last AppStreamQt

apol planned changes to this revision. apol added a comment. Hold your horses... :) We need some changes still, since the find_package call also changed -.- REPOSITORY rDISCOVER Discover Software Store REVISION DETAIL https://phabricator.kde.org/D3265 EMAIL PREFERENCES

Re: Review Request 129098: Add keyboard icons for kimpanel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129098/ --- (Updated 十一月 8, 2016, 1:29 p.m.) Review request for Plasma. Changes

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- (Updated 十一月 8, 2016, 1:28 p.m.) Review request for Plasma. Changes

[Differential] [Accepted] D3265: Make it possible for 5.8 to compile against the last AppStreamQt

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rDISCOVER Discover Software Store BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3265 EMAIL PREFERENCES

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review100720 --- I'm really sorry but I can't download the svgz files -

[Differential] [Updated, 85 lines] D3265: Make it possible for 5.8 to compile against the last AppStreamQt

apol updated this revision to Diff 8010. apol added a comment. - Move ifdefs to Discover instead of modifying Appstream REPOSITORY rDISCOVER Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3265?vs=7907=8010 BRANCH Plasma/5.8 REVISION DETAIL

[Differential] [Commented On] D3238: Use our tooling for installing components

apol added a comment. Adds an unwanted KPackage dependency REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D3238 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Abandoned] D3238: Use our tooling for installing components

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D3238 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Abandoned] D2881: Fix binding loop

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2881 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, sitter, mart Cc: plasma-devel, apol

[Differential] [Abandoned] D2682: Make sure padding is respected in the GlobalDrawer

apol abandoned this revision. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2682 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Closed] D3300: [Stream] Expose "corked" property

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPAc64fe1cfcf34: [Stream] Expose "corked" property (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3300?vs=7983=8009#toc REPOSITORY rPLASMAPA Plasma Audio Volume

Re: Review Request 129098: Add keyboard icons for kimpanel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129098/ --- (Updated 十一月 8, 2016, 11:03 a.m.) Review request for Plasma. Changes

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- (Updated 十一月 8, 2016, 10:54 a.m.) Review request for Plasma. Changes

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

> On Okt. 21, 2016, 5:57 vorm., Eike Hein wrote: > > Ship It! > > Yunhe Guo wrote: > Could anyone push it? I donot have access. please upload the svg files, I will ship them - Andreas --- This is an automatically generated e-mail.

Re: Review Request 129091: Add icons for Kimpanel and Fcitx

> On 十月 21, 2016, 5:57 a.m., Eike Hein wrote: > > Ship It! Could anyone push it? I donot have access. - Yunhe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/#review100188

[Differential] [Closed] D3269: kcm_keyboard: Change text of config action in tray icon to Configure Layouts

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb2e176f15d98: kcm_keyboard: Change text of config action in tray icon to Configure Layouts (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated, 200 lines] D3292: Revamp Wayland application identification; align Wayland and X11 models

hein updated this revision to Diff 8007. hein added a comment. More QStringLiteral ... REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3292?vs=8005=8007 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3292 AFFECTED

[Differential] [Commented On] D3292: Revamp Wayland application identification; align Wayland and X11 models

graesslin added inline comments. INLINE COMMENTS > waylandtasksmodel.cpp:375 > +if (!data.id.isEmpty()) { > + > KActivities::ResourceInstance::notifyAccessed(QUrl("applications:" + data.id), > +QStringLiteral("org.kde.libtaskmanager")); another QStringLiteral

Re: Review Request 129329: Fix SVG icon ID prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129329/ --- (Updated Nov. 8, 2016, 10:54 a.m.) Status -- This change has been

Re: Review Request 129329: Fix SVG icon ID prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129329/ --- (Updated 十一月 8, 2016, 9:46 a.m.) Review request for Plasma.

Re: Review Request 129329: Fix SVG icon ID prefix

> On Nov. 7, 2016, 4:28 p.m., Marco Martin wrote: > > Thanks for taking care of it! > > Aleix Pol Gonzalez wrote: > @Yunhe, do you have pushing rights or should we push it? > > Yunhe Guo wrote: > No, I do not. Maybe you can push it. since it's a binary change,i can't take it from

[Differential] [Accepted] D3290: Introduce a VirtualDesktop class

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH virtual-desktop-refactoring REVISION DETAIL https://phabricator.kde.org/D3290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Updated] D3292: Revamp Wayland application identification; align Wayland and X11 models

hein marked 5 inline comments as done. hein added inline comments. INLINE COMMENTS > graesslin wrote in launchertasksmodel.cpp:134 > nitpick: added newline Intentional - my style tends to involve a lot of whitespace I guess (I personally find it more readable when browsing code). > graesslin

[Differential] [Updated, 198 lines] D3292: Revamp Wayland application identification; align Wayland and X11 models

hein updated this revision to Diff 8005. hein marked 5 inline comments as done. hein added a comment. Sprinkle more QLatin1String/QStringLiteral. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3292?vs=8003=8005 BRANCH master

[Differential] [Commented On] D3292: Revamp Wayland application identification; align Wayland and X11 models

graesslin added inline comments. INLINE COMMENTS > launchertasksmodel.cpp:134 > +const AppData = appDataFromUrl(url, > QIcon::fromTheme(QLatin1String("unknown"))); > + > +appDataCache.insert(url, data); nitpick: added newline > tasktools.cpp:145 > + > +if

[Differential] [Updated, 196 lines] D3292: Revamp Wayland application identification; align Wayland and X11 models

hein updated this revision to Diff 8003. hein added a comment. Optimize cache accessors. Avoid double iteration of hashes. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3292?vs=7972=8003 BRANCH master REVISION DETAIL