[Differential] [Updated] D3335: Move resolving glxSwapIntervalMesa into platform plugin

graesslin updated the test plan for this revision. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3335 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, lesliezhai,

[Differential] [Updated] D3335: Move resolving glxSwapIntervalMesa into platform plugin

graesslin added a dependency: D3332: Move querying glx extensions into the platform plugin. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3335 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc:

[Differential] [Updated] D3332: Move querying glx extensions into the platform plugin

graesslin added a dependent revision: D3335: Move resolving glxSwapIntervalMesa into platform plugin. REPOSITORY rKWIN KWin BRANCH glx-extensions-to-platform REVISION DETAIL https://phabricator.kde.org/D3332 EMAIL PREFERENCES

[Differential] [Request, 65 lines] D3335: Move resolving glxSwapIntervalMesa into platform plugin

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY No need to resolve glx methods through the shared lib. At the

[Differential] [Changed Subscribers] D3329: Move glx version check functionality to platform plugin

broulik added inline comments. INLINE COMMENTS > glxbackend.cpp:253 > +glXQueryVersion(display(), , ); > +return kVersionNumber(major, minor) >= kVersionNumber(1, 3); > +} Just fyi: QVersionNumber is public since Qt 5.6 REPOSITORY rKWIN KWin REVISION DETAIL

[Differential] [Updated] D3332: Move querying glx extensions into the platform plugin

graesslin added a dependency: D3329: Move glx version check functionality to platform plugin. REPOSITORY rKWIN KWin BRANCH glx-extensions-to-platform REVISION DETAIL https://phabricator.kde.org/D3332 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D3329: Move glx version check functionality to platform plugin

graesslin added a dependent revision: D3332: Move querying glx extensions into the platform plugin. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3329 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Commented On] D3332: Move querying glx extensions into the platform plugin

graesslin added inline comments. INLINE COMMENTS > broulik wrote in scene_opengl.h:648 > QVector? yes and no. I would love to use QVector here and that was what I wanted to use in the first place. But it will always be filled from a QByteArray::split and that returns a QList. So I don't think

Re: Review Request 129358: Return SurfaceInterface::size in surface normal co-ordinates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129358/#review100769 --- unrelated: you could have used phab for the request :-)

[Differential] [Commented On] D3183: Port potd (picture of the day) dataengine to KF5.

xuetianweng added inline comments. INLINE COMMENTS > mart wrote in wcpotdprovider.cpp:54 > other copy of invalid url emm.. I thought I fixed. nvm. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3183 EMAIL PREFERENCES

[Differential] [Updated, 571 lines] D3183: Port potd (picture of the day) dataengine to KF5.

xuetianweng updated this revision to Diff 8083. xuetianweng marked 8 inline comments as done. xuetianweng added a comment. Update flickr api key and wiki potd url REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3183?vs=7710=8083 BRANCH

[Differential] [Commented On] D3210: make scrollbar size configurable

colomar added a comment. In https://phabricator.kde.org/D3210#62062, @mart wrote: > > sorry for the late reply > ok, so if i understood correctly: > I'll remove those 2 options, and have instead both showing the scrollbar on hover *and* the scrollbar size depend

Re: Review Request 129373: Plasma Framework changes for #129372

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129373/#review100765 --- src/declarativeimports/core/tooltipdialog.cpp (line 109)

Re: Review Request 129372: Delay Tooltip in Task Manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129372/ --- (Updated Nov. 10, 2016, 9:03 nachm.) Review request for Plasma and Eike

Re: Review Request 129372: Delay Tooltip in Task Manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129372/#review100764 --- There doesn't seem to be a patch attached, check the

Re: Review Request 129373: Plasma Framework changes for #129372

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129373/#review100763 --- Thanks for your patch! I'm not fully sure about this, but

Review Request 129373: Plasma Framework changes for #129372

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129373/ --- Review request for Plasma and Eike Hein. Repository: plasma-framework

Review Request 129372: Delay Tooltip in Task Manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129372/ --- Review request for Plasma and Eike Hein. Summary (updated)

[Differential] [Commented On] D3333: merge

sebas added a comment. Bah, https://phabricator.kde.org/D2155 is the relevant review this push should have closed. Sorry for noise & possible confusion. :/ REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D EMAIL PREFERENCES

[Differential] [Abandoned] D2155: kded: fix up invalid current mode before saving

sebas abandoned this revision. sebas added a comment. I've screwed up a rebase and accidentally pushed this patch as https://phabricator.kde.org/D . I'll abandon this review, but the change was really pushed. Sorry for the noise and possible confusion. REPOSITORY rKSCREEN KScreen

[Differential] [Commented On] D3334: [Notifications] Check if we're assigned a containment()

davidedmundson added a comment. That won't fix the crash report linked. That's a crash in PlasmaQuick::ContainmentView::containment() which you're still calling in exactly the same way, no? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Request, 4 lines] D3334: [Notifications] Check if we're assigned a containment()

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This function is not

[Differential] [Changed Subscribers] D3332: Move querying glx extensions into the platform plugin

broulik added inline comments. INLINE COMMENTS > scene_opengl.h:648 > + > +QList m_extensions; > }; QVector? REPOSITORY rKWIN KWin BRANCH glx-extensions-to-platform REVISION DETAIL https://phabricator.kde.org/D3332 EMAIL PREFERENCES

[Differential] [Closed] D3265: Make it possible for 5.8 to compile against the last AppStreamQt

This revision was automatically updated to reflect the committed changes. Closed by commit rDISCOVERc52df7007183: Make it possible for 5.8 to compile against the last AppStreamQt (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3265?vs=8010=8080#toc REPOSITORY

[Differential] [Closed] D3333: merge

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN23006c1b9bc6: merge (authored by sebas). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D?vs=8078=8079 REVISION DETAIL

[Differential] [Request, 10 lines] D3333: merge

sebas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKSCREEN KScreen BRANCH fixupmodeid REVISION DETAIL https://phabricator.kde.org/D AFFECTED FILES kded/daemon.cpp EMAIL PREFERENCES

Re: Review Request 129358: Return SurfaceInterface::size in surface normal co-ordinates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129358/ --- (Updated Nov. 10, 2016, 3:56 p.m.) Review request for Plasma. Changes

[Differential] [Accepted] D3332: Move querying glx extensions into the platform plugin

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH glx-extensions-to-platform REVISION DETAIL https://phabricator.kde.org/D3332 EMAIL PREFERENCES

[Differential] [Request, 64 lines] D3332: Move querying glx extensions into the platform plugin

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Glx extensions are only interesting to the glxbackend. Given that

[Powerdevil] [Bug 357288] Setting "Screen Energy Saving" in "Energy Saving" config has no effect

https://bugs.kde.org/show_bug.cgi?id=357288 --- Comment #8 from Jiri Tyr --- I'm suffering from the same issue. The screen power management doesn't work properly when the screen is locked. This is the log from xset -q: $ while [ true ]; do echo -n '['$(date +%T)']'; xset -q

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. In https://phabricator.kde.org/D3210#61533, @colomar wrote: > Whoa okay, that is complex... > Given that I failed to understand what the proposed checkboxes were supposed to mean, I fear it will be the same for users. > Therefore maybe not gibing the option at

[Differential] [Updated, 58 lines] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

broulik updated this revision to Diff 8074. broulik added a comment. Fix import REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3330?vs=8073=8074 REVISION DETAIL https://phabricator.kde.org/D3330 AFFECTED FILES

[Differential] [Commented On] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

graesslin added inline comments. INLINE COMMENTS > main.qml:21-22 > import QtQuick 2.0 > import org.kde.plasma.core 2.0 as PlasmaCore > +import org.kde.plasma.core 2.0 as PlasmaComponents > import org.kde.kquickcontrolsaddons 2.0 this looks slightly wrong. Copy and paste error? REPOSITORY

[Differential] [Request, 58 lines] D3330: [Window/Desktop Switchers] Use PlasmaComponents.Label instead of Text

broulik created this revision. broulik added reviewers: Plasma, graesslin. broulik set the repository for this revision to rKDEPLASMAADDONS Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The former uses

[Differential] [Request, 23 lines] D3329: Move glx version check functionality to platform plugin

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Glx version is only required once in the standalone x11 platform.

[Differential] [Closed] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP77463a0143d8: [Touchpad KCM] Prevent save dialog if no touchpad was found (authored by subdiff). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3324 EMAIL PREFERENCES

[Differential] [Request, 358 lines] D3327: VirtualDesktopGrid operates on VirtualDesktop objects

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, hein. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The VirtualDesktopGrid is ported to the new VirtualDesktop

[Differential] [Abandoned] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

graesslin abandoned this revision. graesslin added a comment. Change is reverted. That just doesn't work with style sheets. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3240 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 5 lines] D3324: [Touchpad KCM] Prevent save dialog if no touchpad was found

subdiff updated this revision to Diff 8064. subdiff marked an inline comment as done. subdiff added a comment. Adjusted name. REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3324?vs=8058=8064 REVISION DETAIL

[Differential] [Closed] D3319: Load screenpool at the same time as we connect to screenchanged signals

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7154fb681adc: Load screenpool at the same time as we connect to screenchanged signals (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3323: Make it possible for plasmashell to log into kscreen.log

cfeck added a comment. Sorry, my fault. I was completely unaware that Plasma does not even use kscreen. Now that I have seen how it works, I am no longer disappointed to not find Plasma steps in the kscreen logs. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Accepted] D3319: Load screenpool at the same time as we connect to screenchanged signals

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3319 EMAIL PREFERENCES

[Differential] [Commented On] D2155: kded: fix up invalid current mode before saving

sebas added a comment. Merging it as I've asked for reviews repeatedly but nobody dares. I'm daring! REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2155 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, graesslin,

[Differential] [Updated, 14 lines] D3319: Load screenpool at the same time as we connect to screenchanged signals

davidedmundson updated this revision to Diff 8060. davidedmundson added a comment. sort out the unused line REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3319?vs=8041=8060 BRANCH Plasma/5.8 REVISION DETAIL

[Breeze] [Bug 371422] Breeze-Theme for sddm and Intel Graphics HD 530

https://bugs.kde.org/show_bug.cgi?id=371422 Stefan Schmid changed: What|Removed |Added Resolution|--- |INVALID

[Differential] [Abandoned] D3323: Make it possible for plasmashell to log into kscreen.log

sebas abandoned this revision. sebas added a comment. We may already have fixed the most pressing problem needing this, so postponing/abandoning it for now. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3323 EMAIL PREFERENCES

[Differential] [Commented On] D3319: Load screenpool at the same time as we connect to screenchanged signals

mart added a comment. In https://phabricator.kde.org/D3319#61870, @fvogt wrote: > A quick question: This changes what the ScreenPool constructor does, are there any potential users of ScreenPool that now miss a call to ->load(), as it was done implicitly before? Wouldn't it be safer to

[Differential] [Closed] D3290: Introduce a VirtualDesktop class

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN4f4d9d5cfe40: Introduce a VirtualDesktop class (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3290?vs=7986=8059 REVISION DETAIL