[Differential] [Request, 78 lines] D3493: [effects] Cleanup screenshot effect

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change cleans up the screenshot effect a little bit. - better check whether a

[Differential] [Closed] D3476: Support screenshot current screen and fullscreen on KWin/Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit rSPECTACLE517a7baf46a4: Support screenshot current screen and fullscreen on KWin/Wayland (authored by graesslin). REPOSITORY rSPECTACLE Spectacle CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3467: Ignore non-relevant modifiers when evaluating mouse actions

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN0b47b84816ac: Ignore non-relevant modifiers when evaluating mouse actions (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3467?vs=8426=8492

[Differential] [Closed] D3475: Add interactive position selection to screenshot screen under cursor

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf9f7b84cb436: Add interactive position selection to screenshot screen under cursor (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3397: Port Compositor::windowRepaintsPending to use std::any_of

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINec2d862d4e98: Port Compositor::windowRepaintsPending to use std::any_of (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3397?vs=8255=8491

[Differential] [Updated, 235 lines] D3480: [effects] Add a colorpicker effect

graesslin updated this revision to Diff 8490. graesslin marked an inline comment as done. graesslin added a comment. Adressed d_ed's comments REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3480?vs=8465=8490 BRANCH color-picker-effect REVISION DETAIL

[Differential] [Updated] D3480: [effects] Add a colorpicker effect

graesslin marked 2 inline comments as done. graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in colorpicker.cpp:56 > KWin has a lovely class ClearablePoint for doing exactly this only in utils.h, we cannot use that in the effects :-( > davidedmundson wrote in

[kdeplasma-addons] [Bug 372885] Not getting grouping desktop layout in desktop settings

https://bugs.kde.org/show_bug.cgi?id=372885 Christoph Feck changed: What|Removed |Added Product|Plasma Workspace Wallpapers |kdeplasma-addons

[Differential] [Commented On] D3476: Support screenshot current screen and fullscreen on KWin/Wayland

bgupta added a comment. Good point. This is going to need more insidious changes in Spectacle. Alright, ship this for now. REPOSITORY rSPECTACLE Spectacle BRANCH kwin-screenshot-screen REVISION DETAIL https://phabricator.kde.org/D3476 EMAIL PREFERENCES

[Differential] [Commented On] D3475: Add interactive position selection to screenshot screen under cursor

bgupta added a comment. Yeah, I was planning on each plugin returning a list of supported grab modes and ancillary features (on click, timeouts, etc), and modifying the UI based on that information. Ship this for now. I'll work on this when I'm done with college (end of December this

[Differential] [Commented On] D3480: [effects] Add a colorpicker effect

davidedmundson added a comment. looks good to me too. INLINE COMMENTS > colorpicker.cpp:56 > +: m_replyConnection(QDBusConnection::sessionBus()) > +, m_scheduledPosition(QPoint(-1, -1)) > +{ KWin has a lovely class ClearablePoint for doing exactly this > colorpicker.cpp:64 > +{ > +

[Differential] [Commented On] D3475: Add interactive position selection to screenshot screen under cursor

graesslin added a comment. In https://phabricator.kde.org/D3475#64970, @bgupta wrote: > Hmm, so "On Click" mode is always selected. Yeah, I want to modify the UI of spectacle to not offer unsupported options. REPOSITORY rKWIN KWin BRANCH screenshot-screen-fullscreen

[Differential] [Accepted] D3475: Add interactive position selection to screenshot screen under cursor

bgupta accepted this revision. bgupta added a comment. This revision is now accepted and ready to land. Hmm, so "On Click" mode is always selected. REPOSITORY rKWIN KWin BRANCH screenshot-screen-fullscreen REVISION DETAIL https://phabricator.kde.org/D3475 EMAIL PREFERENCES

[Differential] [Closed] D3489: Take control on default properties on *ListItem

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI64bc2a908f80: Take control on default properties on *ListItem (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3489?vs=8480=8481

[Differential] [Accepted] D3489: Take control on default properties on *ListItem

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3489 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart

[Differential] [Request, 9 lines] D3489: Take control on default properties on *ListItem

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In general everything that inherits AbstractListItem will have just one graphical element and this one

Re: Touchpad Gestures - Experimental

Hi Jens, I'm extremely sorry, there must have been a huge misunderstanding. Most of the gestures you came up with are not at all supported. We only get the following touchpad gestures reported: * multi-finger pinch/rotate gesture * multi-finger swipe gesture The supported gestures are

[Differential] [Accepted] D3480: [effects] Add a colorpicker effect

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH color-picker-effect REVISION DETAIL https://phabricator.kde.org/D3480 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

Touchpad Gestures - Experimental

Sry for long wait, there was some misunderstandings concerning touchpad gestures based on past work and was set right today that no matter on what level we where at, we should pass it onward. So these are all based on the normal assumptions and understanding of how designing something which we

[Plasma Workspace Wallpapers] [Bug 372885] New: Not getting grouping desktop layout in desktop settings

https://bugs.kde.org/show_bug.cgi?id=372885 Bug ID: 372885 Summary: Not getting grouping desktop layout in desktop settings Product: Plasma Workspace Wallpapers Version: 5.5.5 Platform: Other OS: Linux

[Differential] [Commented On] D3484: Center systemmonitor window properly on multi-screen setup

graesslin added a comment. KRunner is different. It's not "a normal window". But the systemmonitor is a normal window. It's just me the grumpy window manager speaking. We regularly get bug reports about window not opening on the screen the user expect. Reason for that is that apps do

[Differential] [Closed] D3469: [taskmanagerrulesrc] Add Rewrite Rule for chromium

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE97ff71b5efe0: [taskmanagerrulesrc] Add Rewrite Rule for chromium (authored by drosca). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3204: [KSMServer] Turn user switcher into a separate binary

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEec1c80326a07: [KSMServer] Turn user switcher into a separate binary (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 99 lines] D3488: [platforms/wayland] Use a ConfinedPointer if available

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This supports "grabbing" the pointer on right ctrl key just like on

Moving widget via plasmascripts (Javascript)

Dear all, I am having some difficulty with editing geometries of plasmoids/widgets. After adding a widget, changes to the widget's *geometry* attribute are ignored: *var folderview_network = desktopsArray[j].addWidget('org.kde.plasma.folder');* *folderview_network.geometry = new

Re: Split the kioslaves out of plasma-workspace?

On Wednesday 23 November 2016 16:56:22 Elvis Angelaccio wrote: > > I think you're right that they could go in frameworks. I don't think it > > wouldn't bring any new dependencies and it already has a few ioslaves > > > > The other option is we make Dolphin check for the KIO existing before > >

[Differential] [Commented On] D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov added a comment. I'm not familiar with KDE, but it seems that's how krunner manages it's position too (method View::positionOnScreen in krunner/view.cpp), except that it doesn't use windowHandle() and derives current screen from cursor position, and takes struts in account

[Differential] [Commented On] D3484: Center systemmonitor window properly on multi-screen setup

graesslin added a comment. I don't like the code. Neither the one which used to be there, nor the new one. Centering on the screen is not the task of a window, but of the window manager and that code won't work on Wayland. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Accepted] D3484: Center systemmonitor window properly on multi-screen setup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3484 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3483: Publish delegate geometry when ChildCount increases.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3483 EMAIL PREFERENCES

[Differential] [Commented On] D3480: [effects] Add a colorpicker effect

graesslin added inline comments. INLINE COMMENTS > broulik wrote in colorpicker.cpp:51 > So this won't work in case of QPainter? Maybe the color picker should > communicate that to the user when it's not possible to pick a color? The supported means KWin won't load the effect at all. How to

[Differential] [Accepted] D3482: Expose rowCount as data role in TaskGroupingProxyModel.

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3482 EMAIL PREFERENCES

[Differential] [Commented On] D3480: [effects] Add a colorpicker effect

broulik added inline comments. INLINE COMMENTS > colorpicker.cpp:51 > +{ > +return effects->isOpenGLCompositing(); > +} So this won't work in case of QPainter? Maybe the color picker should communicate that to the user when it's not possible to pick a color? > colorpicker.h:37 > +

[Differential] [Accepted] D3481: [applets] Support KWin/Wayland in ColorPicker

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Awesome! REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH kwin-wayland-color-picker REVISION DETAIL https://phabricator.kde.org/D3481 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D3484: Center systemmonitor window properly on multi-screen setup

valeriymalov created this revision. valeriymalov added a reviewer: Plasma: Workspaces. valeriymalov set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. valeriymalov added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma:

[Differential] [Updated] D3479: [libinput] Add more support for touchpads in preparation for the new touchpad KCM

subdiff updated the summary for this revision. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #kwin, #plasma Cc: graesslin, davidedmundson, plasma-devel, kwin, #kwin,

[Differential] [Updated] D3482: Expose rowCount as data role in TaskGroupingProxyModel.

hein added a dependent revision: D3483: Publish delegate geometry when ChildCount increases.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3482 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma,

[Differential] [Request, 10 lines] D3483: Publish delegate geometry when ChildCount increases.

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. hein added a dependency: D3482: Expose rowCount as data role in TaskGroupingProxyModel.. Restricted Application added a project: Plasma. REVISION SUMMARY Publishes delegate geometry

[Differential] [Request, 14 lines] D3482: Expose rowCount as data role in TaskGroupingProxyModel.

hein created this revision. hein added reviewers: Plasma, davidedmundson. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This adds a new data role "ChildCount" to AbstractTasksModel and implements it in TaskGroupingProxyModel. The

[Differential] [Closed] D3295: [server] Reduce overhead of pointersForSurface

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND1c6c2ee285cb: [server] Reduce overhead of pointersForSurface (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3295?vs=7975=8467

[Differential] [Closed] D3466: Implementation of PointerConstraints protcol

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDa6825301228b: Implementation of PointerConstraints protcol (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3466?vs=8425=8468