[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

2016-11-28 Thread aacid (Albert Astals Cid)
aacid added a comment. In https://phabricator.kde.org/D3530#65733, @davidedmundson wrote: > > These don't seem very "core" to me, maybe material for kio-extras ? > > Summarising the mailing list thread/bug report where this happened: > > The reason this came up is because Dolphin

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

2016-11-28 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > These don't seem very "core" to me, maybe material for kio-extras ? Summarising the mailing list thread/bug report where this happened: The reason this came up is because Dolphin effectively hard depends on them. Particularly remote:/ Dolphin in

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

2016-11-28 Thread aacid (Albert Astals Cid)
aacid added a comment. These don't seem very "core" to me, maybe material for kio-extras ? I'll let dfaure decide though :D REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure,

[Differential] [Request, 25 lines] D3533: Select correct index without timer

2016-11-28 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY remove the timer that selects the index at startup that caused flickering and things moving around since index

[Differential] [Updated] D3532: Select correct index without timer

2016-11-28 Thread mart (Marco Martin)
mart added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3532 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 129 lines] D3532: Select correct index without timer

2016-11-28 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY select the correct index upon loading when the count changes. this removes the flicker at startup and the view is at the correct wallpaper

[Differential] [Accepted] D3531: Drop kioslave folder, will be in KIO 5.30

2016-11-28 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. But don't merge till we merge the frameworks code obviously. REPOSITORY R120 Plasma Workspace BRANCH drop-slaves

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

2016-11-28 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio added a comment. In https://phabricator.kde.org/D3530#65685, @davidedmundson wrote: > Would it be possible to make the version in frameworks co-installable with plasma? > > As long as the .protocol file still says protocol=desktop, dolphin and Plasma won't care what

[Differential] [Updated] D3531: Drop kioslave folder, will be in KIO 5.30

2016-11-28 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio retitled this revision from "Drop kioslave folder, will be in KIO 5.29" to "Drop kioslave folder, will be in KIO 5.30". elvisangelaccio updated the summary for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL

[Differential] [Updated, 2,133 lines] D3531: Drop kioslave folder, will be in KIO 5.29

2016-11-28 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio updated this revision to Diff 8573. elvisangelaccio added a comment. - Bump minimum version, 5.29 is too close REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3531?vs=8572=8573 BRANCH drop-slaves REVISION DETAIL

[Differential] [Commented On] D3531: Drop kioslave folder, will be in KIO 5.29

2016-11-28 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio added a comment. In https://phabricator.kde.org/D3531#65681, @davidedmundson wrote: > 5.29 is in only a few days, that's way too close for a change this massive. > Especially one that requires a lot of distribution co-ordination as we're creating installation

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

2016-11-28 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Would it be possible to make the version in frameworks co-installable with plasma? As long as the .protocol file still says protocol=desktop, dolphin and Plasma won't care what the .protocol filename is; the protocol file says which library to load, and

[Differential] [Commented On] D3531: Drop kioslave folder, will be in KIO 5.29

2016-11-28 Thread lbeltrame (Luca Beltrame)
lbeltrame added a comment. Speaking as a distro person: this might cause issues. The reason is that *if* we update to KF 5.29 (or 30) with this and Plasma stays as a stable version, we will get interesting conflicts. And of course, removing this in a stable version is **not** an option.

[Differential] [Commented On] D3531: Drop kioslave folder, will be in KIO 5.29

2016-11-28 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. 5.29 is in only a few days, that's way too close for a change this massive. Especially one that requires a lot of distribution co-ordination as we're creating installation conflicts. Whilst I support this change in general, I don't want to see it going

[Differential] [Updated] D3530: Import plasma-workspace kioslaves

2016-11-28 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio added a dependent revision: D3531: Drop kioslave folder, will be in KIO 5.29. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: plasma-devel,

[Differential] [Request, 2,133 lines] D3531: Drop kioslave folder, will be in KIO 5.29

2016-11-28 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As discussed on plasma-devel. See https://phabricator.kde.org/D3530 This bumps the

[Differential] [Updated] D3531: Drop kioslave folder, will be in KIO 5.29

2016-11-28 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio added a dependency: D3530: Import plasma-workspace kioslaves. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel,

[Differential] [Request, 2,130 lines] D3530: Import plasma-workspace kioslaves

2016-11-28 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As discussed on plasma-devel, this patch imports the kioslaves from

Re: Minutes Monday Plasma Meeting

2016-11-28 Thread Sebastian Kügler
On maandag 28 november 2016 12:30:13 CET Marco Martin wrote: > Plasma Meeting minutes 28-11-2016 > > Present: kbroulik, Sho, bshah, notmart > [] Sorry I missed the meeting! Here's my portion: sebas: * merged kscreen dynmodes patches into stable * testing stuck on neon installer crashing *

Re: Split the kioslaves out of plasma-workspace?

2016-11-28 Thread Burkhard Lück
Am Montag, 28. November 2016, 13:45:26 CET schrieb Marco Martin: > On Sunday 27 November 2016, Elvis Angelaccio wrote: > > Otherwise I can just move the whole kioslave/ subfolder and say in the > > commit message something like "for older history, go look in > > plasma-workspace or in kde-runtime

[Differential] [Closed] D3528: Select correct index without timer

2016-11-28 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:ee2ec66a4155: Select correct index without timer (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3528?vs=8564=8568 REVISION DETAIL

[Differential] [Commented On] D3528: Select correct index without timer

2016-11-28 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3528#65626, @davidedmundson wrote: > Is this just a manifest of us populating the model in KCMLookandFeel::load which is after setSource? I tried to add a load() in kcmutils/KCModuleQml just before loading the qml file, but

Re: Split the kioslaves out of plasma-workspace?

2016-11-28 Thread Marco Martin
On Sunday 27 November 2016, Elvis Angelaccio wrote: > Otherwise I can just move the whole kioslave/ subfolder and say in the > commit message something like "for older history, go look in > plasma-workspace or in kde-runtime for even older history". i'm fine without history, tough taking out the

[Differential] [Accepted] D3528: Select correct index without timer

2016-11-28 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. Is this just a manifest of us populating the model in KCMLookandFeel::load which is after setSource? REPOSITORY R119

[Differential] [Request, 37 lines] D3528: Select correct index without timer

2016-11-28 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY remove the timer that selects the index at startup that caused flickering and things moving around since

Minutes Monday Plasma Meeting

2016-11-28 Thread Marco Martin
Plasma Meeting minutes 28-11-2016 Present: kbroulik, Sho, bshah, notmart kbroulik: * Improved API compliance in our Unity Launcher adaptation, should work better with 3rd party apps now * Been at LinuxDay in Dornbirn, presented Plasma there, overwhelmingly positive feedback, especially for the

Re: Affenfels: Plasma Sprint 6-12 Feb 2017

2016-11-28 Thread Kai Uwe Broulik
Hi, Recommended accommodation is ibis budget hotel Stuttgart Nord as mentioned in the wiki page. You'll have to book it yourself, sorry. See you there, Kai Uwe

[Differential] [Commented On] D3526: Align configure button consistently across delegates

2016-11-28 Thread Martin Gräßlin
graesslin added a comment. Please close https://bugs.kde.org/show_bug.cgi?id=372685 with it REPOSITORY R108 KWin BRANCH scaling_merged REVISION DETAIL https://phabricator.kde.org/D3526 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D3526: Align configure button consistently across delegates

2016-11-28 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH scaling_merged REVISION DETAIL https://phabricator.kde.org/D3526 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: