sebas updated this revision to Diff 8796.
sebas marked 15 inline comments as done.
sebas added a comment.
- improve osd test app
- call the dbus service from the test app
- also register the service
- Addressing Kai's review, part 1
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
sebas added inline comments.
INLINE COMMENTS
> broulik wrote in osd.cpp:120
> Compare with QL1S - in case you have KWindowSystem you can ask it
We only have KWindowSystem implicitly, I'm going with the
QGuiApplication::platformName() comparison (changed to QL1S).
> broulik wrote in
mart added a comment.
eew, sorry, that canvas thing was from an old experiment i did for a possible
alternative graphics, which i forgot to kill ;)
INLINE COMMENTS
> broulik wrote in main.xml:11
> I think this could even be the default?
not sure it's pretty enough for default (yet?), in
broulik added a comment.
Nifty. That I haven't thought of that kind of placement before. I always
wanted some crappy overlay like we had before.
Can you please check again with opacity mask instead of just overlaying a
Rectangle. Also, what's up with the Canvas thing?
INLINE COMMENTS
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> device.cpp:363-364
>
> -void Device::setLmrTapButtonMap(bool set) {
> +void Device::setLmrTapButtonMap(bool set)
> +{
>
mart updated this revision to Diff 8788.
mart added a comment.
- correct copyright
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3603?vs=8787=8788
BRANCH
phab/batterypercent
REVISION DETAIL
https://phabricator.kde.org/D3603
AFFECTED FILES
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
add an option to show a text label with the percentage value
in the battery icon. text will be shown
sebas added inline comments.
INLINE COMMENTS
> graesslin wrote in wayland_backend.cpp:574
> It's only the window title of the nested compositor. Given that KDE is the
> producer and Wayland Compositor is the product I think KDE Wayland Compositor
> is correct. Otherwise KDE Plasma Wayland
graesslin added inline comments.
INLINE COMMENTS
> sebas wrote in wayland_backend.cpp:574
> Plasma perhaps, instead of KDE?
It's only the window title of the nested compositor. Given that KDE is the
producer and Wayland Compositor is the product I think KDE Wayland Compositor
is correct.
sebas created this revision.
sebas added a reviewer: Plasma.
sebas added a subscriber: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This changeset moves the various OSDs used in kscreen (output
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3596
EMAIL PREFERENCES
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129615/
---
Review request for Plasma and Yichao Yu.
Repository: qtcurve
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
If we have the notification plasmoid visible and expanded we don't need
to see notifications
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
Smallish comments, otherwise looks good to me.
INLINE COMMENTS
> input.cpp:417
> +if (event->type() == QEvent::KeyPress) {
> +// is
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b97fdfa293dd: [Notifications] Never manually hide() the
NotificationPopup (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
Consider my comment, but up to you. Patch looks good otherwise.
INLINE COMMENTS
> wayland_backend.cpp:574
> +const QString title = i18nc("Title of nested
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
So, let's merge this? It's small enough...
REPOSITORY
R120 Plasma Workspace
BRANCH
notification-add-popup-null
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:f88c6a7e2152: [qrc] update ressource file (authored by
bearsh).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3591?vs=8764=8771
REVISION DETAIL
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3589
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson,
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3594
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik,
Plasma Meeting minutes 5-12-2016
Present: notmart, romangg, kbroulik, sebas, Riddell
romangg:
- worked on touchpad kcm and also did some stuff in kwin libinput backend.
- kwin stuff: https://phabricator.kde.org/D3590
notmart:
* fixed flicker of current thumbnail on startup of
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise the positioner will get
Christoph Feck wrote:
> On 04.12.2016 11:17, René J.V. Bertin wrote:
>> Under KDE4, the translations KCM had detailed settings for just about every
>> aspect
>
> See bug 340982.
Thanks, I suppose I could have found that ticket myself ...
> customizations, but progress is slow, so no code has
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6c7a2a65c1b7: [Notifications] Tighten layout (authored by
broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D3560?vs=8677=8769#toc
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:76baa59dea73: [Notification Popup] Clear notification
data after popup closed (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3559
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik,
mart added a comment.
In https://phabricator.kde.org/D3588#67023, @bearsh wrote:
> running `scripts/gen_qml_qrc.sh` produces a different diff. the question is
now, are all qml files (the script simply includes all available files)
required?
yes, all the qml files are required.
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
kirigami2 (branched from mart/Kirigami2)
REVISION DETAIL
https://phabricator.kde.org/D3591
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.
ok for this revision (in 5.8 as well) even tough it kinda masks the actual
problem, that is the wheel containmentactions plugin sometimes loaded in still
unknown
mart added a comment.
big +1 on this.
to make it build on kde4, even if it's not pretty, could the method
declarations be ifdeffed? implementations are mostly the same
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D3578
EMAIL PREFERENCES
mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> NotificationItem.qml:156
>
> -spacing: units.smallSpacing
> +spacing: units.smallSpacing / 2
>
you should still make sure
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This ensures there isn't a stray
32 matches
Mail list logo