Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

2016-12-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129704/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

[Differential] [Updated, 810 lines] D3805: Per-activity favorites (WIP)

2016-12-25 Thread Ivan Čukić
ivan updated the summary for this revision. ivan updated the test plan for this revision. ivan removed R119 Plasma Desktop as the repository for this revision. ivan updated this revision to Diff 9360. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3805?vs=9348&id=9360 REVISION DETAIL

[Differential] [Changed Subscribers] D3617: [Touchpad KCM] New KWin Wayland version

2016-12-25 Thread Thomas Lübking
luebking added inline comments. INLINE COMMENTS > subdiff wrote in kwinwaylandbackend.cpp:84 > Are you sure? The foreach keyword is still listed in the official Qt docu. > What's the best alternative? A normal for-loop? With upcounting integer or > iterator? "might deprecate it" - magic eightb

[Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version

2016-12-25 Thread subdiff (Roman Gilg)
subdiff added inline comments. INLINE COMMENTS > knambiar wrote in kwinwaylandbackend.cpp:72 > Just wondering whether these calls are synchronous and may cause delay in > startup. > Just wondering whether these calls are synchronous and may cause delay in > startup. I assume so. Should be no

[Differential] [Updated, 2,384 lines] D3617: [Touchpad KCM] New KWin Wayland version

2016-12-25 Thread subdiff (Roman Gilg)
subdiff updated this revision to Diff 9359. subdiff marked 12 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin, Plasma on Wayland. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3617?vs=8848&id=9359 REVISION D

[Differential] [Closed] D3777: notice when the only screen changes

2016-12-25 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:20b439a4f4a1: notice when the only screen changes (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9355&id=9357 REVISION DETAIL

[Differential] [Closed] D3777: notice when the only screen changes

2016-12-25 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f7b170de9fd9: notice when the only screen changes (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9355&id=9357 REVISION DETAIL

[Differential] [Updated, 35 lines] D3777: notice when the only screen changes

2016-12-25 Thread mart (Marco Martin)
mart updated this revision to Diff 9355. mart added a comment. - Revert "e a native event filter over XCB_RANDR_NOTIFY" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9352&id=9355 BRANCH arcpatch-D3777 REVISION DETAIL https://phabrica

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-25 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3777#71267, @mart wrote: > yep, you are right, at the beginning i tought this was a qscreen problen on top of the xcb qpa, but it turns out is x11 specific, so the nativeeventfilter is more correct there seems to be no XCB_RAN

[Differential] [Updated] D3630: [Digital Clock] Bug fixes and ui code optimization

2016-12-25 Thread subdiff (Roman Gilg)
subdiff updated the summary for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jens

[Differential] [Updated, 353 lines] D3630: [Digital Clock] Bug fixes and ui code optimization

2016-12-25 Thread subdiff (Roman Gilg)
subdiff updated this revision to Diff 9354. subdiff marked 2 inline comments as done. subdiff added a comment. Reduced code complexity (in particular only one date label for all states now) and optimized layouting in general. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE htt

[Differential] [Commented On] D3302: [Task Manager] Indicate applications playing audio

2016-12-25 Thread subdiff (Roman Gilg)
subdiff added a comment. Could be something like this made possible in icon only mode? F971459: taskbar-sound-indicator.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES https://phabricator.

Re: Review Request 129696: Fixes, popups from docks that use masking are misplaced

2016-12-25 Thread Michail Vourlakos
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129696/ --- (Updated Δεκ. 25, 2016, 10:35 πμ.) Review request for Plasma. Changes -